From: liuj97@gmail.com (Jiang Liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 6/7] arm64, jump label: optimize jump label implementation
Date: Sun, 15 Dec 2013 19:07:25 +0800 [thread overview]
Message-ID: <52AD8D6D.6090303@gmail.com> (raw)
In-Reply-To: <20131213105223.664f960b@gandalf.local.home>
On 12/13/2013 11:52 PM, Steven Rostedt wrote:
> On Fri, 13 Dec 2013 10:50:23 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> On Fri, 13 Dec 2013 15:41:04 +0000
>> Will Deacon <will.deacon@arm.com> wrote:
>>
>>>> +#include <linux/kernel.h>
>>>> +#include <linux/jump_label.h>
>>>> +#include <asm/jump_label.h>
>>>> +#include <asm/insn.h>
>>>> +
>>>> +#ifdef HAVE_JUMP_LABEL
>>>
>>> Slightly worrying... this should be CONFIG_HAVE_JUMP_LABEL, right? How did
>>> you manage to test this code?
>>
>> In <linux/jump_label.h> we have:
>>
>> #if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL)
>>
>> [...]
>>
>> # include <asm/jump_label.h>
>
> This also makes the include of <asm/jump_label.h> in the C file
> redundant.
>
> -- Steve
Thanks, Steve.
Will remove the redundant include header file.
>
>> # define HAVE_JUMP_LABEL
>> #endif /* CC_HAVE_ASM_GOTO && CONFIG_JUMP_LABEL */
>>
>>
>> -- Steve
>
next prev parent reply other threads:[~2013-12-15 11:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 16:03 [PATCH v6 0/7] Optimize jump label implementation for ARM64 Jiang Liu
2013-12-10 16:03 ` [PATCH v6 1/7] arm64: introduce basic aarch64 instruction decoding helpers Jiang Liu
2013-12-10 16:03 ` [PATCH v6 2/7] arm64: introduce interfaces to hotpatch kernel and module code Jiang Liu
2013-12-13 15:54 ` Will Deacon
2013-12-10 16:03 ` [PATCH v6 3/7] arm64: move encode_insn_immediate() from module.c to insn.c Jiang Liu
2013-12-10 16:03 ` [PATCH v6 4/7] arm64: introduce aarch64_insn_gen_{nop|branch_imm}() helper functions Jiang Liu
2013-12-13 15:58 ` Will Deacon
2013-12-10 16:03 ` [PATCH v6 5/7] arm64, jump label: detect %c support for ARM64 Jiang Liu
2013-12-10 16:03 ` [PATCH v6 6/7] arm64, jump label: optimize jump label implementation Jiang Liu
2013-12-13 15:41 ` Will Deacon
2013-12-13 15:50 ` Steven Rostedt
2013-12-13 15:52 ` Steven Rostedt
2013-12-15 11:07 ` Jiang Liu [this message]
2013-12-13 15:55 ` Will Deacon
2013-12-15 11:07 ` Jiang Liu
2013-12-10 16:03 ` [PATCH v6 7/7] jump_label: use defined macros instead of hard-coding for better readability Jiang Liu
2013-12-13 16:00 ` Will Deacon
2013-12-13 16:11 ` Steven Rostedt
2013-12-13 16:20 ` Steven Rostedt
2013-12-15 11:10 ` Jiang Liu
2013-12-18 15:55 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AD8D6D.6090303@gmail.com \
--to=liuj97@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).