From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/6] This patch converts the davinci gpio driver to use irqdomain support.
Date: Sun, 15 Dec 2013 18:06:01 +0530 [thread overview]
Message-ID: <52ADA231.4080603@ti.com> (raw)
In-Reply-To: <1385057731-4348-3-git-send-email-prabhakar.csengg@gmail.com>
On Thursday 21 November 2013 11:45 PM, Prabhakar Lad wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> [grygorii.strashko at ti.com:
> - switch to use one irq-domain per all GPIO banks
> - keep irq_create_mapping() call in gpio_to_irq_banked() as it
> simply transformed to irq_find_mapping() if IRQ mapping exist
> already]
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
A proper subject line is missing. I added the following as the subject:
gpio: davinci: convert to use irqdomain
and moved your current subject line to become the commit text.
> @@ -396,6 +411,20 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
> }
> clk_prepare_enable(clk);
>
> + irq = irq_alloc_descs(-1, 0, ngpio, 0);
> + if (irq < 0) {
> + dev_err(dev, "Couldn't allocate IRQ numbers\n");
> + return -ENODEV;
modified this to:
return irq;
since your have already received a more relevant error code. With these
modifications and Linus's ack, queuing for v3.14.
Thanks,
Sekhar
next prev parent reply other threads:[~2013-12-15 12:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 18:15 [PATCH v6 0/6] gpio: daVinci: cleanup and feature enhancement Prabhakar Lad
2013-11-21 18:15 ` [PATCH v6 1/6] gpio: davinci: use readl/writel instead of __raw_* Prabhakar Lad
2013-11-22 10:08 ` Taras Kondratiuk
2013-11-25 4:12 ` Prabhakar Lad
2013-11-25 10:34 ` Sekhar Nori
2013-11-26 8:29 ` Prabhakar Lad
2013-11-21 18:15 ` [PATCH v6 2/6] This patch converts the davinci gpio driver to use irqdomain support Prabhakar Lad
2013-11-29 9:23 ` Linus Walleij
2013-12-15 12:36 ` Sekhar Nori [this message]
2013-11-21 18:15 ` [PATCH v6 3/6] gpio: davinci: remove unused variable intc_irq_num Prabhakar Lad
2013-11-29 7:43 ` Linus Walleij
2013-12-15 12:39 ` Sekhar Nori
2013-11-21 18:15 ` [PATCH v6 4/6] gpio: davinci: add OF support Prabhakar Lad
2013-11-25 11:00 ` Sekhar Nori
2013-11-26 8:28 ` Prabhakar Lad
2013-11-26 12:33 ` Grygorii Strashko
2013-11-26 17:12 ` Sekhar Nori
2013-11-26 19:41 ` Grygorii Strashko
2013-11-27 3:59 ` Sekhar Nori
2013-11-29 7:46 ` Linus Walleij
2013-11-29 8:09 ` Sekhar Nori
2013-11-21 18:15 ` [PATCH v6 5/6] ARM: davinci: da850: add GPIO DT node Prabhakar Lad
2013-12-15 13:05 ` Sekhar Nori
2013-11-21 18:15 ` [PATCH v6 6/6] ARM: davinci: da850 evm: add GPIO pinumux entries " Prabhakar Lad
2013-12-15 13:13 ` Sekhar Nori
2013-12-17 10:20 ` Linus Walleij
2013-11-29 7:47 ` [PATCH v6 0/6] gpio: daVinci: cleanup and feature enhancement Linus Walleij
2013-11-29 8:30 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ADA231.4080603@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).