linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] arm: shmobile: genmai: adapt dts to use native i2c driver
Date: Wed, 18 Dec 2013 15:41:38 +0400	[thread overview]
Message-ID: <52B189F2.3080604@cogentembedded.com> (raw)
In-Reply-To: <1387316678-10174-5-git-send-email-wsa@the-dreams.de>

Hello.

On 18-12-2013 1:44, Wolfram Sang wrote:

> From: Wolfram Sang <wsa@sang-engineering.com>

> Switch from the gpio-driver to the shiny new native driver. Tested by
> accessing the eeprom on the genmai board.

> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
> Acked-by: Magnus Damm <damm@opensource.se>
> ---
>   arch/arm/boot/dts/r7s72100-genmai-reference.dts | 29 ++++++++++---------------
>   1 file changed, 11 insertions(+), 18 deletions(-)

> diff --git a/arch/arm/boot/dts/r7s72100-genmai-reference.dts b/arch/arm/boot/dts/r7s72100-genmai-reference.dts
> index ce5da0b..739448a 100644
> --- a/arch/arm/boot/dts/r7s72100-genmai-reference.dts
> +++ b/arch/arm/boot/dts/r7s72100-genmai-reference.dts
> @@ -39,24 +39,6 @@
>   			gpios = <&port4 11 GPIO_ACTIVE_LOW>;
>   		};
>   	};
> -
> -	i2c at 0 {
> -		compatible = "i2c-gpio";
> -		gpios = <&port1 5 GPIO_ACTIVE_HIGH /* sda */
> -			 &port1 4 GPIO_ACTIVE_HIGH /* scl */
> -			>;
> -		i2c-gpio,sda-open-drain;
> -		i2c-gpio,scl-open-drain;
> -		i2c-gpio,delay-us = <5>;	/* ~100 kHz */
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
> -		flash at 50 {
> -			compatible = "renesas,24c128";
> -			reg = <0x50>;
> -			pagesize = <64>;
> -		};
> -	};
>   };
>
>   &pfc {
> @@ -68,3 +50,14 @@
>   		renesas,function = "scif2";
>   	};
>   };
> +
> +&i2c2 {
> +	status = "okay";
> +	clock-frequency = <400000>;
> +
> +	eeprom: 24c128 at 50 {

    The node was called "flash at 50" for a reason: according to ePAPR spec,  for 
node names the generic device names should be used, not chip-specific.

> +		compatible = "renesas,24c128";
> +		reg = <0x50>;
> +		pagesize = <64>;
> +	};
> +};

WBR, Sergei

  parent reply	other threads:[~2013-12-18 11:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 21:44 [PATCH 0/5] arm: shmobile: r7s72100: add native i2c support Wolfram Sang
2013-12-17 21:44 ` [PATCH 1/5] pinctrl: r7s72100: add riic groups Wolfram Sang
2013-12-17 21:47   ` Wolfram Sang
2013-12-17 21:48   ` Laurent Pinchart
2013-12-17 21:44 ` [PATCH 2/5] arm: shmobile: r7s72100: add i2c clocks Wolfram Sang
2013-12-18 11:38   ` Sergei Shtylyov
2013-12-18 11:43     ` Wolfram Sang
2013-12-18 11:53       ` Sergei Shtylyov
2013-12-18 12:15         ` Wolfram Sang
2013-12-18 13:49           ` Simon Horman
2013-12-18 14:02             ` Sergei Shtylyov
2013-12-18 14:44               ` Magnus Damm
2013-12-18 15:13                 ` Sergei Shtylyov
2013-12-18 21:00             ` Wolfram Sang
2013-12-17 21:44 ` [PATCH 3/5] arm: shmobile: r7s72100: add nodes for i2c controllers to dtsi Wolfram Sang
2013-12-17 21:55   ` Laurent Pinchart
2013-12-17 22:13     ` Wolfram Sang
2013-12-17 22:16       ` Laurent Pinchart
2013-12-17 21:44 ` [PATCH 4/5] arm: shmobile: genmai: adapt dts to use native i2c driver Wolfram Sang
2013-12-17 21:57   ` Laurent Pinchart
2013-12-18 11:41   ` Sergei Shtylyov [this message]
2013-12-17 21:44 ` [PATCH 5/5] i2c: riic: add driver Wolfram Sang
2013-12-18  8:42   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B189F2.3080604@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).