From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: OMAP display subsystem - does it work?
Date: Mon, 23 Dec 2013 09:49:24 +0200 [thread overview]
Message-ID: <52B7EB04.6000606@ti.com> (raw)
In-Reply-To: <20131220160432.GZ27438@atomide.com>
On 2013-12-20 18:04, Tony Lindgren wrote:
>> This looks odd... Presuming the panel device was probed successfully, it
>> should always get the gpios or return an error. Only if gpio_is_valid()
>> returns false for the gpio, it skips it and continues. But in this case,
>> the gpio number comes from the platform data, so it should always be valid.
>>
>> And if it wasn't probed successfully, then there shouldn't be a fb0.
>
> I bet that's it though. If the display is probed before twl4030 GPIO
> is initialized, the GPIO numbers will be 0. I'm using omap2plus_defconfig
> which has DSS built as modules.
Ah, right, I see. The gpio numbers for the panel pdata are initialized
to -1 (not 0) in the board file. The twl init code will set those to
their appropriate numbers, but if the panel is probed before twl, the
panel driver just presumes gpios are not needed as they are -1.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131223/a6bd5089/attachment.sig>
next prev parent reply other threads:[~2013-12-23 7:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 12:00 OMAP display subsystem - does it work? Russell King - ARM Linux
2013-12-18 13:54 ` Tomi Valkeinen
2013-12-18 15:29 ` Russell King - ARM Linux
2013-12-18 16:03 ` Tomi Valkeinen
2013-12-18 18:23 ` Tony Lindgren
2013-12-19 5:23 ` Tomi Valkeinen
2013-12-19 16:56 ` Tony Lindgren
2013-12-20 7:45 ` Tomi Valkeinen
2013-12-19 17:56 ` Russell King - ARM Linux
2013-12-19 18:22 ` Tony Lindgren
2013-12-20 11:27 ` Russell King - ARM Linux
2013-12-20 11:48 ` Russell King - ARM Linux
2013-12-20 13:43 ` Tomi Valkeinen
2013-12-20 16:04 ` Tony Lindgren
2013-12-20 16:55 ` Tony Lindgren
2013-12-21 0:59 ` Russell King - ARM Linux
2013-12-28 23:30 ` Russell King - ARM Linux
2013-12-23 7:53 ` Tomi Valkeinen
2013-12-27 18:11 ` Tony Lindgren
2013-12-23 7:49 ` Tomi Valkeinen [this message]
2013-12-20 16:10 ` Tony Lindgren
2013-12-19 17:53 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B7EB04.6000606@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).