From: alex.elder@linaro.org (Alex Elder)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: support hardware-specific debugfs entries
Date: Thu, 26 Dec 2013 09:02:09 -0600 [thread overview]
Message-ID: <52BC44F1.9030205@linaro.org> (raw)
In-Reply-To: <20131226145052.GM8064@book.gsilab.sittig.org>
On 12/26/2013 08:50 AM, Gerhard Sittig wrote:
> On Thu, Dec 26, 2013 at 08:26 -0600, Alex Elder wrote:
>>
>> @@ -140,6 +147,9 @@ struct clk_ops {
>> int (*set_rate)(struct clk_hw *hw, unsigned long,
>> unsigned long);
>> void (*init)(struct clk_hw *hw);
>> +#ifdef CONFIG_COMMON_CLK_DEBUG
>> + int (*debug_init)(struct clk_hw *hw, struct dentry *dentry);
>> +#endif
>> };
>
> Please note that this CONFIG_COMMON_CLK_DEBUG switch may go away
> (or get replaced) soon. Mike plans to effectively enable common
> clock debugging as soon as debugfs is in effect (which I welcome
> very much).
Fine with me. I'll wait for further feedback before sending
out an updated patch. Thanks.
-Alex
>
> So you should monitor current development and adjust your patch,
> or be prepared for breakage and fixing afterwards. I'd suggest
> to just declare the .debug_init member unconditionally now.
> Since Mike's patch very likely gets accepted, and nothing will
> break when yours gets added later (regardless of the number of
> review iterations it will see).
>
>
> virtually yours
> Gerhard Sittig
>
next prev parent reply other threads:[~2013-12-26 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-26 14:26 [PATCH] clk: support hardware-specific debugfs entries Alex Elder
2013-12-26 14:50 ` Gerhard Sittig
2013-12-26 15:02 ` Alex Elder [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-30 5:58 Alex Elder
2013-12-30 5:59 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BC44F1.9030205@linaro.org \
--to=alex.elder@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).