From: john.stultz@linaro.org (John Stultz)
To: linux-arm-kernel@lists.infradead.org
Subject: v3.13-rc6+ regression (ARM board)
Date: Thu, 02 Jan 2014 13:34:19 -0800 [thread overview]
Message-ID: <52C5DB5B.9050604@linaro.org> (raw)
In-Reply-To: <CA+55aFz2dKw5HXy7DV1Aymoscg0MW7Zz28apan8dugUeqTd1QA@mail.gmail.com>
On 01/02/2014 12:43 PM, Linus Torvalds wrote:
> On Thu, Jan 2, 2014 at 12:30 PM, John Stultz <john.stultz@linaro.org> wrote:
>> So something else may be at play. Even with Linus' patch I reproduced a
>> similar hang here.
>>
>> Still chasing it down, but it looks like a seqlock deadlock where we're
>> calling read while holding the lock.
> Hmm. Only with lockdep, right?
Yep.
> Does lockdep perhaps read the scheduler clock? Afaik, we have
> lockstat_clock(), which uses local_clock(), which in turn translates
> to sched_clock_cpu(smp_processor_id())..
>
> So if that code now tries to read the scheduler clock when
> update_sched_clock() is doing a update and has done a
> write_seqcount_begin()...
Sigh. Deadlock by deadlock detection code.
So yea, it looks like this is the case.. though I've not been able to
get a backtrace during the hang to totally validate it (I'm just using
qemu's info registers and looking at the pc and lr).
So I'm guessing we'll just have to disable the lockdep logic here, which
is a little sad, since I'm a little nervous about the generic
sched_clock's locking (ie: works ok for ARM, but its not NMI safe), and
having some better debugging tools there would be helpful.
Anyway, I'll send out a patch to disable the lockdep usage here shortly.
thanks
-john
next prev parent reply other threads:[~2014-01-02 21:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 10:37 v3.13-rc6+ regression (ARM board) Krzysztof Hałasa
2013-12-31 10:45 ` Willy Tarreau
2014-01-02 10:02 ` Krzysztof Hałasa
2014-01-02 10:14 ` Uwe Kleine-König
2014-01-02 12:07 ` Krzysztof Hałasa
2014-01-02 19:38 ` Linus Torvalds
2014-01-02 20:03 ` John Stultz
2014-01-02 20:30 ` John Stultz
2014-01-02 20:42 ` Stephen Boyd
2014-01-02 20:52 ` John Stultz
2014-01-02 20:43 ` Linus Torvalds
2014-01-02 21:34 ` John Stultz [this message]
2014-01-02 21:54 ` [PATCH] sched_clock: Disable seqlock lockdep usage in sched_clock John Stultz
2014-01-02 22:15 ` Linus Torvalds
2014-01-02 22:21 ` John Stultz
2014-01-02 23:11 ` [PATCH 1/2] seqlock: Use raw_ prefix instead of _no_lockdep John Stultz
2014-01-02 23:11 ` [PATCH 2/2] sched_clock: Disable seqlock lockdep usage in sched_clock John Stultz
2014-01-03 0:46 ` Stephen Boyd
2014-01-03 6:05 ` Krzysztof Hałasa
2014-01-03 0:46 ` [PATCH 1/2] seqlock: Use raw_ prefix instead of _no_lockdep Stephen Boyd
2014-01-03 0:50 ` Linus Torvalds
2014-01-04 0:28 ` John Stultz
2014-01-06 10:10 ` Peter Zijlstra
2014-01-03 6:01 ` v3.13-rc6+ regression (ARM board) Krzysztof Hałasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C5DB5B.9050604@linaro.org \
--to=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).