From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] phy-core: Don't propagate -ENOSUPP from phy_pm_runtime_get_sync to caller
Date: Mon, 06 Jan 2014 21:37:09 +0400 [thread overview]
Message-ID: <52CAE9C5.5050307@cogentembedded.com> (raw)
In-Reply-To: <1388963189-13556-2-git-send-email-hdegoede@redhat.com>
Hello.
On 06-01-2014 3:06, Hans de Goede wrote:
> The phy-core allows phy_init and phy_power_on to be called multiple times,
> but before this patch -ENOSUPP from phy_pm_runtime_get_sync would be
> propagated to the caller for the 2nd and later calls.
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/phy/phy-core.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
> index d7b992e..8ee6157 100644
> --- a/drivers/phy/phy-core.c
> +++ b/drivers/phy/phy-core.c
> @@ -161,7 +161,8 @@ int phy_init(struct phy *phy)
> dev_err(&phy->dev, "phy init failed --> %d\n", ret);
> goto out;
> }
> - }
> + } else
> + ret = 0; /* Override possible ret == -ENOTSUPP */
*else* arm should have {} when the *if* arm has it.
> @@ -209,7 +210,8 @@ int phy_power_on(struct phy *phy)
> dev_err(&phy->dev, "phy poweron failed --> %d\n", ret);
> goto out;
> }
> - }
> + } else
> + ret = 0; /* Override possible ret == -ENOTSUPP */
Same here.
WBR, Sergei
next prev parent reply other threads:[~2014-01-06 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 23:06 [PATCH 1/2] phy-core: Don't print an error on probe deferral or nodata Hans de Goede
2014-01-05 23:06 ` [PATCH 2/2] phy-core: Don't propagate -ENOSUPP from phy_pm_runtime_get_sync to caller Hans de Goede
2014-01-06 17:37 ` Sergei Shtylyov [this message]
2014-01-07 8:56 ` Kishon Vijay Abraham I
2014-01-07 8:58 ` Kishon Vijay Abraham I
2014-01-07 9:13 ` Hans de Goede
2014-01-07 9:31 ` [PATCH 1/2] phy-core: Don't print an error on probe deferral or nodata Kishon Vijay Abraham I
2014-01-07 9:53 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CAE9C5.5050307@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).