From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] ARM: tegra: Add efuse bindings
Date: Mon, 06 Jan 2014 13:40:51 -0700 [thread overview]
Message-ID: <52CB14D3.2060904@wwwdotorg.org> (raw)
In-Reply-To: <1387891931-9854-4-git-send-email-pdeschrijver@nvidia.com>
On 12/24/2013 06:32 AM, Peter De Schrijver wrote:
> Add efuse bindings for Tegra20, Tegra30, Tegra114 and Tegra124.
This patch doesn't add bindings, it adds nodes to device trees. Bindings
are the schemas that dictate how the nodes are to be constructed, not
the nodes themselves.
On that topic, this series needs to create
Documentation/devicetree/bindings/fuse/nvidia,tegra20-fuse.txt etc.
> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> + efuse at 7000f800 {
...
> + };
> +
> cpus {
This node isn't sorted correctly. It should be between sdhci at 700b0600
and ahub at 70300000, not after the ahub.
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> + efuse at 7000F800 {
"fuse" might be a better node name; "efuse" is presumably the name of
the instance, not the type of object.
Please use lower-case for hex constants; both here and in the reg property.
next prev parent reply other threads:[~2014-01-06 20:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 13:32 [PATCH v2 0/6] efuse driver for Tegra Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 1/6] ARM: tegra: export apb dma readl/writel Peter De Schrijver
2014-01-06 20:07 ` Stephen Warren
2014-01-07 12:54 ` Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 2/6] misc: fuse: Add efuse driver for Tegra Peter De Schrijver
2014-01-06 20:32 ` Stephen Warren
2014-01-07 14:05 ` Peter De Schrijver
2014-01-07 20:41 ` Stephen Warren
2013-12-24 13:32 ` [PATCH v2 3/6] ARM: tegra: Add efuse bindings Peter De Schrijver
2014-01-06 20:40 ` Stephen Warren [this message]
2014-01-08 13:39 ` Thierry Reding
2014-01-08 18:50 ` Stephen Warren
2014-01-08 20:05 ` Thierry Reding
2014-01-08 20:09 ` Thierry Reding
2014-01-08 22:41 ` Stephen Warren
2014-01-09 12:40 ` Thierry Reding
2013-12-24 13:32 ` [PATCH v2 4/6] ARM: tegra: rework fuse.c Peter De Schrijver
2014-01-03 11:19 ` Alexandre Courbot
2014-01-06 20:50 ` Stephen Warren
2014-01-07 14:10 ` Peter De Schrijver
2014-01-07 20:47 ` Stephen Warren
2014-01-08 8:31 ` Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 5/6] ARM: Tegra: remove speedo files Peter De Schrijver
2013-12-24 13:32 ` [PATCH v2 6/6] misc: enable fuse drivers Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CB14D3.2060904@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).