linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] ARM: dts: OMAP5: Add 60MHz clock reference to USB Host module
Date: Wed, 8 Jan 2014 11:15:01 +0530	[thread overview]
Message-ID: <52CCE5DD.4040301@ti.com> (raw)
In-Reply-To: <201401071613.39245.arnd@arndb.de>

On 01/07/2014 08:43 PM, Arnd Bergmann wrote:
> On Tuesday 07 January 2014, Roger Quadros wrote:
>> USB Host driver (drivers/mfd/omap-usb-host.c) expects the 60MHz
>> reference clock to be named "init_60m_fclk". Provide this
>> information.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  arch/arm/boot/dts/omap5.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
>> index 2f12a47..e0ab379 100644
>> --- a/arch/arm/boot/dts/omap5.dtsi
>> +++ b/arch/arm/boot/dts/omap5.dtsi
>> @@ -765,6 +765,8 @@
>>                         #address-cells = <1>;
>>                         #size-cells = <1>;
>>                         ranges;
>> +                       clocks = <&l3init_60m_fclk>;
>> +                       clock-names = "init_60m_fclk";
>>  
>>                         usbhsohci: ohci at 4a064800 {
>>                                 compatible = "ti,ohci-omap3", "usb-ohci";
> 
> The bindings/mfd/omap-usb-host.txt file doesn't document any clocks.
> Please create another patch to document the clock names in this binding
> before you start putting them into the dtsi file. So far the clock
> names are an implementation detail of Linux as they are not part
> of the binding, and with your patch it becomes part of the ABI.
> 
Right. I'll re-post the series.

cheers,
-roger

  reply	other threads:[~2014-01-08  5:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07 12:14 [PATCH v3 0/4] USB Host support for OMAP5 uEVM (for 3.14) Roger Quadros
2014-01-07 12:14 ` [PATCH v3 1/4] ARM: dts: OMAP5: Add 60MHz clock reference to USB Host module Roger Quadros
2014-01-07 15:13   ` Arnd Bergmann
2014-01-08  5:45     ` Roger Quadros [this message]
2014-01-07 12:14 ` [PATCH v3 2/4] ARM: dts: omap4-panda: Provide USB PHY clock Roger Quadros
2014-01-07 12:14 ` [PATCH v3 3/4] ARM: dts: omap5-uevm: " Roger Quadros
2014-01-07 12:14 ` [PATCH v3 4/4] ARM: OMAP2+: Remove legacy_init_ehci_clk() Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CCE5DD.4040301@ti.com \
    --to=rogerq@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).