From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 08 Jan 2014 16:26:22 +0100 Subject: [PATCH v5 3/4] i2c: mv64xxx: Fix bus hang on A0 version of the Armada XP SoCs In-Reply-To: <20140108152139.GB15182@katana> References: <1389193589-18485-1-git-send-email-gregory.clement@free-electrons.com> <1389193589-18485-4-git-send-email-gregory.clement@free-electrons.com> <20140108152139.GB15182@katana> Message-ID: <52CD6E1E.5040409@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/01/2014 16:21, Wolfram Sang wrote: > On Wed, Jan 08, 2014 at 04:06:28PM +0100, Gregory CLEMENT wrote: >> The first variants of Armada XP SoCs (A0 stepping) have issues related >> to the i2c controller which prevent to use the offload mechanism and >> lead to a kernel hang during boot. >> >> The commit introduces a new the compatible string >> marvell,mv78230-a0-i2c for the i2c controller. When this compatible >> string is used the driver disables the offload mechanism and the >> kernel no more hangs on these SoCs. >> >> Signed-off-by: Gregory CLEMENT >> Reported-by: Andrew Lunn >> Cc: stable at vger.kernel.org >> --- >> drivers/i2c/busses/i2c-mv64xxx.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c >> index 8be7e42aa4de..f424c0f89946 100644 >> --- a/drivers/i2c/busses/i2c-mv64xxx.c >> +++ b/drivers/i2c/busses/i2c-mv64xxx.c >> @@ -692,6 +692,10 @@ static const struct of_device_id mv64xxx_i2c_of_match_table[] = { >> { .compatible = "allwinner,sun4i-i2c", .data = &mv64xxx_i2c_regs_sun4i}, >> { .compatible = "marvell,mv64xxx-i2c", .data = &mv64xxx_i2c_regs_mv64xxx}, >> { .compatible = "marvell,mv78230-i2c", .data = &mv64xxx_i2c_regs_mv64xxx}, >> + { >> + .compatible = "marvell,mv78230-a0-i2c", >> + .data = &mv64xxx_i2c_regs_mv64xxx >> + }, > > I think a oneliner entry like the entries above is easier to read, but > that is very minor... By using one line we would break the 80 character rule, hat why I did in this way. > > Acked-by: Wolfram Sang > Thanks! Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com