linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] Binding: atmel-wm8904: add option to choose clock
Date: Wed, 15 Jan 2014 18:17:21 +0100	[thread overview]
Message-ID: <52D6C2A1.4080405@atmel.com> (raw)
In-Reply-To: <1389669956-2304-4-git-send-email-voice.shen@atmel.com>

On 14/01/2014 04:25, Bo Shen :
> Add the option to choose clock output on which pin connect to SSC.
> Default is on TK pin to SSC, add clk_from_rk_pin option, the clock

Please do not use "_" in DT properties. It is a common pattern to use
"-" instead.

> is on RK pin to SSC.
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> 
>  Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt
> index 8bbe50c..68a5c1a 100644
> --- a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt
> +++ b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt
> @@ -33,6 +33,8 @@ Required properties:
>  
>  Optional properties:
>    - pinctrl-names, pinctrl-0: Please refer to pinctrl-bindings.txt
> +  - clk_from_rk_pin: according to hardware design, clk privide on rk pin

typo + more description is needed:
Please tell that it is a boolean property, that by default it is using
the TK pin (like in the commit message in fact).

Bye,

> +    to ssc device
>  
>  Example:
>  sound {
> 


-- 
Nicolas Ferre

  parent reply	other threads:[~2014-01-15 17:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-14  3:25 [PATCH 0/3] ASoC: atmel_ssc_dai: add option to choose clock Bo Shen
2014-01-14  3:25 ` [PATCH 1/3] ASoC: atmel_ssc_dai: make " Bo Shen
2014-01-14  3:25 ` [PATCH 2/3] ASoC: atmel_wm8904: make it available " Bo Shen
2014-01-14 20:36   ` Mark Brown
2014-01-16  1:31     ` Bo Shen
2014-01-27 20:59       ` Mark Brown
2014-01-15 17:16   ` Nicolas Ferre
2014-01-14  3:25 ` [PATCH 3/3] Binding: atmel-wm8904: add option " Bo Shen
2014-01-15 11:54   ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-16  1:33     ` Bo Shen
2014-01-16 11:03       ` Mark Brown
2014-01-15 17:17   ` Nicolas Ferre [this message]
2014-01-16  1:38     ` Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D6C2A1.4080405@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).