From: al.stone@linaro.org (Al Stone)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE_ONLY to enforce this ACPI mode
Date: Thu, 16 Jan 2014 11:35:29 -0700 [thread overview]
Message-ID: <52D82671.6000200@linaro.org> (raw)
In-Reply-To: <201401161155.27592.arnd@arndb.de>
On 01/16/2014 03:55 AM, Arnd Bergmann wrote:
> On Thursday 16 January 2014, Al Stone wrote:
>> On 01/14/2014 02:26 PM, Arnd Bergmann wrote:
>>> On Tuesday 14 January 2014 13:37:02 al.stone at linaro.org wrote:
>>>> +config ACPI_REDUCED_HARDWARE_ONLY
>>>> + bool "Hardware-reduced ACPI support only"
>>>> + def_bool n
>>>> + depends on ACPI && EXPERT
>>>
>>> I think this will cause a Kconfig warning if you try to select this
>>> on ARM64 without turning on EXPERT as well.
>>>
>>> It should be ok if you express it as
>>>
>>> config ACPI_REDUCED_HARDWARE_ONLY
>>> bool "Hardware-reduced ACPI support only" if EXPERT
>>> def_bool n
>>> depends on ACPI
>>>
>>>
>>> Arnd
>>>
>>
>> I am very puzzled. I went back and re-did my configs from
>> before, tried a few new ones, and tried with both expressions
>> above, but I could not get a Kconfig warning. Do you have an
>> example .config that shows the warning?
>>
>
> I don't have a source tree that allows turning on ACPI on arm64
> to easily test this. To clarify: the warning will only happen if
> you also add this piece to arch/arm64/Kconfig:
>
> select ACPI_REDUCED_HARDWARE_ONLY if ACPI
>
> Arnd
>
Right; I assumed I had to have that SELECT. My apologies -- I
still cannot reproduce the warning. I'll resubmit the patch
incorporating the suggestion, though, since the result ends up
being the same -- you must have ACPI and EXPERT selected in order
to enable ACPI_REDUCED_HARDWARE_ONLY.
Thanks.
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone at linaro.org
-----------------------------------
next prev parent reply other threads:[~2014-01-16 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 20:37 [PATCH] ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE_ONLY to enforce this ACPI mode al.stone at linaro.org
2014-01-14 21:26 ` Arnd Bergmann
2014-01-16 2:17 ` Al Stone
2014-01-16 10:55 ` Arnd Bergmann
2014-01-16 18:35 ` Al Stone [this message]
2014-01-17 15:10 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D82671.6000200@linaro.org \
--to=al.stone@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).