From mboxrd@z Thu Jan 1 00:00:00 1970 From: al.stone@linaro.org (Al Stone) Date: Thu, 16 Jan 2014 11:35:29 -0700 Subject: [PATCH] ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE_ONLY to enforce this ACPI mode In-Reply-To: <201401161155.27592.arnd@arndb.de> References: <1389731822-21336-1-git-send-email-al.stone@linaro.org> <15081767.3kxW799CSQ@wuerfel> <52D7414C.7080206@linaro.org> <201401161155.27592.arnd@arndb.de> Message-ID: <52D82671.6000200@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/16/2014 03:55 AM, Arnd Bergmann wrote: > On Thursday 16 January 2014, Al Stone wrote: >> On 01/14/2014 02:26 PM, Arnd Bergmann wrote: >>> On Tuesday 14 January 2014 13:37:02 al.stone at linaro.org wrote: >>>> +config ACPI_REDUCED_HARDWARE_ONLY >>>> + bool "Hardware-reduced ACPI support only" >>>> + def_bool n >>>> + depends on ACPI && EXPERT >>> >>> I think this will cause a Kconfig warning if you try to select this >>> on ARM64 without turning on EXPERT as well. >>> >>> It should be ok if you express it as >>> >>> config ACPI_REDUCED_HARDWARE_ONLY >>> bool "Hardware-reduced ACPI support only" if EXPERT >>> def_bool n >>> depends on ACPI >>> >>> >>> Arnd >>> >> >> I am very puzzled. I went back and re-did my configs from >> before, tried a few new ones, and tried with both expressions >> above, but I could not get a Kconfig warning. Do you have an >> example .config that shows the warning? >> > > I don't have a source tree that allows turning on ACPI on arm64 > to easily test this. To clarify: the warning will only happen if > you also add this piece to arch/arm64/Kconfig: > > select ACPI_REDUCED_HARDWARE_ONLY if ACPI > > Arnd > Right; I assumed I had to have that SELECT. My apologies -- I still cannot reproduce the warning. I'll resubmit the patch incorporating the suggestion, though, since the result ends up being the same -- you must have ACPI and EXPERT selected in order to enable ACPI_REDUCED_HARDWARE_ONLY. Thanks. -- ciao, al ----------------------------------- Al Stone Software Engineer Linaro Enterprise Group al.stone at linaro.org -----------------------------------