From: eric.nelson@boundarydevices.com (Eric Nelson)
To: linux-arm-kernel@lists.infradead.org
Subject: More GPIO madness on iMX6 - and the crappy ARM port of Linux
Date: Fri, 17 Jan 2014 13:12:04 -0700 [thread overview]
Message-ID: <52D98E94.6000609@boundarydevices.com> (raw)
In-Reply-To: <87ioti2xfu.fsf@lebrac.rtp-net.org>
On 01/17/2014 12:57 PM, Arnaud Patard (Rtp) wrote:
> Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
>
>> So, we have this wonderful GPIO layer which abstracts GPIO stuff and
>> hides stuff. It's really wonderful, because you don't have to care
>> about how the GPIOs are actually accessed in drivers anymore.
>>
>> However, what about the behaviour of GPIOs?
>>
>> What about... for example... this sequence:
>>
>> gpio_direction_output(gpio, 1);
>> val = gpio_get_value(gpio);
>>
>> What value is "val"? More importantly, what value is reflected in
>> /sys/kernel/debug/gpio ? Would it indicate that it's high or low?
>>
>> Now, while you can make reasonable assumptions, such as "it'll return
>> that the output is being driven to the requested state" or "it'll
>> return the actual state of the pin", what about this instead, which
>> happens on iMX hardware - "it'll _always_ return zero".
>>
>
> this is "expected". gpio layer docs are saying that in output case, the
> value may be wrong. Not intuitive but documented.
>
>> Yes, iMX6 at least has this behaviour. For any output, val as above
>> will always be zero, and /proc/sys/kernel/debug/gpio will always
>> report that an output is zero... unless the SION bit has been set for
>> that GPIO signal.
>
> afaik at least imx51/53 have some behaviour.
>
>>
>> The reason is that on hardware such as iMX6, reading the GPIO is done
>> by reading the pad state register, and this register is _only_ supplied
>> the state of the pad when the input path is enabled. The input path
>> is only enabled when the output is disabled, or the SION bit is set
>> to force the GPIO input path.
>
> I sent mails about this same issue for imx51 in Dec 2010 and answer were
> that the SION bit should not be set for all gpios:
> http://permalink.gmane.org/gmane.linux.ports.arm.kernel/100875
>
Thanks Arnaud,
This bit from the 2010 chain really needs some explanation:
>> Arnaud Patard (Rtp) writes:
>>
>> <snip>
>>
>> I had done the same, but had some trouble with this.
>> E.g. on our board GPIO1_7 is used as a generic GPIO to enable an
>> external clock oscillator for the USBH1 ULPI PHY. When the SION bit
>> for this pad was set, I got strange errors on the USBH1 port
>> (disconnecting low speed devices behind a hub would stall the
>> bus). When I removed the SION bit for that pin everything worked
>> well.
>>
Did you ever chase down the symptom here? Was the GPIO output not
holding a constant value such that the oscillator wasn't functioning?
Please advise,
Eric
next prev parent reply other threads:[~2014-01-17 20:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 18:47 More GPIO madness on iMX6 - and the crappy ARM port of Linux Russell King - ARM Linux
2014-01-17 19:13 ` Eric Nelson
2014-01-17 19:33 ` Eric Nelson
2014-01-17 19:40 ` Stephen Warren
2014-01-17 20:20 ` Uwe Kleine-König
2014-01-17 20:43 ` Russell King - ARM Linux
2014-01-17 21:53 ` Linus Walleij
2014-01-17 23:09 ` Eric Nelson
2014-01-17 20:24 ` Russell King - ARM Linux
2014-01-17 20:42 ` Stephen Warren
2014-01-17 20:53 ` Russell King - ARM Linux
2014-01-17 22:43 ` Linus Walleij
2014-01-21 2:55 ` Alexandre Courbot
2014-01-21 7:11 ` Lothar Waßmann
2014-01-21 9:26 ` Linus Walleij
2014-01-17 19:57 ` Arnaud Patard (Rtp)
2014-01-17 20:12 ` Eric Nelson [this message]
2014-01-17 20:33 ` Arnaud Patard (Rtp)
2014-01-17 22:02 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D98E94.6000609@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).