* [patch] ARM: mvebu: checking for IS_ERR() instead of NULL
@ 2014-01-21 6:52 Dan Carpenter
2014-01-21 8:24 ` Gregory CLEMENT
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2014-01-21 6:52 UTC (permalink / raw)
To: linux-arm-kernel
of_iomap() returns NULL on error, it doesn't return error pointers.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/arm/mach-mvebu/mvebu-soc-id.c b/arch/arm/mach-mvebu/mvebu-soc-id.c
index fe4fc1cbdfaf..b4cfbd62709d 100644
--- a/arch/arm/mach-mvebu/mvebu-soc-id.c
+++ b/arch/arm/mach-mvebu/mvebu-soc-id.c
@@ -88,7 +88,7 @@ static int __init mvebu_soc_id_init(void)
}
pci_base = of_iomap(child, 0);
- if (IS_ERR(pci_base)) {
+ if (!pci_base) {
pr_err("cannot map registers\n");
ret = -ENOMEM;
goto res_ioremap;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [patch] ARM: mvebu: checking for IS_ERR() instead of NULL
2014-01-21 6:52 [patch] ARM: mvebu: checking for IS_ERR() instead of NULL Dan Carpenter
@ 2014-01-21 8:24 ` Gregory CLEMENT
2014-01-21 8:43 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Gregory CLEMENT @ 2014-01-21 8:24 UTC (permalink / raw)
To: linux-arm-kernel
On 21/01/2014 07:52, Dan Carpenter wrote:
> of_iomap() returns NULL on error, it doesn't return error pointers.
>
Hi Dan,
Thanks for your patch but I already sent this fix yesterday and Jason have
applied. See: http://thread.gmane.org/gmane.linux.ports.arm.kernel/295642
Thanks,
Gregory
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/arch/arm/mach-mvebu/mvebu-soc-id.c b/arch/arm/mach-mvebu/mvebu-soc-id.c
> index fe4fc1cbdfaf..b4cfbd62709d 100644
> --- a/arch/arm/mach-mvebu/mvebu-soc-id.c
> +++ b/arch/arm/mach-mvebu/mvebu-soc-id.c
> @@ -88,7 +88,7 @@ static int __init mvebu_soc_id_init(void)
> }
>
> pci_base = of_iomap(child, 0);
> - if (IS_ERR(pci_base)) {
> + if (!pci_base) {
> pr_err("cannot map registers\n");
> ret = -ENOMEM;
> goto res_ioremap;
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [patch] ARM: mvebu: checking for IS_ERR() instead of NULL
2014-01-21 8:24 ` Gregory CLEMENT
@ 2014-01-21 8:43 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-01-21 8:43 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 21, 2014 at 09:24:16AM +0100, Gregory CLEMENT wrote:
> On 21/01/2014 07:52, Dan Carpenter wrote:
> > of_iomap() returns NULL on error, it doesn't return error pointers.
> >
>
> Hi Dan,
>
> Thanks for your patch but I already sent this fix yesterday and Jason have
> applied. See: http://thread.gmane.org/gmane.linux.ports.arm.kernel/295642
>
Cool. Congrats to Ezequiel on his new corporate email address. :)
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-21 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-21 6:52 [patch] ARM: mvebu: checking for IS_ERR() instead of NULL Dan Carpenter
2014-01-21 8:24 ` Gregory CLEMENT
2014-01-21 8:43 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).