From mboxrd@z Thu Jan 1 00:00:00 1970 From: t.figa@samsung.com (Tomasz Figa) Date: Thu, 23 Jan 2014 19:12:04 +0100 Subject: [PATCH 4/5] ARM: S3C24XX: convert boards to use common restart function In-Reply-To: <2227259.2cNbl9uzOp@phil> References: <3105326.uFdOVLyXH8@phil> <2227259.2cNbl9uzOp@phil> Message-ID: <52E15B74.3040409@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Heiko, On 06.01.2014 19:40, Heiko St?bner wrote: > This converts all boards to use the new common restart function instead > of SoC specific ones. > > The mach-s3c2416-dt board now tries to setup either a swrst- or watchdog- > reset so that it will be able to handle more s3c24xx-SoCs later on. [snip] > diff --git a/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c b/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c > index 0a86953..88716fa4 100644 > --- a/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c > +++ b/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c > @@ -24,6 +24,7 @@ > > #include > #include > +#include > > #include "common.h" > > @@ -34,6 +35,14 @@ static void __init s3c2416_dt_map_io(void) > > static void __init s3c2416_dt_machine_init(void) > { > + s3c24xx_swrst_reset_of_init(); > + > +#ifdef CONFIG_SAMSUNG_WDT_RESET > + /* if no special swrst-device exists try to find a watchdog */ > + if (!s3c24xx_swrst_reset_available()) > + samsung_wdt_reset_of_init(); > +#endif Hmm... I think it would be safe to assume availability of soft reset, especially if you could move the restart code to the clock driver. Best regards, Tomasz