From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Fri, 31 Jan 2014 10:50:40 -0500 Subject: [PATCH] usb: dwc3: keystone: switch to use runtime pm In-Reply-To: <20140131154721.GD20736@saruman.home> References: <1391174426-13773-1-git-send-email-grygorii.strashko@ti.com> <20140131151955.GB20736@saruman.home> <52EBC499.2070302@ti.com> <20140131154721.GD20736@saruman.home> Message-ID: <52EBC650.50305@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 31 January 2014 10:47 AM, Felipe Balbi wrote: > On Fri, Jan 31, 2014 at 10:43:21AM -0500, Santosh Shilimkar wrote: >> On Friday 31 January 2014 10:19 AM, Felipe Balbi wrote: >>> Hi, >>> >>> On Fri, Jan 31, 2014 at 03:20:26PM +0200, Grygorii Strashko wrote: >>>> The Keystone PM management layer has been implemented using PM bus for >>>> power management clocks. As result, most of Keystone drivers don't need >>>> to manage clocks directly. They just need to enable runtime PM and use it >>>> to handle their PM state and clocks. >>>> >>>> Hence, remove clock management code and switch to use runtime PM. >>>> >>>> Signed-off-by: Grygorii Strashko >>> >>> quite a few weeks back I sent a series enabling runtime pm for all glue >>> layers. I'll use that version instead, sorry. >>> >> That should be fine but you need to drop clk_*() related code >> from that patch. I assume you will send refresh version of it then. > > why ? it makes no difference if you enable twice and disable twice. > Sure but why do you want to have the clock node handling code in drivers if it is not needed. Isn't that better ?