[PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards

[PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards

[Sergei Shtylyov]

Hello.

   Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.

[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ

PS: Sorry for the previous mail, I've hit Ctrl-Enter unexpectedly.

WBR, Sergei

[PATCH v2 1/2] ARM: shmobile: Lager: pass Ether PHY IRQ

[Sergei Shtylyov]

Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
trigger type to be low-level as per the Micrel PHY driver's setup.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
Changes in version 2:
- refreshed the patch.

 arch/arm/mach-shmobile/board-lager.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-lager.c
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/board-lager.c
+++ renesas/arch/arm/mach-shmobile/board-lager.c
@@ -22,6 +22,7 @@
 #include <linux/gpio_keys.h>
 #include <linux/input.h>
 #include <linux/interrupt.h>
+#include <linux/irq.h>
 #include <linux/kernel.h>
 #include <linux/leds.h>
 #include <linux/mmc/host.h>
@@ -233,6 +234,7 @@ static const struct resource mmcif1_reso
 /* Ether */
 static const struct sh_eth_plat_data ether_pdata __initconst = {
 	.phy			= 0x1,
+	.phy_irq		= irq_pin(0),
 	.edmac_endian		= EDMAC_LITTLE_ENDIAN,
 	.phy_interface		= PHY_INTERFACE_MODE_RMII,
 	.ether_link_active_low	= 1,
@@ -618,6 +620,8 @@ static void __init lager_init(void)
 {
 	lager_add_standard_devices();
 
+	irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW);
+
 	if (IS_ENABLED(CONFIG_PHYLIB))
 		phy_register_fixup_for_id("r8a7790-ether-ff:01",
 					  lager_ksz8041_fixup);

[PATCH v2 2/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ

[Sergei Shtylyov]

Pass Ether's PHY IRQ (which is IRQC's IRQ0) to the 'sh_eth' driver. Set the IRQ
trigger type to be low-level as per the Micrel PHY driver's setup.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
Changes in version 2:
- refreshed the patch.

 arch/arm/mach-shmobile/board-koelsch.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: renesas/arch/arm/mach-shmobile/board-koelsch.c
===================================================================
--- renesas.orig/arch/arm/mach-shmobile/board-koelsch.c
+++ renesas/arch/arm/mach-shmobile/board-koelsch.c
@@ -23,6 +23,7 @@
 #include <linux/gpio.h>
 #include <linux/gpio_keys.h>
 #include <linux/input.h>
+#include <linux/irq.h>
 #include <linux/kernel.h>
 #include <linux/leds.h>
 #include <linux/phy.h>
@@ -92,6 +93,7 @@ static void __init koelsch_add_du_device
 /* Ether */
 static const struct sh_eth_plat_data ether_pdata __initconst = {
 	.phy			= 0x1,
+	.phy_irq		= irq_pin(0),
 	.edmac_endian		= EDMAC_LITTLE_ENDIAN,
 	.phy_interface		= PHY_INTERFACE_MODE_RMII,
 	.ether_link_active_low	= 1,
@@ -232,6 +234,8 @@ static void __init koelsch_init(void)
 {
 	koelsch_add_standard_devices();
 
+	irq_set_irq_type(irq_pin(0), IRQ_TYPE_LEVEL_LOW);
+
 	if (IS_ENABLED(CONFIG_PHYLIB))
 		phy_register_fixup_for_id("r8a7791-ether-ff:01",
 					  koelsch_ksz8041_fixup);

[PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards

[Magnus Damm]

Hi Sergei,

On Wed, Feb 5, 2014 at 12:51 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
>    Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> 'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
> IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
>
> [1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
> [1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ

Thanks, looking good!

/ magnus

[PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards

[Sergei Shtylyov]

Hello.

On 02/05/2014 10:25 AM, Magnus Damm wrote:

>>     Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
>> 'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
>> IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.

>> [1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
>> [1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ

> Thanks, looking good!

    Not at all, you've already tested these patches, IIRC.

> / magnus

WBR, Sergei

[PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards

[Simon Horman]

On Wed, Feb 05, 2014 at 07:36:58PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 02/05/2014 10:25 AM, Magnus Damm wrote:
> 
> >>    Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> >>'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
> >>IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.
> 
> >>[1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
> >>[1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ
> 
> >Thanks, looking good!
> 
>    Not at all, you've already tested these patches, IIRC.

Thanks, I have queued these up with Magnus's ack which
he supplied the previous time that you posted them.

[PATCH 0/2] Add Ether's PHY IRQ support for Lager/Koelsh boards

[Sergei Shtylyov]

Hello.

On 06-02-2014 10:34, Simon Horman wrote:

>>>>     Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
>>>> 'renesas-devel-v3.14-rc1-20130204' tag. Here we add support for the Ether's PHY
>>>> IRQ to the R8A7790/Lager and R8A7791/Koelsch boards.

>>>> [1/2] ARM: shmobile: Lager: pass Ether PHY IRQ
>>>> [1/2] ARM: shmobile: Koelsch: pass Ether PHY IRQ

>>> Thanks, looking good!

>>     Not at all, you've already tested these patches, IIRC.

> Thanks, I have queued these up with Magnus's ack which
> he supplied the previous time that you posted them.

    Oh, sorry, I forgot to pick it up myself. :-/

WBR, Sergei