* [PATCH] arm: add DSB after icache flush in __flush_icache_all()
@ 2014-02-05 9:33 Vinayak Kale
2014-02-05 13:26 ` Catalin Marinas
2014-02-09 6:09 ` Dirk Behme
0 siblings, 2 replies; 6+ messages in thread
From: Vinayak Kale @ 2014-02-05 9:33 UTC (permalink / raw)
To: linux-arm-kernel
Add DSB after icache flush to complete the cache maintenance operation.
Signed-off-by: Vinayak Kale <vkale@apm.com>
---
PS:
- This patch is tested for ARM-v7.
arch/arm/include/asm/cacheflush.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/include/asm/cacheflush.h b/arch/arm/include/asm/cacheflush.h
index ee753f1..ab91ebb 100644
--- a/arch/arm/include/asm/cacheflush.h
+++ b/arch/arm/include/asm/cacheflush.h
@@ -212,6 +212,7 @@ extern void copy_to_user_page(struct vm_area_struct *, struct page *,
static inline void __flush_icache_all(void)
{
__flush_icache_preferred();
+ dsb();
}
/*
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm: add DSB after icache flush in __flush_icache_all()
2014-02-05 9:33 [PATCH] arm: add DSB after icache flush in __flush_icache_all() Vinayak Kale
@ 2014-02-05 13:26 ` Catalin Marinas
2014-02-09 6:09 ` Dirk Behme
1 sibling, 0 replies; 6+ messages in thread
From: Catalin Marinas @ 2014-02-05 13:26 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Feb 05, 2014 at 09:33:02AM +0000, Vinayak Kale wrote:
> Add DSB after icache flush to complete the cache maintenance operation.
>
> Signed-off-by: Vinayak Kale <vkale@apm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: add DSB after icache flush in __flush_icache_all()
2014-02-05 9:33 [PATCH] arm: add DSB after icache flush in __flush_icache_all() Vinayak Kale
2014-02-05 13:26 ` Catalin Marinas
@ 2014-02-09 6:09 ` Dirk Behme
2014-02-10 10:43 ` Catalin Marinas
1 sibling, 1 reply; 6+ messages in thread
From: Dirk Behme @ 2014-02-09 6:09 UTC (permalink / raw)
To: linux-arm-kernel
Am 05.02.2014 10:33, schrieb Vinayak Kale:
> Add DSB after icache flush to complete the cache maintenance operation.
>
> Signed-off-by: Vinayak Kale <vkale@apm.com>
Should this go to -stable, too?
I haven't looked into the details, but at least it seems to apply
cleanly on a 3.8 kernel.
Best regards
Dirk
> ---
>
> PS:
> - This patch is tested for ARM-v7.
>
> arch/arm/include/asm/cacheflush.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/include/asm/cacheflush.h b/arch/arm/include/asm/cacheflush.h
> index ee753f1..ab91ebb 100644
> --- a/arch/arm/include/asm/cacheflush.h
> +++ b/arch/arm/include/asm/cacheflush.h
> @@ -212,6 +212,7 @@ extern void copy_to_user_page(struct vm_area_struct *, struct page *,
> static inline void __flush_icache_all(void)
> {
> __flush_icache_preferred();
> + dsb();
> }
>
> /*
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] arm: add DSB after icache flush in __flush_icache_all()
2014-02-09 6:09 ` Dirk Behme
@ 2014-02-10 10:43 ` Catalin Marinas
2014-02-10 17:07 ` Dirk Behme
0 siblings, 1 reply; 6+ messages in thread
From: Catalin Marinas @ 2014-02-10 10:43 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Feb 09, 2014 at 06:09:49AM +0000, Dirk Behme wrote:
> Am 05.02.2014 10:33, schrieb Vinayak Kale:
> > Add DSB after icache flush to complete the cache maintenance operation.
> >
> > Signed-off-by: Vinayak Kale <vkale@apm.com>
>
> Should this go to -stable, too?
>
> I haven't looked into the details, but at least it seems to apply
> cleanly on a 3.8 kernel.
It should. For the similar arm64 fix I added 'cc: stable' myself (commit
5044bad43ee57).
Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: add DSB after icache flush in __flush_icache_all()
2014-02-10 10:43 ` Catalin Marinas
@ 2014-02-10 17:07 ` Dirk Behme
2014-02-11 8:59 ` Vinayak Kale
0 siblings, 1 reply; 6+ messages in thread
From: Dirk Behme @ 2014-02-10 17:07 UTC (permalink / raw)
To: linux-arm-kernel
Am 10.02.2014 11:43, schrieb Catalin Marinas:
> On Sun, Feb 09, 2014 at 06:09:49AM +0000, Dirk Behme wrote:
>> Am 05.02.2014 10:33, schrieb Vinayak Kale:
>>> Add DSB after icache flush to complete the cache maintenance operation.
>>>
>>> Signed-off-by: Vinayak Kale <vkale@apm.com>
>>
>> Should this go to -stable, too?
>>
>> I haven't looked into the details, but at least it seems to apply
>> cleanly on a 3.8 kernel.
>
> It should. For the similar arm64 fix I added 'cc: stable' myself (commit
> 5044bad43ee57).
While the arm64 patch already hit mainline, I can't find this one in
mainline, -next or even the patch system, yet (?)
Vinayak: Could you put this patch into the patch system and CC stable,
please?
Thanks
Dirk
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: add DSB after icache flush in __flush_icache_all()
2014-02-10 17:07 ` Dirk Behme
@ 2014-02-11 8:59 ` Vinayak Kale
0 siblings, 0 replies; 6+ messages in thread
From: Vinayak Kale @ 2014-02-11 8:59 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 10, 2014 at 10:37 PM, Dirk Behme <dirk.behme@gmail.com> wrote:
> Am 10.02.2014 11:43, schrieb Catalin Marinas:
>
>> On Sun, Feb 09, 2014 at 06:09:49AM +0000, Dirk Behme wrote:
>>>
>>> Am 05.02.2014 10:33, schrieb Vinayak Kale:
>>>>
>>>> Add DSB after icache flush to complete the cache maintenance operation.
>>>>
>>>> Signed-off-by: Vinayak Kale <vkale@apm.com>
>>>
>>>
>>> Should this go to -stable, too?
>>>
>>> I haven't looked into the details, but at least it seems to apply
>>> cleanly on a 3.8 kernel.
>>
>>
>> It should. For the similar arm64 fix I added 'cc: stable' myself (commit
>> 5044bad43ee57).
>
>
> While the arm64 patch already hit mainline, I can't find this one in
> mainline, -next or even the patch system, yet (?)
>
> Vinayak: Could you put this patch into the patch system and CC stable,
> please?
Sure.
>
> Thanks
>
> Dirk
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-11 8:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-05 9:33 [PATCH] arm: add DSB after icache flush in __flush_icache_all() Vinayak Kale
2014-02-05 13:26 ` Catalin Marinas
2014-02-09 6:09 ` Dirk Behme
2014-02-10 10:43 ` Catalin Marinas
2014-02-10 17:07 ` Dirk Behme
2014-02-11 8:59 ` Vinayak Kale
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).