* [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
@ 2014-02-06 0:25 Simon Horman
2014-02-06 10:28 ` Laurent Pinchart
2014-02-10 12:22 ` Ben Dooks
0 siblings, 2 replies; 4+ messages in thread
From: Simon Horman @ 2014-02-06 0:25 UTC (permalink / raw)
To: linux-arm-kernel
This brings the implementation into line with the documentation.
This problem was introduced when SYS DMAC clock defines were added by
ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT
sources") in v3.13-rc2. I do not believe this results in any problems as
these defines do not appear to be used anywhere yet.
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
include/dt-bindings/clock/r8a7790-clock.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/dt-bindings/clock/r8a7790-clock.h b/include/dt-bindings/clock/r8a7790-clock.h
index 859e9be..6548a5f 100644
--- a/include/dt-bindings/clock/r8a7790-clock.h
+++ b/include/dt-bindings/clock/r8a7790-clock.h
@@ -46,8 +46,8 @@
#define R8A7790_CLK_MSIOF1 8
#define R8A7790_CLK_MSIOF3 15
#define R8A7790_CLK_SCIFB2 16
-#define R8A7790_CLK_SYS_DMAC0 18
-#define R8A7790_CLK_SYS_DMAC1 19
+#define R8A7790_CLK_SYS_DMAC1 18
+#define R8A7790_CLK_SYS_DMAC0 19
/* MSTP3 */
#define R8A7790_CLK_TPU0 4
--
1.8.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
2014-02-06 0:25 [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines Simon Horman
@ 2014-02-06 10:28 ` Laurent Pinchart
2014-02-07 0:24 ` Simon Horman
2014-02-10 12:22 ` Ben Dooks
1 sibling, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2014-02-06 10:28 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
Thank you for the patch.
On Thursday 06 February 2014 09:25:01 Simon Horman wrote:
> This brings the implementation into line with the documentation.
>
> This problem was introduced when SYS DMAC clock defines were added by
> ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT
> sources") in v3.13-rc2. I do not believe this results in any problems as
> these defines do not appear to be used anywhere yet.
>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> include/dt-bindings/clock/r8a7790-clock.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/dt-bindings/clock/r8a7790-clock.h
> b/include/dt-bindings/clock/r8a7790-clock.h index 859e9be..6548a5f 100644
> --- a/include/dt-bindings/clock/r8a7790-clock.h
> +++ b/include/dt-bindings/clock/r8a7790-clock.h
> @@ -46,8 +46,8 @@
> #define R8A7790_CLK_MSIOF1 8
> #define R8A7790_CLK_MSIOF3 15
> #define R8A7790_CLK_SCIFB2 16
> -#define R8A7790_CLK_SYS_DMAC0 18
> -#define R8A7790_CLK_SYS_DMAC1 19
> +#define R8A7790_CLK_SYS_DMAC1 18
> +#define R8A7790_CLK_SYS_DMAC0 19
>
> /* MSTP3 */
> #define R8A7790_CLK_TPU0 4
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
2014-02-06 10:28 ` Laurent Pinchart
@ 2014-02-07 0:24 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2014-02-07 0:24 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 06, 2014 at 11:28:52AM +0100, Laurent Pinchart wrote:
> Hi Simon,
>
> Thank you for the patch.
>
> On Thursday 06 February 2014 09:25:01 Simon Horman wrote:
> > This brings the implementation into line with the documentation.
> >
> > This problem was introduced when SYS DMAC clock defines were added by
> > ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT
> > sources") in v3.13-rc2. I do not believe this results in any problems as
> > these defines do not appear to be used anywhere yet.
> >
> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks, I have queued this up.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
2014-02-06 0:25 [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines Simon Horman
2014-02-06 10:28 ` Laurent Pinchart
@ 2014-02-10 12:22 ` Ben Dooks
1 sibling, 0 replies; 4+ messages in thread
From: Ben Dooks @ 2014-02-10 12:22 UTC (permalink / raw)
To: linux-arm-kernel
On 06/02/14 00:25, Simon Horman wrote:
> This brings the implementation into line with the documentation.
>
> This problem was introduced when SYS DMAC clock defines were added by
> ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT
> sources") in v3.13-rc2. I do not believe this results in any problems as
> these defines do not appear to be used anywhere yet.
>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Ben Dooks <ben.dooks@codethink.co.uk>
I agree, although I have yet to get the DMA working.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-10 12:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-06 0:25 [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines Simon Horman
2014-02-06 10:28 ` Laurent Pinchart
2014-02-07 0:24 ` Simon Horman
2014-02-10 12:22 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).