* [PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()
@ 2014-01-12 20:34 Heiko Stübner
2014-02-12 0:20 ` Heiko Stübner
2014-02-13 22:19 ` Kukjin Kim
0 siblings, 2 replies; 3+ messages in thread
From: Heiko Stübner @ 2014-01-12 20:34 UTC (permalink / raw)
To: linux-arm-kernel
The function is nearly empty and samsung_cpu_rev is static so already 0
making the function obsolete, therefore remove it.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
arch/arm/mach-s3c24xx/common.c | 1 -
arch/arm/plat-samsung/cpu.c | 7 -------
arch/arm/plat-samsung/include/plat/cpu.h | 1 -
3 files changed, 9 deletions(-)
diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c
index bf57d4c..97edd4d 100644
--- a/arch/arm/mach-s3c24xx/common.c
+++ b/arch/arm/mach-s3c24xx/common.c
@@ -232,7 +232,6 @@ void __init s3c24xx_init_io(struct map_desc *mach_desc, int size)
} else {
samsung_cpu_id = s3c24xx_read_idcode_v4();
}
- s3c24xx_init_cpu();
s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
diff --git a/arch/arm/plat-samsung/cpu.c b/arch/arm/plat-samsung/cpu.c
index 46b426e..364963a 100644
--- a/arch/arm/plat-samsung/cpu.c
+++ b/arch/arm/plat-samsung/cpu.c
@@ -28,13 +28,6 @@ unsigned int samsung_rev(void)
}
EXPORT_SYMBOL(samsung_rev);
-void __init s3c24xx_init_cpu(void)
-{
- /* nothing here yet */
-
- samsung_cpu_rev = 0;
-}
-
void __init s3c64xx_init_cpu(void)
{
samsung_cpu_id = __raw_readl(S3C_VA_SYS + 0x118);
diff --git a/arch/arm/plat-samsung/include/plat/cpu.h b/arch/arm/plat-samsung/include/plat/cpu.h
index 8f09488..262ef86 100644
--- a/arch/arm/plat-samsung/include/plat/cpu.h
+++ b/arch/arm/plat-samsung/include/plat/cpu.h
@@ -207,7 +207,6 @@ extern void s5p_init_irq(u32 *vic, u32 num_vic);
extern void s3c24xx_init_io(struct map_desc *mach_desc, int size);
-extern void s3c24xx_init_cpu(void);
extern void s3c64xx_init_cpu(void);
extern void s5p_init_cpu(void __iomem *cpuid_addr);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()
2014-01-12 20:34 [PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu() Heiko Stübner
@ 2014-02-12 0:20 ` Heiko Stübner
2014-02-13 22:19 ` Kukjin Kim
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stübner @ 2014-02-12 0:20 UTC (permalink / raw)
To: linux-arm-kernel
Am Sonntag, 12. Januar 2014, 21:34:29 schrieb Heiko St?bner:
> The function is nearly empty and samsung_cpu_rev is static so already 0
> making the function obsolete, therefore remove it.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
ping :-)
> ---
> arch/arm/mach-s3c24xx/common.c | 1 -
> arch/arm/plat-samsung/cpu.c | 7 -------
> arch/arm/plat-samsung/include/plat/cpu.h | 1 -
> 3 files changed, 9 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c
> index bf57d4c..97edd4d 100644
> --- a/arch/arm/mach-s3c24xx/common.c
> +++ b/arch/arm/mach-s3c24xx/common.c
> @@ -232,7 +232,6 @@ void __init s3c24xx_init_io(struct map_desc *mach_desc,
> int size) } else {
> samsung_cpu_id = s3c24xx_read_idcode_v4();
> }
> - s3c24xx_init_cpu();
>
> s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
>
> diff --git a/arch/arm/plat-samsung/cpu.c b/arch/arm/plat-samsung/cpu.c
> index 46b426e..364963a 100644
> --- a/arch/arm/plat-samsung/cpu.c
> +++ b/arch/arm/plat-samsung/cpu.c
> @@ -28,13 +28,6 @@ unsigned int samsung_rev(void)
> }
> EXPORT_SYMBOL(samsung_rev);
>
> -void __init s3c24xx_init_cpu(void)
> -{
> - /* nothing here yet */
> -
> - samsung_cpu_rev = 0;
> -}
> -
> void __init s3c64xx_init_cpu(void)
> {
> samsung_cpu_id = __raw_readl(S3C_VA_SYS + 0x118);
> diff --git a/arch/arm/plat-samsung/include/plat/cpu.h
> b/arch/arm/plat-samsung/include/plat/cpu.h index 8f09488..262ef86 100644
> --- a/arch/arm/plat-samsung/include/plat/cpu.h
> +++ b/arch/arm/plat-samsung/include/plat/cpu.h
> @@ -207,7 +207,6 @@ extern void s5p_init_irq(u32 *vic, u32 num_vic);
>
> extern void s3c24xx_init_io(struct map_desc *mach_desc, int size);
>
> -extern void s3c24xx_init_cpu(void);
> extern void s3c64xx_init_cpu(void);
> extern void s5p_init_cpu(void __iomem *cpuid_addr);
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()
2014-01-12 20:34 [PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu() Heiko Stübner
2014-02-12 0:20 ` Heiko Stübner
@ 2014-02-13 22:19 ` Kukjin Kim
1 sibling, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2014-02-13 22:19 UTC (permalink / raw)
To: linux-arm-kernel
On 01/13/14 05:34, Heiko St?bner wrote:
> The function is nearly empty and samsung_cpu_rev is static so already 0
> making the function obsolete, therefore remove it.
>
> Signed-off-by: Heiko Stuebner<heiko@sntech.de>
> ---
> arch/arm/mach-s3c24xx/common.c | 1 -
> arch/arm/plat-samsung/cpu.c | 7 -------
> arch/arm/plat-samsung/include/plat/cpu.h | 1 -
> 3 files changed, 9 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c
> index bf57d4c..97edd4d 100644
> --- a/arch/arm/mach-s3c24xx/common.c
> +++ b/arch/arm/mach-s3c24xx/common.c
> @@ -232,7 +232,6 @@ void __init s3c24xx_init_io(struct map_desc *mach_desc, int size)
> } else {
> samsung_cpu_id = s3c24xx_read_idcode_v4();
> }
> - s3c24xx_init_cpu();
>
> s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
>
> diff --git a/arch/arm/plat-samsung/cpu.c b/arch/arm/plat-samsung/cpu.c
> index 46b426e..364963a 100644
> --- a/arch/arm/plat-samsung/cpu.c
> +++ b/arch/arm/plat-samsung/cpu.c
> @@ -28,13 +28,6 @@ unsigned int samsung_rev(void)
> }
> EXPORT_SYMBOL(samsung_rev);
>
> -void __init s3c24xx_init_cpu(void)
> -{
> - /* nothing here yet */
> -
> - samsung_cpu_rev = 0;
> -}
> -
> void __init s3c64xx_init_cpu(void)
> {
> samsung_cpu_id = __raw_readl(S3C_VA_SYS + 0x118);
> diff --git a/arch/arm/plat-samsung/include/plat/cpu.h b/arch/arm/plat-samsung/include/plat/cpu.h
> index 8f09488..262ef86 100644
> --- a/arch/arm/plat-samsung/include/plat/cpu.h
> +++ b/arch/arm/plat-samsung/include/plat/cpu.h
> @@ -207,7 +207,6 @@ extern void s5p_init_irq(u32 *vic, u32 num_vic);
>
> extern void s3c24xx_init_io(struct map_desc *mach_desc, int size);
>
> -extern void s3c24xx_init_cpu(void);
> extern void s3c64xx_init_cpu(void);
> extern void s5p_init_cpu(void __iomem *cpuid_addr);
>
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-13 22:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-12 20:34 [PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu() Heiko Stübner
2014-02-12 0:20 ` Heiko Stübner
2014-02-13 22:19 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).