Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
	abelvesa@kernel.org, abel.vesa@linaro.org,
	mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-kernel@vger.kernel.org,
	Peng Fan <peng.fan@nxp.com>,
	linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH V3 0/2] clk: imx: introduce fsl,always-on-clocks
Date: Tue, 13 Sep 2022 20:15:02 +0800	[thread overview]
Message-ID: <52a95490-477f-f1c8-4fe5-9c27e447912e@oss.nxp.com> (raw)
In-Reply-To: <20220913102957.sir37bsdr5sayxal@pengutronix.de>



On 9/13/2022 6:29 PM, Marco Felsch wrote:
> Hi Peng,
> 
> On 22-09-13, Peng Fan (OSS) wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> V3:
>>   Rename to fsl,always-on-clocks
>>
>> V2:
>>   Use protected-clocks
>>   https://lore.kernel.org/all/20220816130327.2987710-1-peng.fan@oss.nxp.com/
>>
>> V1:
>>   Use fsl,protected-clocks
>>   https://lore.kernel.org/all/20220815033632.1687854-1-peng.fan@oss.nxp.com/
>>
>> There are two cases that I wanna this property could serve:
>> Virtualization: root cell linux run in parallel with inmate cell
>> AMP: M7/4 runs in parallel with A53
>>
>> The major case is:
>> Jailhouse hypervisor only support partition, so devices are partitioned.
>> But there is only CCM module that provides clock, the CCM is handled by
>> root cell linux, need make sure the root cell linux not shutdown the
>> clocks using by inmate cell.
>>
>> I was thinking whether need to provide a rate entry to ask root cell
>> configure the clk rate for inmate cell. But NXP downstream not have it,
>> see https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/clk/imx/clk-imx8mp.c?h=lf-5.15.y#n690
>> So just leave the property as uint32-array.
> 
> Can you please check my recent proposal? I recently stumbled over such
> an issue on the mx8mm-evk as well but with the 32k clock provided by the
> pmic. Unfortunately I forgot to add you to the to list, I will change
> that. If that proposal will fix your problem, I would like to go the
> generic way.

I vote for a generic solution.

Thanks,
Peng.

> 
> https://patchwork.kernel.org/project/linux-clk/list/?series=676522
> 
> Regards,
>    Marco
> 
> 
>>
>> This patchset could also benifit AMP case, check the two commits
>> commit 19565ea12d61 ("clk: imx: add mcore_booted module paratemter")
>> commit d097cc045b64 ("clk: imx8mp: remove SYS PLL 1/2 clock gates")
>> Although I not plan to drop the upper two patches, this patchset
>> exposes opportunity for better power consumption.
>>
>> Peng Fan (2):
>>    dt-bindings: clock: imx8m/imx93: introduce fsl,always-on-clocks
>>      property
>>    clk: imx: support fsl,always-on-clocks
>>
>>   .../bindings/clock/imx8m-clock.yaml           |  4 ++++
>>   .../bindings/clock/imx93-clock.yaml           |  4 ++++
>>   drivers/clk/imx/clk-imx8mm.c                  |  2 ++
>>   drivers/clk/imx/clk-imx8mn.c                  |  2 ++
>>   drivers/clk/imx/clk-imx8mp.c                  |  2 ++
>>   drivers/clk/imx/clk-imx8mq.c                  |  2 ++
>>   drivers/clk/imx/clk.c                         | 21 +++++++++++++++++++
>>   drivers/clk/imx/clk.h                         |  2 ++
>>   8 files changed, 39 insertions(+)
>>
>> -- 
>> 2.37.1
>>
>>
>>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2022-09-13 12:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13  9:21 [PATCH V3 0/2] clk: imx: introduce fsl,always-on-clocks Peng Fan (OSS)
2022-09-13  9:21 ` [PATCH V3 1/2] dt-bindings: clock: imx8m/imx93: introduce fsl,always-on-clocks property Peng Fan (OSS)
2022-09-13  9:29   ` Peng Fan
2022-09-13 10:45     ` Krzysztof Kozlowski
2022-09-13  9:21 ` [PATCH V3 2/2] clk: imx: support fsl,always-on-clocks Peng Fan (OSS)
2022-09-13 10:03 ` [PATCH V3 0/2] clk: imx: introduce fsl,always-on-clocks Alexander Stein
2022-09-13 10:29 ` Marco Felsch
2022-09-13 10:47   ` Krzysztof Kozlowski
2022-09-13 11:49     ` Marco Felsch
2022-09-13 12:15   ` Peng Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52a95490-477f-f1c8-4fe5-9c27e447912e@oss.nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=abel.vesa@linaro.org \
    --cc=abelvesa@kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=mturquette@baylibre.com \
    --cc=peng.fan@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox