From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm64: Add seccomp support
Date: Wed, 19 Feb 2014 20:39:09 +0900 [thread overview]
Message-ID: <530497DD.2020806@linaro.org> (raw)
In-Reply-To: <20140218153856.GB904@localhost>
On 02/19/2014 12:38 AM, Catalin Marinas wrote:
> On Fri, Feb 07, 2014 at 10:11:31AM +0000, AKASHI Takahiro wrote:
>> --- a/arch/arm64/kernel/ptrace.c
>> +++ b/arch/arm64/kernel/ptrace.c
>> @@ -26,6 +26,7 @@
>> #include <linux/smp.h>
>> #include <linux/ptrace.h>
>> #include <linux/user.h>
>> +#include <linux/seccomp.h>
>> #include <linux/security.h>
>> #include <linux/init.h>
>> #include <linux/signal.h>
>> @@ -1064,6 +1065,10 @@ asmlinkage int syscall_trace(int dir, struct pt_regs *regs)
>> {
>> unsigned long saved_reg;
>>
>> + if (!dir && secure_computing((int)regs->syscallno))
>> + /* seccomp failures shouldn't expose any additional code. */
>> + return -1;
>
> That's only restricted to the arm64 code but could we use a more
> meaningful error number?
Other architectures, including arm, also return just -1 in syscall_trace_enter(),
but of course, we can use another value, say, -EPERM or -ENOSYS?
-Takahiro AKASHI
next prev parent reply other threads:[~2014-02-19 11:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 10:11 [PATCH 0/2] arm64: Add seccomp support AKASHI Takahiro
2014-02-07 10:11 ` [PATCH 1/2] " AKASHI Takahiro
2014-02-07 14:44 ` Arnd Bergmann
[not found] ` <CAB5YjtB6XnXRd90AUw=rJCOBKyfcngTQd3Kxft33XLCK+K=Vuw@mail.gmail.com>
2014-02-12 11:05 ` Arnd Bergmann
2014-02-12 11:17 ` Arnd Bergmann
2014-02-18 15:38 ` Catalin Marinas
2014-02-19 11:39 ` AKASHI Takahiro [this message]
2014-02-19 16:41 ` Catalin Marinas
2014-02-20 0:34 ` AKASHI Takahiro
2014-02-07 10:11 ` [PATCH 2/2] arm64: is_compat_task is defined both in asm/compat.h and linux/compat.h AKASHI Takahiro
2014-02-17 19:32 ` Will Deacon
2014-02-19 11:16 ` AKASHI Takahiro
2014-02-25 9:20 ` [PATCH v2 0/3] arm64: Add seccomp support AKASHI Takahiro
2014-02-25 9:20 ` [PATCH v2 1/3] asm-generic: Add generic seccomp.h for secure computing mode 1 AKASHI Takahiro
2014-02-25 9:20 ` [PATCH v2 2/3] arm64: Add seccomp support AKASHI Takahiro
2014-02-28 17:20 ` Will Deacon
2014-03-06 2:34 ` AKASHI Takahiro
2014-03-06 15:24 ` Will Deacon
2014-02-25 9:20 ` [PATCH v2 3/3] arm64: is_compat_task is defined both in asm/compat.h and linux/compat.h AKASHI Takahiro
2014-02-28 16:58 ` Will Deacon
2014-03-13 10:17 ` [PATCH v3 0/3] arm64: Add seccomp support AKASHI Takahiro
2014-03-13 10:17 ` [PATCH v3 1/3] asm-generic: Add generic seccomp.h for secure computing mode 1 AKASHI Takahiro
2014-03-14 17:08 ` Catalin Marinas
2014-03-13 10:17 ` [PATCH v3 2/3] arm64: Add seccomp support AKASHI Takahiro
2014-03-13 10:17 ` [PATCH v3 3/3] arm64: is_compat_task is defined both in asm/compat.h and linux/compat.h AKASHI Takahiro
2014-03-15 5:50 ` [PATCH_v4 0/2] arm64: Add seccomp support AKASHI Takahiro
2014-03-15 5:50 ` [PATCH_v4 1/2] asm-generic: Add generic seccomp.h for secure computing mode 1 AKASHI Takahiro
2014-03-15 5:50 ` [PATCH_v4 2/2] arm64: Add seccomp support AKASHI Takahiro
2014-06-25 14:53 ` [PATCH_v4 0/2] " Mark Salter
2014-06-26 0:57 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530497DD.2020806@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).