From: "Heiko Stübner" <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
linux-phy@lists.infradead.org, Dragan Simic <dsimic@manjaro.org>
Cc: vkoul@kernel.org, kishon@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] phy: phy-rockchip-inno-usb2: Perform trivial code cleanups
Date: Wed, 21 Aug 2024 10:39:54 +0200 [thread overview]
Message-ID: <5307900.6fTUFtlzNn@diego> (raw)
In-Reply-To: <14167d6b025e18d2a06ee429feea6551ef6f9c44.1724225528.git.dsimic@manjaro.org>
Am Mittwoch, 21. August 2024, 09:37:53 CEST schrieb Dragan Simic:
> Perform a few trivial code cleanups, e.g. to obey the reverse Christmas tree
> rule, to avoid use of "{ ... }" code blocks where they aren't really needed,
> or to avoid line wrapping by using the 100-column width better.
>
> No intended functional changes are introduced by these code cleanups.
>
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
> @@ -445,7 +445,6 @@ static int rockchip_usb2phy_extcon_register(struct rockchip_usb2phy *rphy)
> }
>
> rphy->edev = edev;
> -
> return 0;
> }
depending on how nitpicky we want to be, I'm not very fond of this change.
Assigning the extcon-dev and returning "0" are two different actions, and
I think most drivers do actually use a blank line between those.
But that really is just a style preference for me, so anyway
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2024-08-21 8:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 7:37 [PATCH v2 0/3] Improve error handling in Rockchip Inno USB 2.0 PHY driver Dragan Simic
2024-08-21 7:37 ` [PATCH v2 1/3] phy: phy-rockchip-inno-usb2: Perform trivial code cleanups Dragan Simic
2024-08-21 8:39 ` Heiko Stübner [this message]
2024-08-21 8:53 ` Dragan Simic
2024-08-21 7:37 ` [PATCH v2 2/3] phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better Dragan Simic
2024-08-21 8:41 ` Heiko Stübner
2024-08-21 8:55 ` Dragan Simic
2024-08-21 11:17 ` Christophe JAILLET
2024-08-21 19:05 ` Dragan Simic
2024-08-21 7:37 ` [PATCH v2 3/3] phy: phy-rockchip-inno-usb2: Improve error handling while probing Dragan Simic
2024-08-21 8:44 ` Heiko Stübner
2024-08-21 9:09 ` Dragan Simic
2024-08-21 9:17 ` Heiko Stübner
2024-08-21 9:34 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5307900.6fTUFtlzNn@diego \
--to=heiko@sntech.de \
--cc=dsimic@manjaro.org \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox