linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: b.brezillon@overkiz.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] clk: at91: propagate rate change on system clks
Date: Thu, 27 Feb 2014 09:16:39 +0100	[thread overview]
Message-ID: <530EF467.5000504@overkiz.com> (raw)
In-Reply-To: <20140227004229.12081.25317@quantum>

Hi Mike,

On 27/02/2014 01:42, Mike Turquette wrote:
> Quoting Jean-Jacques Hiblot (2014-02-05 00:37:36)
>> From: Boris BREZILLON <b.brezillon@overkiz.com>
>>
>> System clks are just gates, and thus do not provide any rate operations.
>> Authorize clk rate change to be propagated to system clk parents.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
>> ---
>>   drivers/clk/at91/clk-system.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/at91/clk-system.c b/drivers/clk/at91/clk-system.c
>> index 8f7c043..a98557b 100644
>> --- a/drivers/clk/at91/clk-system.c
>> +++ b/drivers/clk/at91/clk-system.c
>> @@ -84,7 +84,8 @@ at91_clk_register_system(struct at91_pmc *pmc, const char *name,
>>           * (see drivers/memory) which would request and enable the ddrck clock.
>>           * When this is done we will be able to remove CLK_IGNORE_UNUSED flag.
>>           */
>> -       init.flags = CLK_IGNORE_UNUSED;
>> +       init.flags = CLK_SET_RATE_GATE | CLK_SET_RATE_PARENT |
> Just wanted to do a quick sanity check here. Do you really need
> CLK_SET_RATE_GATE?

After taking a closer look, I'd say I don't need this flag, because it's
already set on programmable clks, am I right ?

Do you want me to send a new version removing this flag ?

> Otherwise these patches look fine.
>
> Regards,
> Mike
>
>> +                    CLK_IGNORE_UNUSED;
>>   
>>          sys->id = id;
>>          sys->hw.init = &init;
>> -- 
>> 1.8.5.2
>>

  reply	other threads:[~2014-02-27  8:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05  8:37 [PATCH v2 0/4] clk: at91: better support for the PCKs Jean-Jacques Hiblot
2014-02-05  8:37 ` [PATCH v2 1/4] clk: at91: replace prog clk round_rate with determine_rate Jean-Jacques Hiblot
2014-02-05  8:37 ` [PATCH v2 2/4] clk: at91: propagate rate change on system clks Jean-Jacques Hiblot
2014-02-27  0:42   ` Mike Turquette
2014-02-27  8:16     ` Boris BREZILLON [this message]
2014-02-05  8:37 ` [PATCH v2 3/4] clk: at91: fix programmable clk irq handling Jean-Jacques Hiblot
2014-02-05  8:37 ` [PATCH v2 4/4] clk: at91: optimization of the determine_rate callback Jean-Jacques Hiblot
2014-02-05  8:54   ` Boris BREZILLON
2014-02-17 15:24     ` [PATCH v2] clk: at91: optimization of the set_rate callback Jean-Jacques Hiblot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530EF467.5000504@overkiz.com \
    --to=b.brezillon@overkiz.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).