From: florian.vaussard@epfl.ch (Florian Vaussard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/8] ARM: dts: omap3-overo: Use complete poweroff
Date: Thu, 27 Feb 2014 21:48:23 +0100 [thread overview]
Message-ID: <530FA497.7000407@epfl.ch> (raw)
In-Reply-To: <530FA23E.1040909@ti.com>
On 02/27/2014 09:38 PM, Nishanth Menon wrote:
> On 02/27/2014 02:30 PM, Florian Vaussard wrote:
>> Currently, the TWL4030 PMIC does not completely poweroff the processor.
>> Commit b0fc1da4d0359d3cce8f12e0f014aed0704ae202 introduced the necessary
>> binding to do this, so use it.
>>
>> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
>> ---
>> arch/arm/boot/dts/omap3-overo.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi
>> index aea64c0..018e1e0 100644
>> --- a/arch/arm/boot/dts/omap3-overo.dtsi
>> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
>> @@ -73,6 +73,11 @@
>> codec {
>> };
>> };
>> +
>> + twl_power: power {
>> + compatible = "ti,twl4030-power";
>> + ti,use_poweroff;
>> + };
>> };
>> };
>>
>>
> Urrgh.. this slipped past.. :(
>
> ti,system-power-controller is traditionally used for other PMICs from
> TI to indicate that poweroff functionality will be provided by the
> PMIC driver. similar approach is taken by Maxim as well.. I know the
> commit introducing the binding has been around for long, but
> considering that we do not have a single dts using this yet, should we
> consider adding "ti,system-power-controller"(as against removing
> ti,use_poweroff - so that older down stream dtbs still work) and using
> it in the new code?
>
It does make sense, so I am not against it. My only concern is that I
find the name to be slightly less easy to understand, but I can live
with it :-)
I do not remember if DT maintainers came up with a clear policy to
deprecate a binding.
Regards,
Florian
next prev parent reply other threads:[~2014-02-27 20:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 20:30 [PATCH v2 0/8] ARM: dts: Better support for Gumstix Overo Florian Vaussard
2014-02-27 20:30 ` [PATCH v2 1/8] ARM: dts: omap3-tobi: Add missing pinctrl Florian Vaussard
2014-02-27 20:30 ` [PATCH v2 2/8] ARM: dts: omap3-overo: " Florian Vaussard
2014-02-27 20:30 ` [PATCH v2 3/8] ARM: dts: omap3-overo: Use complete poweroff Florian Vaussard
2014-02-27 20:38 ` Nishanth Menon
2014-02-27 20:48 ` Florian Vaussard [this message]
2014-02-27 21:07 ` Nishanth Menon
2014-03-03 8:55 ` Florian Vaussard
2014-02-27 20:30 ` [PATCH v2 4/8] ARM: dts: omap3-overo: Enable WiFi/BT combo Florian Vaussard
2014-02-27 20:30 ` [PATCH v2 5/8] ARM: dts: omap3-overo: Add HSUSB PHY Florian Vaussard
2014-02-27 20:30 ` [PATCH v2 6/8] ARM: dts: omap: Add common file for SMSC9221 Florian Vaussard
2014-02-27 20:30 ` [PATCH v2 7/8] ARM: dts: omap3-tobi: Use include file omap-gpmc-smsc9221 Florian Vaussard
2014-02-27 20:30 ` [PATCH v2 8/8] ARM: dts: omap3-tobi: Add AT24C01 EEPROM Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530FA497.7000407@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).