From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.ujfalusi@ti.com (Peter Ujfalusi) Date: Tue, 4 Mar 2014 11:42:46 +0200 Subject: [PATCH 2/5] drivers: bus: omap_l3: Convert to use devm_request_and_ioremap() In-Reply-To: <1393924359.866301359@f148.i.mail.ru> References: <1393923710-10377-1-git-send-email-peter.ujfalusi@ti.com> <1393923710-10377-3-git-send-email-peter.ujfalusi@ti.com> <1393924359.866301359@f148.i.mail.ru> Message-ID: <5315A016.3090504@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/04/2014 11:12 AM, Alexander Shiyan wrote: > ???????, 4 ????? 2014, 11:01 +02:00 ?? Peter Ujfalusi : >> We can then remove the iounmap() calls from probe and remove. >> Since the driver requests the resources via index we can do the mem resource >> request within a for loop. >> >> Signed-off-by: Peter Ujfalusi >> Reviewed-by: Santosh Shilimkar >> --- > >> + /* Get mem resources */ >> + for (i = 0; i < 3; i++) { >> + struct resource *res = platform_get_resource(pdev, >> + IORESOURCE_MEM, i); >> + if (!res) { >> + dev_err(&pdev->dev, "couldn't find resource %d\n", i); >> + return -ENODEV; >> + } > > No need to check "res". devm_request_and_ioremap() do all for us. True. -- P?ter