linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: maxime.coquelin@st.com (Maxime Coquelin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: DT: STi: Add support to B2020 revision E board.
Date: Tue, 11 Mar 2014 13:15:49 +0100	[thread overview]
Message-ID: <531EFE75.9010709@st.com> (raw)
In-Reply-To: <20140311112342.GE21216@lee--X1>



On 03/11/2014 12:23 PM, Lee Jones wrote:
>>> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>>>
>>> This patch adds support to rev E board of B2020 which has few minor
>>> changes :
>>> 	PHY reset PIO (Change from PIO30 to PIO07)
>>> 	Power LED(Green) Control(Change from PIO47 to PIO13)
>>
>> I thought we decided last October to support only one revision of
>> the b2020 board.
>>
>> The idea was to create an external git to provide DTS for all our
>> boards, and only have a minimal subset in in the kernel.
>
> Ah, I was unaware of that conversation/decision. If that's the case we
> can scrap this submission along with the following patch.

In fact we had the discussion together with Arnd (IIRC) on #armlinux :)

The reason is we wanted to avoid flooding arch/arm/dts/ with all the 
possible combinations of board revisions.

The idea was to put in place a git repository at stlinux.com to provide 
the DTS for all the STi boards, and try to keep arch/arm/dts/sti* simple.

>
> JOOI, what happens if I want to boot Mainline on my revE board? It
> won't be fully functional will it? That will be a shame. The LEDs, not
> so much, but networking is a pretty big piece of functionality to
> lose.

I agree this is not comfortable.

The problem is that your patch is not enough. We would need to create 
much more files, because for example, the i2c used are not the same 
between rev. C and rev. E.

It gives theses files only for b2020 support:
   arch/arm/boot/dts/stih415-b2020.dts
   arch/arm/boot/dts/stih416-b2020e.dts
   arch/arm/boot/dts/stih41x-b2020e.dtsi
   arch/arm/boot/dts/stih416-b2020.dts
   arch/arm/boot/dts/stih41x-b2020.dtsi
   arch/arm/boot/dts/stih41x-b2020x.dtsi

Regards,
Maxime

  reply	other threads:[~2014-03-11 12:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 10:22 [PATCH 1/3] ARM: DT: STi: Add support to B2020 revision E board Lee Jones
2014-03-11 10:22 ` [PATCH 2/3] ARM: STi: stih416-b2020: Explicitly include STiH416 Pinctrl bindings Lee Jones
2014-03-11 10:52   ` Maxime Coquelin
2014-03-11 11:17     ` Lee Jones
2014-03-11 11:20     ` Lee Jones
2014-03-11 10:22 ` [PATCH 3/3] ARM: STi: stih41x: Provide a proper header for this DTSI file Lee Jones
2014-03-11 10:49 ` [PATCH 1/3] ARM: DT: STi: Add support to B2020 revision E board Maxime Coquelin
2014-03-11 11:23   ` Lee Jones
2014-03-11 12:15     ` Maxime Coquelin [this message]
2014-03-11 13:23       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531EFE75.9010709@st.com \
    --to=maxime.coquelin@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).