From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F946C433F5 for ; Fri, 15 Oct 2021 17:18:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 078CA600CD for ; Fri, 15 Oct 2021 17:18:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 078CA600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=AyWE1FRglheTtKzbsXgC7acMfNU977aScDU6z1cgmQA=; b=gS8L/X2LEcldse/JFaN8+ix471 t9WNoDGy19rxCzJf5m7jLFGlOwrUK1tNyuCiMdkOq/KlrV+xcCkCHJ3hxVtBP67zuJxT+2TfaNIsB ocovgNdMKt4o9w9sI5gLMRwKi63Hx87yRF0sUnb2cuUR+mbWQ2TIMBZ79JS58bcYxKnghlp/OpgeY Swm+wV01K3kwsX9m6ZOwJEXcB0G014wppcZZuS11oJNdz/FxUCl2N+3fqNp4ws7gZ1IZMzR0478pu RqS4wklM/Q7OovuHfizEjqaPOtA0U5DUfpKfFFfNW3rP0sMch1eL4P2aYpAymfSw+ffbRZiY4i5DU rvQBk3fQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbQpJ-008HEH-0v; Fri, 15 Oct 2021 17:17:02 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mbQoo-008H5o-1Y for linux-arm-kernel@lists.infradead.org; Fri, 15 Oct 2021 17:16:32 +0000 Received: by mail-pg1-x52c.google.com with SMTP id j190so2424128pgd.0 for ; Fri, 15 Oct 2021 10:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nNU/Jlv2Z8cbVRwF3uZFRercElyzOMBVYw9cMxYKxuw=; b=hN/4clyKdcquXclbvcXDjifrAC5C7tXFpaOABzlWCNUeB7sx8GJeIIVfww1oE8qv5b liFfVLF6kf5FaPoagCWeN4ED+NNt87xy+h3F9v2hN0aG+Lk75pi60xImfJ7AtKfVFGLI snkxk9OQ3XvTt0pV9TWnmd7HRcfN3b118uryDDLR8jQ1Jb+bousljKcKYdeAKOAlR7Cu /yTJhviiRaBHZjQY4Dq3I3edtMrplcdNHTruH0ilE2WzratxhXS9xfVXB2SCIenI/Rhm l/1fHaD2mc9DAgia0NJIzQD2JKH6n6RS8A7sJLFyvwpA1yHnHa/ESWWhA/oK/Ep9MTpP qR0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nNU/Jlv2Z8cbVRwF3uZFRercElyzOMBVYw9cMxYKxuw=; b=OcS/0w+w3xkv/Qdg612jpPRYtoJYQ7ES4il5rHKq0rm5XV1DeM+WFyyZGZxquLEJYN JbaRHATXr0Pk5ZMl4eX3PXDYVezLjJSydwSow0drwYb8RgUYCxxgaAdq5B0zR8EzHIvj H9QCGzaNBYn20WAUKqrWJonYNl2D5QIRdHhNXFV6igt6zQlEpdm577OZ7YGaopIhPK9D oJ681VfaDeyKYL7uPk+tGf97JxDwpys0xvKxXEvrPiMY/5sj5ENaqUNw8YldN+fTnnwb U3x/399mEWtUDwgtW0jDYDsPAx2wSBAcSAZCUcZvlFzzpkKrYhBMkSlodAu4Fj+D3E1E HPrA== X-Gm-Message-State: AOAM532jqaLWNmKflvbdW+pLFN1suP/iEliUFROjVhtPnPfu0fJ++EYA 87z1dcztX0l5NE+Z2n2NuZQ= X-Google-Smtp-Source: ABdhPJyeVQ4RBcDSAtV/MP8O6OdXDyGXgWtMA2JJsP4mR4E29TlsXLxOlQ5lyi8886/0iXwWwGcyVA== X-Received: by 2002:a62:7506:0:b0:44c:efe8:4167 with SMTP id q6-20020a627506000000b0044cefe84167mr12897706pfc.59.1634318188961; Fri, 15 Oct 2021 10:16:28 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id k1sm5262100pjj.54.2021.10.15.10.16.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Oct 2021 10:16:28 -0700 (PDT) Subject: Re: [PATCH net-next 1/6] ARM: dts: imx6qp-prtwd3: update RGMII delays for sja1105 switch To: Vladimir Oltean , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Shawn Guo , Andrew Lunn , Heiner Kallweit , Russell King , Vivien Didelot , Vladimir Oltean , Prasanna Vengateshan , Ansuel Smith , =?UTF-8?Q?Alvin_=c5=a0ipraga?= References: <20211013222313.3767605-1-vladimir.oltean@nxp.com> <20211013222313.3767605-2-vladimir.oltean@nxp.com> From: Florian Fainelli Message-ID: <531b85ec-4227-85b5-f1c7-206f293ec0b9@gmail.com> Date: Fri, 15 Oct 2021 10:16:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211013222313.3767605-2-vladimir.oltean@nxp.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211015_101630_169590_071D828D X-CRM114-Status: GOOD ( 17.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/13/21 3:23 PM, Vladimir Oltean wrote: > In the new behavior, the sja1105 driver expects there to be explicit > RGMII delays present on the fixed-link ports, otherwise it will complain > that it falls back to legacy behavior, which is to apply RGMII delays > incorrectly derived from the phy-mode string. > > In this case, the legacy behavior of the driver is to apply both RX and > TX delays. To preserve that, add explicit 2 nanosecond delays, which are > identical with what the driver used to add (a 90 degree phase shift). > The delays from the phy-mode are ignored by new kernels (it's still > RGMII as long as it's "rgmii*" something), and the explicit > {rx,tx}-internal-delay-ps properties are ignored by old kernels, so the > change works both ways. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel