From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966ACC433E0 for ; Wed, 24 Jun 2020 16:27:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AC7920857 for ; Wed, 24 Jun 2020 16:27:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jxFU+2/0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fr2l7dlU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AC7920857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PFsLViKigYvipXN5bK2M2btduRrr2wJdcUT2959jgGs=; b=jxFU+2/0GBZsj8K5DlTI9BwMp UmpP+HClUAwyDX6h1/5fqDLKTINfSavXFKlb0Gko1+TouOkHgFW4gm3w3jYfyE+RHm6X7oSWq4MO+ UJcyPuVKKAvo+0jZAJMMVaI9wukxMQtTcLL20R16W8CFDtYvqFV/6tFK8Kj3tJVbYGqvFxGrSlDEM QMJjUrS0di5Rv8/MIF1IifvLMEMg3yOKMGfm/o6P5CVd1d9jJKrFQ7LoxsjotCGpQ3sS3egTGSoB9 qPn33m4LQHYuuwM5NiV2H6dRy18nBOIzZ1VfWZfe5mg0KLzS0/rDRwOJxYTq1hV4eKpx0ZKNAj4ZE CbZ2/co5w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo8DS-0007JF-4y; Wed, 24 Jun 2020 16:25:39 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo8DN-0007Hc-8R for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 16:25:34 +0000 Received: by mail-qk1-x744.google.com with SMTP id l188so2362313qkf.10 for ; Wed, 24 Jun 2020 09:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EX+waRZgWkttNQFyEQaMEGS91DwT52qIcg8cn7tx7x0=; b=Fr2l7dlUKiPmEZHXthnoPVJaBTDZ8tQeygaptwCtWakFBu/hKZPdpO/cvCjH+6z1Ww Fxd9euxfiC7WJvmRvoI2XwPwPTz8FnhdXODfS/QXWcgg2M7IsoyxD+LiRoMRxBlEUou7 A1gpl7Qfjjs8rBxSL+vGRHtgUV2Xnh5vWVS/5jYGK3GICSd30q7HORJT2XqKzjtNQR2t RGwcwH7R+sLpmW3sJB+aXG456xgsJ7J6PMjKch90MS8eVFynfnkVfRNccG2uJGGIggbW icl3XbyIpR2rDt4zBps0WklWsRilZT1peDuYmDsqSNstJGm/C6KSyZeg6yil9cFZrzL2 B6Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EX+waRZgWkttNQFyEQaMEGS91DwT52qIcg8cn7tx7x0=; b=GNfGWinLgQ20JAvU4rxa8+bn3XQvkdBaTM2pJBwg5PgA63RP8VZMrbfjPZdFQFNnRb gZHBzdRN0jqBTvVhREkXksuz/5+RVccQ3vn5X5NL1PbiUGIxUGdZV0KT9iQwY0mAClbr Tp89UEaK4FD/HMU5NXy8Ei9VrL1IZ9y78bdC3esXAIKyZwbGLkgYAvqi7e6oXjL2pQK/ qB42QHP/9fuNkIl3OFKGYrh+F2yiIqKjbtlshriXoskGiTfP6pEFAXxZjfxLIrn/sKqy wIK6ZH5m0h8mDiit/eFVXziBcwmRLEQFjySoTIV8J1T18wuwQSIpDLEKqSvYvtyXW5j5 yGqA== X-Gm-Message-State: AOAM531A6wISWDjD9vCoZYFCLQvElZXeyWYVfdlwvx8HY1J3J6azsTse /y58hC/PnvbJbQQWa4HZ6uE= X-Google-Smtp-Source: ABdhPJwxFli0DGylImdLbucIC/YTFByOJI9o7sIdwE4PZG41+89LDyF+oJewq4AgmLSxYa1Rjow2zg== X-Received: by 2002:ae9:e8cf:: with SMTP id a198mr18441339qkg.460.1593015931469; Wed, 24 Jun 2020 09:25:31 -0700 (PDT) Received: from [192.168.1.46] (c-73-88-245-53.hsd1.tn.comcast.net. [73.88.245.53]) by smtp.gmail.com with ESMTPSA id f22sm4508170qko.89.2020.06.24.09.25.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2020 09:25:31 -0700 (PDT) Subject: Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes To: Lee Jones References: <20200622151054.GW954398@dell> <037c0fd2-df35-5981-7ef2-c6199841650d@gmail.com> <20200622191133.GY954398@dell> <20200623064723.GZ954398@dell> <83f2be78-1548-fa2b-199a-2391b2eceb47@gmail.com> <20200623195905.GB954398@dell> <6684101d-1013-2964-c247-394f9b12a194@gmail.com> <20200624074631.GE954398@dell> <20200624161435.GI954398@dell> From: Frank Rowand Message-ID: <53200e52-bc53-1351-dc90-b775c29f8456@gmail.com> Date: Wed, 24 Jun 2020 11:25:29 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200624161435.GI954398@dell> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, gregkh@linuxfoundation.org, broonie@kernel.org, michael@walle.cc, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, andriy.shevchenko@linux.intel.com, robin.murphy@arm.com, linus.walleij@linaro.org, linux@roeck-us.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-06-24 11:14, Lee Jones wrote: > On Wed, 24 Jun 2020, Frank Rowand wrote: > >> On 2020-06-24 02:46, Lee Jones wrote: >>> On Tue, 23 Jun 2020, Frank Rowand wrote: >>> >>>> On 2020-06-23 14:59, Lee Jones wrote: >> >> < big snip > >> >> Thanks for the replies in the above portion. > > NP. > >>>>>> But yes or no to my solution #2 (with some slight changes to >>>>>> make it better (more gracious handling of the detected error) as >>>>>> discussed elsewhere in the email thread)? >>>>> >>>>> Please see "[0]" above! >>>>> >>>>> AFAICT your solution #2 involves bombing out *all* devices if there is >>>>> a duplicate compatible with no 'reg' property value. This is a) >>>>> over-kill and b) not an error, as I mentioned: >>>> >>>> As I mentioned above, I set you up to have this misunderstanding by >>>> a mistake in one of my earlier emails. So now that I have pointed >>>> out what I meant here by "more gracious handling of the detected >>>> error", what do you think of my amended solution #2? >>> >>> Explained above, but the LT;DR is that it's not correct. >> >> I don't agree with you, I think my solution is better. Even if I >> prefer my solution, I find your solution to be good enough. > > I still don't see how it could work, but please feel free to submit a > subsequent patch and we can discuss it on its own merits. > >> So I am dropping my specific objection to returning -EAGAIN from >> mfd_match_of_node_to_dev() when the node has previously been >> allocated to a device. > > Great. Thanks for taking an interest. > > Does this mean I can apply your Reviewed-by? > No, please do not. I don't want to give the patch that strong of an endorsement. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel