* [PATCH] usb: at91-udc: fix irq and iomem resource retrieval
@ 2014-01-23 14:41 Jean-Jacques Hiblot
2014-01-23 15:10 ` Nicolas Ferre
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jean-Jacques Hiblot @ 2014-01-23 14:41 UTC (permalink / raw)
To: linux-arm-kernel
When using dt resources retrieval (interrupts and reg properties) there is
no predefined order for these resources in the platform dev resource
table. Also don't expect the number of resource to be always 2.
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
---
drivers/usb/gadget/at91_udc.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index 4cc4fd6..dfd2943 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/drivers/usb/gadget/at91_udc.c
@@ -1710,16 +1710,6 @@ static int at91udc_probe(struct platform_device *pdev)
return -ENODEV;
}
- if (pdev->num_resources != 2) {
- DBG("invalid num_resources\n");
- return -ENODEV;
- }
- if ((pdev->resource[0].flags != IORESOURCE_MEM)
- || (pdev->resource[1].flags != IORESOURCE_IRQ)) {
- DBG("invalid resource type\n");
- return -ENODEV;
- }
-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return -ENXIO;
--
1.8.5.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] usb: at91-udc: fix irq and iomem resource retrieval
2014-01-23 14:41 [PATCH] usb: at91-udc: fix irq and iomem resource retrieval Jean-Jacques Hiblot
@ 2014-01-23 15:10 ` Nicolas Ferre
2014-01-28 10:05 ` boris brezillon
2014-02-12 13:03 ` [PATCH RESEND] " Nicolas Ferre
2014-03-12 16:30 ` Nicolas Ferre
2 siblings, 1 reply; 8+ messages in thread
From: Nicolas Ferre @ 2014-01-23 15:10 UTC (permalink / raw)
To: linux-arm-kernel
On 23/01/2014 15:41, Jean-Jacques Hiblot :
> When using dt resources retrieval (interrupts and reg properties) there is
> no predefined order for these resources in the platform dev resource
> table. Also don't expect the number of resource to be always 2.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Yes, indeed.
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Maybe we can also add a "stable" tag to it. Looking at the history of
this file, I think that we can add a pretty old stable limit... But as
it only makes sense with DT, I would advice something like this, for the
3.4-ish timeframe:
Cc: stable <stable@vger.kernel.org> # 3.4
Bye,
> ---
> drivers/usb/gadget/at91_udc.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
> index 4cc4fd6..dfd2943 100644
> --- a/drivers/usb/gadget/at91_udc.c
> +++ b/drivers/usb/gadget/at91_udc.c
> @@ -1710,16 +1710,6 @@ static int at91udc_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - if (pdev->num_resources != 2) {
> - DBG("invalid num_resources\n");
> - return -ENODEV;
> - }
> - if ((pdev->resource[0].flags != IORESOURCE_MEM)
> - || (pdev->resource[1].flags != IORESOURCE_IRQ)) {
> - DBG("invalid resource type\n");
> - return -ENODEV;
> - }
> -
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res)
> return -ENXIO;
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] usb: at91-udc: fix irq and iomem resource retrieval
2014-01-23 15:10 ` Nicolas Ferre
@ 2014-01-28 10:05 ` boris brezillon
0 siblings, 0 replies; 8+ messages in thread
From: boris brezillon @ 2014-01-28 10:05 UTC (permalink / raw)
To: linux-arm-kernel
On 23/01/2014 16:10, Nicolas Ferre wrote:
> On 23/01/2014 15:41, Jean-Jacques Hiblot :
>> When using dt resources retrieval (interrupts and reg properties) there is
>> no predefined order for these resources in the platform dev resource
>> table. Also don't expect the number of resource to be always 2.
>>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Acked-by: Boris BREZILLON <b.brezillon@overkiz.com>
> Yes, indeed.
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> Maybe we can also add a "stable" tag to it. Looking at the history of
> this file, I think that we can add a pretty old stable limit... But as
> it only makes sense with DT, I would advice something like this, for the
> 3.4-ish timeframe:
>
> Cc: stable <stable@vger.kernel.org> # 3.4
>
> Bye,
>
>> ---
>> drivers/usb/gadget/at91_udc.c | 10 ----------
>> 1 file changed, 10 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
>> index 4cc4fd6..dfd2943 100644
>> --- a/drivers/usb/gadget/at91_udc.c
>> +++ b/drivers/usb/gadget/at91_udc.c
>> @@ -1710,16 +1710,6 @@ static int at91udc_probe(struct platform_device *pdev)
>> return -ENODEV;
>> }
>>
>> - if (pdev->num_resources != 2) {
>> - DBG("invalid num_resources\n");
>> - return -ENODEV;
>> - }
>> - if ((pdev->resource[0].flags != IORESOURCE_MEM)
>> - || (pdev->resource[1].flags != IORESOURCE_IRQ)) {
>> - DBG("invalid resource type\n");
>> - return -ENODEV;
>> - }
>> -
>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> if (!res)
>> return -ENXIO;
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval
2014-01-23 14:41 [PATCH] usb: at91-udc: fix irq and iomem resource retrieval Jean-Jacques Hiblot
2014-01-23 15:10 ` Nicolas Ferre
@ 2014-02-12 13:03 ` Nicolas Ferre
2014-03-12 14:57 ` Nicolas Ferre
2014-03-12 16:30 ` Nicolas Ferre
2 siblings, 1 reply; 8+ messages in thread
From: Nicolas Ferre @ 2014-02-12 13:03 UTC (permalink / raw)
To: linux-arm-kernel
From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
When using dt resources retrieval (interrupts and reg properties) there is
no predefined order for these resources in the platform dev resource
table. Also don't expect the number of resource to be always 2.
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Acked-by: Boris BREZILLON <b.brezillon@overkiz.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: stable <stable@vger.kernel.org> # 3.4
---
drivers/usb/gadget/at91_udc.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index cea8c20a1425..1926925a52a9 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/drivers/usb/gadget/at91_udc.c
@@ -1709,16 +1709,6 @@ static int at91udc_probe(struct platform_device *pdev)
return -ENODEV;
}
- if (pdev->num_resources != 2) {
- DBG("invalid num_resources\n");
- return -ENODEV;
- }
- if ((pdev->resource[0].flags != IORESOURCE_MEM)
- || (pdev->resource[1].flags != IORESOURCE_IRQ)) {
- DBG("invalid resource type\n");
- return -ENODEV;
- }
-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return -ENXIO;
--
1.8.2.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval
2014-02-12 13:03 ` [PATCH RESEND] " Nicolas Ferre
@ 2014-03-12 14:57 ` Nicolas Ferre
2014-03-12 15:31 ` Greg Kroah-Hartman
0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Ferre @ 2014-03-12 14:57 UTC (permalink / raw)
To: linux-arm-kernel
On 12/02/2014 14:03, Nicolas Ferre :
> From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
>
> When using dt resources retrieval (interrupts and reg properties) there is
> no predefined order for these resources in the platform dev resource
> table. Also don't expect the number of resource to be always 2.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> Acked-by: Boris BREZILLON <b.brezillon@overkiz.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: stable <stable@vger.kernel.org> # 3.4
Gentle ping, after having resent the patch itself.
> ---
> drivers/usb/gadget/at91_udc.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
> index cea8c20a1425..1926925a52a9 100644
> --- a/drivers/usb/gadget/at91_udc.c
> +++ b/drivers/usb/gadget/at91_udc.c
> @@ -1709,16 +1709,6 @@ static int at91udc_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - if (pdev->num_resources != 2) {
> - DBG("invalid num_resources\n");
> - return -ENODEV;
> - }
> - if ((pdev->resource[0].flags != IORESOURCE_MEM)
> - || (pdev->resource[1].flags != IORESOURCE_IRQ)) {
> - DBG("invalid resource type\n");
> - return -ENODEV;
> - }
> -
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res)
> return -ENXIO;
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval
2014-03-12 14:57 ` Nicolas Ferre
@ 2014-03-12 15:31 ` Greg Kroah-Hartman
2014-03-12 16:28 ` Nicolas Ferre
0 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2014-03-12 15:31 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 12, 2014 at 03:57:48PM +0100, Nicolas Ferre wrote:
> On 12/02/2014 14:03, Nicolas Ferre :
> > From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> >
> > When using dt resources retrieval (interrupts and reg properties) there is
> > no predefined order for these resources in the platform dev resource
> > table. Also don't expect the number of resource to be always 2.
> >
> > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> > Acked-by: Boris BREZILLON <b.brezillon@overkiz.com>
> > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > Cc: stable <stable@vger.kernel.org> # 3.4
>
> Gentle ping, after having resent the patch itself.
It helps if you send it to the correct maintainer, remember,
scripts/get_maintainer.pl is your friend...
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval
2014-03-12 15:31 ` Greg Kroah-Hartman
@ 2014-03-12 16:28 ` Nicolas Ferre
0 siblings, 0 replies; 8+ messages in thread
From: Nicolas Ferre @ 2014-03-12 16:28 UTC (permalink / raw)
To: linux-arm-kernel
On 12/03/2014 16:31, Greg Kroah-Hartman :
> On Wed, Mar 12, 2014 at 03:57:48PM +0100, Nicolas Ferre wrote:
>> On 12/02/2014 14:03, Nicolas Ferre :
>>> From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
>>>
>>> When using dt resources retrieval (interrupts and reg properties) there is
>>> no predefined order for these resources in the platform dev resource
>>> table. Also don't expect the number of resource to be always 2.
>>>
>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
>>> Acked-by: Boris BREZILLON <b.brezillon@overkiz.com>
>>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>>> Cc: stable <stable@vger.kernel.org> # 3.4
>>
>> Gentle ping, after having resent the patch itself.
>
> It helps if you send it to the correct maintainer, remember,
> scripts/get_maintainer.pl is your friend...
Indeed. I add Felipe to my next attempt: sorry for the (repeated) noise.
Bye,
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval
2014-01-23 14:41 [PATCH] usb: at91-udc: fix irq and iomem resource retrieval Jean-Jacques Hiblot
2014-01-23 15:10 ` Nicolas Ferre
2014-02-12 13:03 ` [PATCH RESEND] " Nicolas Ferre
@ 2014-03-12 16:30 ` Nicolas Ferre
2 siblings, 0 replies; 8+ messages in thread
From: Nicolas Ferre @ 2014-03-12 16:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
When using dt resources retrieval (interrupts and reg properties) there is
no predefined order for these resources in the platform dev resource
table. Also don't expect the number of resource to be always 2.
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Acked-by: Boris BREZILLON <b.brezillon@overkiz.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: stable <stable@vger.kernel.org> # 3.4
---
drivers/usb/gadget/at91_udc.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index cea8c20a1425..1926925a52a9 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/drivers/usb/gadget/at91_udc.c
@@ -1709,16 +1709,6 @@ static int at91udc_probe(struct platform_device *pdev)
return -ENODEV;
}
- if (pdev->num_resources != 2) {
- DBG("invalid num_resources\n");
- return -ENODEV;
- }
- if ((pdev->resource[0].flags != IORESOURCE_MEM)
- || (pdev->resource[1].flags != IORESOURCE_IRQ)) {
- DBG("invalid resource type\n");
- return -ENODEV;
- }
-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return -ENXIO;
--
1.8.2.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-03-12 16:30 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-23 14:41 [PATCH] usb: at91-udc: fix irq and iomem resource retrieval Jean-Jacques Hiblot
2014-01-23 15:10 ` Nicolas Ferre
2014-01-28 10:05 ` boris brezillon
2014-02-12 13:03 ` [PATCH RESEND] " Nicolas Ferre
2014-03-12 14:57 ` Nicolas Ferre
2014-03-12 15:31 ` Greg Kroah-Hartman
2014-03-12 16:28 ` Nicolas Ferre
2014-03-12 16:30 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).