From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM
Date: Thu, 13 Mar 2014 05:59:09 +0800 [thread overview]
Message-ID: <5320D8AD.5000308@ti.com> (raw)
In-Reply-To: <1394660600-3771-1-git-send-email-nm@ti.com>
On Thursday 13 March 2014 05:43 AM, Nishanth Menon wrote:
> Just like IS_PM34XX_ERRATUM, IS_PM44XX_ERRATUM is valid only if
> CONFIG_PM is enabled, else, disabling CONFIG_PM results in build
> failure complaining about the following:
> arch/arm/mach-omap2/built-in.o: In function `omap4_boot_secondary':
> :(.text+0x8a70): undefined reference to `pm44xx_errata'
>
Not entirely accurate since CPU hotplug doesn't depend on CONFIG_PM
> Fixes: c962184 (ARM: OMAP4: PM: add errata support)
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> Patch based on: v3.14-rc6
> Reported originally with a randconfig defconfig: http://slexy.org/view/s21U7eF4k1
>
But without the PM sleep code, hotplug won't work either.
SO I think its ok assumption in this particular case
> arch/arm/mach-omap2/pm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index 7bdd22a..d4d0fce 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -103,7 +103,7 @@ static inline void enable_omap3630_toggle_l2_on_restore(void) { }
>
> #define PM_OMAP4_ROM_SMP_BOOT_ERRATUM_GICD (1 << 0)
>
> -#if defined(CONFIG_ARCH_OMAP4)
> +#if defined(CONFIG_PM) && defined(CONFIG_ARCH_OMAP4)
> extern u16 pm44xx_errata;
> #define IS_PM44XX_ERRATUM(id) (pm44xx_errata & (id))
> #else
>
next prev parent reply other threads:[~2014-03-12 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 21:43 [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM Nishanth Menon
2014-03-12 21:59 ` Santosh Shilimkar [this message]
2014-03-12 22:07 ` Nishanth Menon
2014-03-12 22:11 ` Santosh Shilimkar
2014-03-13 18:27 ` Kevin Hilman
2014-03-13 20:36 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5320D8AD.5000308@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).