* [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM
@ 2014-03-12 21:43 Nishanth Menon
2014-03-12 21:59 ` Santosh Shilimkar
2014-03-13 18:27 ` Kevin Hilman
0 siblings, 2 replies; 6+ messages in thread
From: Nishanth Menon @ 2014-03-12 21:43 UTC (permalink / raw)
To: linux-arm-kernel
Just like IS_PM34XX_ERRATUM, IS_PM44XX_ERRATUM is valid only if
CONFIG_PM is enabled, else, disabling CONFIG_PM results in build
failure complaining about the following:
arch/arm/mach-omap2/built-in.o: In function `omap4_boot_secondary':
:(.text+0x8a70): undefined reference to `pm44xx_errata'
Fixes: c962184 (ARM: OMAP4: PM: add errata support)
Reported-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Patch based on: v3.14-rc6
Reported originally with a randconfig defconfig: http://slexy.org/view/s21U7eF4k1
arch/arm/mach-omap2/pm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
index 7bdd22a..d4d0fce 100644
--- a/arch/arm/mach-omap2/pm.h
+++ b/arch/arm/mach-omap2/pm.h
@@ -103,7 +103,7 @@ static inline void enable_omap3630_toggle_l2_on_restore(void) { }
#define PM_OMAP4_ROM_SMP_BOOT_ERRATUM_GICD (1 << 0)
-#if defined(CONFIG_ARCH_OMAP4)
+#if defined(CONFIG_PM) && defined(CONFIG_ARCH_OMAP4)
extern u16 pm44xx_errata;
#define IS_PM44XX_ERRATUM(id) (pm44xx_errata & (id))
#else
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM
2014-03-12 21:43 [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM Nishanth Menon
@ 2014-03-12 21:59 ` Santosh Shilimkar
2014-03-12 22:07 ` Nishanth Menon
2014-03-13 18:27 ` Kevin Hilman
1 sibling, 1 reply; 6+ messages in thread
From: Santosh Shilimkar @ 2014-03-12 21:59 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 13 March 2014 05:43 AM, Nishanth Menon wrote:
> Just like IS_PM34XX_ERRATUM, IS_PM44XX_ERRATUM is valid only if
> CONFIG_PM is enabled, else, disabling CONFIG_PM results in build
> failure complaining about the following:
> arch/arm/mach-omap2/built-in.o: In function `omap4_boot_secondary':
> :(.text+0x8a70): undefined reference to `pm44xx_errata'
>
Not entirely accurate since CPU hotplug doesn't depend on CONFIG_PM
> Fixes: c962184 (ARM: OMAP4: PM: add errata support)
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> Patch based on: v3.14-rc6
> Reported originally with a randconfig defconfig: http://slexy.org/view/s21U7eF4k1
>
But without the PM sleep code, hotplug won't work either.
SO I think its ok assumption in this particular case
> arch/arm/mach-omap2/pm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index 7bdd22a..d4d0fce 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -103,7 +103,7 @@ static inline void enable_omap3630_toggle_l2_on_restore(void) { }
>
> #define PM_OMAP4_ROM_SMP_BOOT_ERRATUM_GICD (1 << 0)
>
> -#if defined(CONFIG_ARCH_OMAP4)
> +#if defined(CONFIG_PM) && defined(CONFIG_ARCH_OMAP4)
> extern u16 pm44xx_errata;
> #define IS_PM44XX_ERRATUM(id) (pm44xx_errata & (id))
> #else
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM
2014-03-12 21:59 ` Santosh Shilimkar
@ 2014-03-12 22:07 ` Nishanth Menon
2014-03-12 22:11 ` Santosh Shilimkar
0 siblings, 1 reply; 6+ messages in thread
From: Nishanth Menon @ 2014-03-12 22:07 UTC (permalink / raw)
To: linux-arm-kernel
On 03/12/2014 04:59 PM, Santosh Shilimkar wrote:
> On Thursday 13 March 2014 05:43 AM, Nishanth Menon wrote:
>> Just like IS_PM34XX_ERRATUM, IS_PM44XX_ERRATUM is valid only if
>> CONFIG_PM is enabled, else, disabling CONFIG_PM results in build
>> failure complaining about the following:
>> arch/arm/mach-omap2/built-in.o: In function `omap4_boot_secondary':
>> :(.text+0x8a70): undefined reference to `pm44xx_errata'
>>
> Not entirely accurate since CPU hotplug doesn't depend on CONFIG_PM
Just reporting the build error here.
>
>> Fixes: c962184 (ARM: OMAP4: PM: add errata support)
>> Reported-by: Tony Lindgren <tony@atomide.com>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>>
>> Patch based on: v3.14-rc6
>> Reported originally with a randconfig defconfig: http://slexy.org/view/s21U7eF4k1
>>
> But without the PM sleep code, hotplug won't work either.
yep - agreed,
> SO I think its ok assumption in this particular case
Can I take that as an Ack here? or would you suggest any improvements?
>
>> arch/arm/mach-omap2/pm.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
>> index 7bdd22a..d4d0fce 100644
>> --- a/arch/arm/mach-omap2/pm.h
>> +++ b/arch/arm/mach-omap2/pm.h
>> @@ -103,7 +103,7 @@ static inline void enable_omap3630_toggle_l2_on_restore(void) { }
>>
>> #define PM_OMAP4_ROM_SMP_BOOT_ERRATUM_GICD (1 << 0)
>>
>> -#if defined(CONFIG_ARCH_OMAP4)
>> +#if defined(CONFIG_PM) && defined(CONFIG_ARCH_OMAP4)
>> extern u16 pm44xx_errata;
>> #define IS_PM44XX_ERRATUM(id) (pm44xx_errata & (id))
>> #else
>>
>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM
2014-03-12 22:07 ` Nishanth Menon
@ 2014-03-12 22:11 ` Santosh Shilimkar
0 siblings, 0 replies; 6+ messages in thread
From: Santosh Shilimkar @ 2014-03-12 22:11 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 13 March 2014 06:07 AM, Nishanth Menon wrote:
> On 03/12/2014 04:59 PM, Santosh Shilimkar wrote:
>> On Thursday 13 March 2014 05:43 AM, Nishanth Menon wrote:
>>> Just like IS_PM34XX_ERRATUM, IS_PM44XX_ERRATUM is valid only if
>>> CONFIG_PM is enabled, else, disabling CONFIG_PM results in build
>>> failure complaining about the following:
>>> arch/arm/mach-omap2/built-in.o: In function `omap4_boot_secondary':
>>> :(.text+0x8a70): undefined reference to `pm44xx_errata'
>>>
>> Not entirely accurate since CPU hotplug doesn't depend on CONFIG_PM
>
> Just reporting the build error here.
>>
>>> Fixes: c962184 (ARM: OMAP4: PM: add errata support)
>>> Reported-by: Tony Lindgren <tony@atomide.com>
>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>> ---
>>>
>>> Patch based on: v3.14-rc6
>>> Reported originally with a randconfig defconfig: http://slexy.org/view/s21U7eF4k1
>>>
>> But without the PM sleep code, hotplug won't work either.
> yep - agreed,
>> SO I think its ok assumption in this particular case
>
> Can I take that as an Ack here? or would you suggest any improvements?
>
yep. Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.ocm>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM
2014-03-12 21:43 [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM Nishanth Menon
2014-03-12 21:59 ` Santosh Shilimkar
@ 2014-03-13 18:27 ` Kevin Hilman
2014-03-13 20:36 ` Tony Lindgren
1 sibling, 1 reply; 6+ messages in thread
From: Kevin Hilman @ 2014-03-13 18:27 UTC (permalink / raw)
To: linux-arm-kernel
Nishanth Menon <nm@ti.com> writes:
> Just like IS_PM34XX_ERRATUM, IS_PM44XX_ERRATUM is valid only if
> CONFIG_PM is enabled, else, disabling CONFIG_PM results in build
> failure complaining about the following:
> arch/arm/mach-omap2/built-in.o: In function `omap4_boot_secondary':
> :(.text+0x8a70): undefined reference to `pm44xx_errata'
>
> Fixes: c962184 (ARM: OMAP4: PM: add errata support)
> Reported-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
Acked-by: Kevin Hilman <khilman@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM
2014-03-13 18:27 ` Kevin Hilman
@ 2014-03-13 20:36 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2014-03-13 20:36 UTC (permalink / raw)
To: linux-arm-kernel
* Kevin Hilman <khilman@linaro.org> [140313 11:30]:
> Nishanth Menon <nm@ti.com> writes:
>
> > Just like IS_PM34XX_ERRATUM, IS_PM44XX_ERRATUM is valid only if
> > CONFIG_PM is enabled, else, disabling CONFIG_PM results in build
> > failure complaining about the following:
> > arch/arm/mach-omap2/built-in.o: In function `omap4_boot_secondary':
> > :(.text+0x8a70): undefined reference to `pm44xx_errata'
> >
> > Fixes: c962184 (ARM: OMAP4: PM: add errata support)
> > Reported-by: Tony Lindgren <tony@atomide.com>
> > Signed-off-by: Nishanth Menon <nm@ti.com>
>
> Acked-by: Kevin Hilman <khilman@linaro.org>
Applying this into omap-for-v3.15/fixes thanks.
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-13 20:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-12 21:43 [PATCH] ARM: OMAP4: Fix definition of IS_PM44XX_ERRATUM Nishanth Menon
2014-03-12 21:59 ` Santosh Shilimkar
2014-03-12 22:07 ` Nishanth Menon
2014-03-12 22:11 ` Santosh Shilimkar
2014-03-13 18:27 ` Kevin Hilman
2014-03-13 20:36 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).