From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Fri, 21 Mar 2014 07:39:41 +0900 Subject: [PATCH 48/62] ARM: s3c64xx: select power domains only when used In-Reply-To: <532B3010.80101@samsung.com> References: <1395257399-359545-1-git-send-email-arnd@arndb.de> <1395257399-359545-49-git-send-email-arnd@arndb.de> <01f801cf43f0$62e7bc80$28b73580$@samsung.com> <532B3010.80101@samsung.com> Message-ID: <532B6E2D.7000207@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/21/14 03:14, Kukjin Kim wrote: > On 03/20/14 12:56, Kukjin Kim wrote: >> Arnd Bergmann wrote: >>> >>> The power domain code is only available when CONFIG_PM >>> is enabled, so we must not select that unconditionally for >>> s3c64xx. Changing it to 'select PM_GENERIC_DOMAINS if PM' >>> mirrors what we do on other platforms, and fixes a possible >>> randconfig build bug. >>> >>> Signed-off-by: Arnd Bergmann >>> Cc: Tomasz Figa >>> Cc: Kukjin Kim >> >> Acked-by: Kukjin Kim >> > > Arnd, > > Please drop this patch in your tree because there is a fix before this > and it fixes SAMSUNG_WAKEMASK dependency together for S3C64XX. > > [PATCH v2 5/6] ARM: s3c64xx: Fix incorrect selection of PM-related > symbols > > Note, I'll take above into 2nd fixes for v3.15 in samsung tree. > > If any problems, please kindly let me know. > Oops, Arnd sorry. Please go ahead with my ack on this because the fix, "[PATCH v2 5/6] ARM: s3c64xx: Fix incorrect selection of PM-related symbols" makes a build error...I'll look at the problem. Thanks, Kukjin >> >>> Cc: Ben Dooks >>> --- >>> arch/arm/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >>> index 4721007..6ffcadd 100644 >>> --- a/arch/arm/Kconfig >>> +++ b/arch/arm/Kconfig >>> @@ -764,7 +764,7 @@ config ARCH_S3C64XX >>> select HAVE_TCM >>> select NO_IOPORT >>> select PLAT_SAMSUNG >>> - select PM_GENERIC_DOMAINS >>> + select PM_GENERIC_DOMAINS if PM >>> select S3C_DEV_NAND >>> select S3C_GPIO_TRACK >>> select SAMSUNG_ATAGS >>> -- >>> 1.8.3.2