From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/9] PCI: host: rcar: Add Renesas R-Car PCIe driver
Date: Fri, 21 Mar 2014 15:06:44 +0100 [thread overview]
Message-ID: <532C4774.20803@codethink.co.uk> (raw)
In-Reply-To: <OF038A7DC3.59E6288A-ON80257CA2.004AF404-80257CA2.004CDD76@eu.necel.com>
On 21/03/14 14:59, Phil.Edworthy at renesas.com wrote:
> Hi Arnd,
>
> Thanks for the review.
>
>
>>> +static int __init pcie_init(void)
>>> +{
>>> + return platform_driver_probe(&rcar_pcie_driver, rcar_pcie_probe);
>>> +}
>>> +subsys_initcall(pcie_init);
>>
>> Why so early?
> Good catch, copied from another PCIe driver!
I think you can change it to use module_driver() instead of the
init_call.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-03-21 14:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 10:32 [PATCH v4 0/9] R-Car Gen2 PCIe host driver Phil Edworthy
2014-03-21 10:32 ` [PATCH v4 1/9] PCI: host: rcar: Add Renesas R-Car PCIe driver Phil Edworthy
2014-03-21 11:04 ` Arnd Bergmann
2014-03-21 13:59 ` Phil.Edworthy at renesas.com
2014-03-21 14:06 ` Ben Dooks [this message]
2014-03-21 15:07 ` Arnd Bergmann
2014-03-23 10:05 ` Geert Uytterhoeven
2014-03-21 10:32 ` [PATCH v4 2/9] PCI: host: rcar: Add MSI support Phil Edworthy
2014-03-21 11:17 ` Lucas Stach
2014-03-21 14:15 ` Phil.Edworthy at renesas.com
2014-03-21 14:26 ` Lucas Stach
2014-03-21 14:34 ` Phil.Edworthy at renesas.com
2014-03-21 10:32 ` [PATCH v4 3/9] ARM: shmobile: r8a7790: Add PCIe clock device tree nodes Phil Edworthy
2014-03-21 10:32 ` [PATCH v4 4/9] ARM: shmobile: r8a7791: " Phil Edworthy
2014-03-21 10:32 ` [PATCH v4 5/9] dt-bindings: pci: rcar pcie device tree bindings Phil Edworthy
2014-03-21 11:23 ` Lucas Stach
2014-03-21 14:18 ` Phil.Edworthy at renesas.com
2014-03-21 14:30 ` Lucas Stach
2014-03-21 15:02 ` Phil.Edworthy at renesas.com
[not found] ` <OFC7DD5DAC.D378B300-ON80257CA2.0051ECEE-80257CA2.00529F98@LocalDomain>
2014-03-24 12:04 ` Phil.Edworthy at renesas.com
2014-03-24 12:15 ` Ben Dooks
2014-03-24 12:25 ` Phil.Edworthy at renesas.com
[not found] ` <OF85DD7B1D.716DE42D-ON80257CA5.00443087-80257CA5.004447DB@LocalDomain>
2014-03-24 12:46 ` Phil.Edworthy at renesas.com
2014-03-24 12:53 ` Lucas Stach
2014-03-21 10:32 ` [PATCH v4 6/9] ARM: shmobile: Add PCIe device tree nodes for R8A7790 Phil Edworthy
2014-03-21 15:29 ` Sergei Shtylyov
2014-03-21 14:53 ` Phil.Edworthy at renesas.com
2014-03-21 14:57 ` Arnd Bergmann
2014-03-21 16:40 ` Jason Gunthorpe
2014-03-21 16:42 ` Sergei Shtylyov
2014-03-21 16:31 ` Phil.Edworthy at renesas.com
2014-03-21 16:49 ` Jason Gunthorpe
2014-03-23 10:13 ` Geert Uytterhoeven
2014-03-21 15:32 ` Sergei Shtylyov
2014-03-21 15:06 ` Phil.Edworthy at renesas.com
2014-03-21 10:32 ` [PATCH v4 7/9] ARM: shmobile: Add PCIe device tree nodes for R8A7791 Koelsch board Phil Edworthy
2014-03-21 10:32 ` [PATCH v4 8/9] ARM: koelsch: Add PCIe to defconfig Phil Edworthy
2014-03-21 10:32 ` [PATCH v4 9/9] ARM: koelsch: Add HAVE_ARM_ARCH_TIMER " Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532C4774.20803@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).