From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] clk: berlin: add berlin clocks DT bindings documentation
Date: Fri, 21 Mar 2014 22:31:09 +0100 [thread overview]
Message-ID: <532CAF9D.3020303@gmail.com> (raw)
In-Reply-To: <1395432521-11055-3-git-send-email-alexandre.belloni@free-electrons.com>
On 03/21/2014 09:08 PM, Alexandre Belloni wrote:
> Document the device tree bindings for the PLLs found on the Marvell Berlin SoCs.
>
> Cc: devicetree at vger.kernel.org
You forgot to add Mark Rutland's Reviewed-by. He didn't mentioned it
explicitly but his "Otherwise this looks fine to me" on v1, is as good
as a Reviewed-by. But, no need to resend, I'll fix it up.
Also, everything above the '---' will be part of your commit log. While
the Signed-off-by and Reviewed-by should be in there, Cc's really don't
need to.
You can add another '---' to separate commit message and some stuff
you want to have early in you email with:
Blablabla commit message.
Signed-off-by: ...
Reviewed-by: ...
---
Changelog:
- blabla
Cc: cc-me-recipient
...
---
.../devicetree/bindings/clock/berlin-clock.txt | 29
++++++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644
Documentation/devicetree/bindings/clock/berlin-clock.txt
diff --git a/Documentation/devicetree/bindings/clock/berlin-clock.txt
b/Documentation/devicetree/bindings/clock/berlin-clock.txt
...
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> .../devicetree/bindings/clock/berlin-clock.txt | 29 ++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/berlin-clock.txt
>
> diff --git a/Documentation/devicetree/bindings/clock/berlin-clock.txt b/Documentation/devicetree/bindings/clock/berlin-clock.txt
> new file mode 100644
> index 000000000000..49b7860bffb8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/berlin-clock.txt
> @@ -0,0 +1,29 @@
> +Device Tree Clock bindings for Marvell Berlin clocks
> +
> +This binding uses the common clock binding[1].
> +
> +[1] Documentation/devicetree/bindings/clock/clock-bindings.txt
> +
> +Required properties:
> +- compatible: shall be one of the following:
> + "marvell,berlin2-pll",
> + "marvell,berlin2q-pll":
> + CPU PLL and System PLL
> +- reg: Address and length of the clock register set.
> +- #clock-cells: from common clock binding; shall be set to 0.
> +- clocks: from common clock binding
> +
> +smclk: sysmgr-clock {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>;
> +};
> +
> +cpupll: cpupll at ea003c {
> + compatible = "marvell,berlin2-pll";
> + clocks = <&smclk>;
> + #clock-cells = <0>;
> + reg = <0xea003c 0x8>;
> +};
> +
> +
>
next prev parent reply other threads:[~2014-03-21 21:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 20:08 [PATCH v2 0/5] berlin: initial support for the clocks Alexandre Belloni
2014-03-21 20:08 ` [PATCH v2 1/5] clk: berlin: add support for berlin plls Alexandre Belloni
2014-03-21 21:22 ` Sebastian Hesselbarth
2014-03-21 22:22 ` Alexandre Belloni
2014-03-21 22:35 ` Sebastian Hesselbarth
2014-03-21 20:08 ` [PATCH v2 2/5] clk: berlin: add berlin clocks DT bindings documentation Alexandre Belloni
2014-03-21 21:31 ` Sebastian Hesselbarth [this message]
2014-03-21 22:20 ` Alexandre Belloni
2014-03-21 20:08 ` [PATCH v2 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q Alexandre Belloni
2014-03-21 21:33 ` Sebastian Hesselbarth
2014-03-21 20:08 ` [PATCH v2 4/5] ARM: berlin/dt: add cpupll and syspll support to BG2CD Alexandre Belloni
2014-03-21 21:35 ` Sebastian Hesselbarth
2014-03-21 22:08 ` Alexandre Belloni
2014-03-21 20:08 ` [PATCH v2 5/5] ARM: berlin/dt: add cpupll and syspll support to BG2 Alexandre Belloni
2014-03-21 21:36 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532CAF9D.3020303@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).