[PATCH v2 0/4] arm: mxs: dts: small fixes for I2SE's duckbills

[PATCH v2 0/4] arm: mxs: dts: small fixes for I2SE's duckbills

[Michael Heimpold]

This series fixes two issues with the DT file: first, it frees up
some GPIOs which are mis-used by MMC interface, and second, it
fixes the GPIO used to reset the ethernet phy.

While at it, use symbolic names for LED definitions.

Changes in v2:
 - add missing patch for imx28.dtsi to include gpio.h


Michael Heimpold (4):
  arm: mxs: dt: imx28-duckbill: fix mmc settings
  arm: mxs: dt: imx28-duckbill: fix phy reset gpio
  arm: mxs: dt: imx28: include gpio.h to allow use of symbolic names
  arm: mxs: dt: imx28-duckbill: use symbolic names from gpio.h

 arch/arm/boot/dts/imx28-duckbill.dts |   12 ++++++------
 arch/arm/boot/dts/imx28.dtsi         |    1 +
 2 files changed, 7 insertions(+), 6 deletions(-)

-- 
1.7.10.4

[PATCH v2 1/4] arm: mxs: dt: imx28-duckbill: fix mmc settings

[Michael Heimpold]

I2SE's duckbills are only equipped with a micro SD card slot and
thus only provide a 4-bit interface.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>
---
Changes since v1:
- none

 arch/arm/boot/dts/imx28-duckbill.dts |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx28-duckbill.dts b/arch/arm/boot/dts/imx28-duckbill.dts
index 5f326c1..a697870 100644
--- a/arch/arm/boot/dts/imx28-duckbill.dts
+++ b/arch/arm/boot/dts/imx28-duckbill.dts
@@ -25,9 +25,9 @@
 			ssp0: ssp at 80010000 {
 				compatible = "fsl,imx28-mmc";
 				pinctrl-names = "default";
-				pinctrl-0 = <&mmc0_8bit_pins_a
+				pinctrl-0 = <&mmc0_4bit_pins_a
 					&mmc0_cd_cfg &mmc0_sck_cfg>;
-				bus-width = <8>;
+				bus-width = <4>;
 				vmmc-supply = <&reg_3p3v>;
 				status = "okay";
 			};
-- 
1.7.10.4

[PATCH v2 2/4] arm: mxs: dt: imx28-duckbill: fix phy reset gpio

[Michael Heimpold]

Fix a copy & paste error: on duckbills the GPIO used for resetting
the ethernet phy differs from FSL's MX28EVK board.

Reported-by: Stefan Wahren <info@lategoodbye.de>
Signed-off-by: Michael Heimpold <mhei@heimpold.de>
---
Changes since v1:
- none

 arch/arm/boot/dts/imx28-duckbill.dts |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx28-duckbill.dts b/arch/arm/boot/dts/imx28-duckbill.dts
index a697870..91c1a9a 100644
--- a/arch/arm/boot/dts/imx28-duckbill.dts
+++ b/arch/arm/boot/dts/imx28-duckbill.dts
@@ -39,7 +39,7 @@
 				hog_pins_a: hog at 0 {
 					reg = <0>;
 					fsl,pinmux-ids = <
-						MX28_PAD_ENET0_RX_CLK__GPIO_4_13 /* PHY Reset */
+						MX28_PAD_SSP0_DATA7__GPIO_2_7 /* PHY Reset */
 					>;
 					fsl,drive-strength = <MXS_DRIVE_4mA>;
 					fsl,voltage = <MXS_VOLTAGE_HIGH>;
@@ -82,7 +82,7 @@
 			pinctrl-names = "default";
 			pinctrl-0 = <&mac0_pins_a>;
 			phy-supply = <&reg_3p3v>;
-			phy-reset-gpios = <&gpio4 13 0>;
+			phy-reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>;
 			phy-reset-duration = <100>;
 			status = "okay";
 		};
-- 
1.7.10.4

[PATCH v2 3/4] arm: mxs: dt: imx28: include gpio.h to allow use of symbolic names

[Michael Heimpold]

Signed-off-by: Michael Heimpold <mhei@heimpold.de>
---
Changes since v1:
- new patch

 arch/arm/boot/dts/imx28.dtsi |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 90a5795..a95cc53 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -9,6 +9,7 @@
  * http://www.gnu.org/copyleft/gpl.html
  */
 
+#include <dt-bindings/gpio/gpio.h>
 #include "skeleton.dtsi"
 #include "imx28-pinfunc.h"
 
-- 
1.7.10.4

[PATCH v2 4/4] arm: mxs: dt: imx28-duckbill: use symbolic names from gpio.h

[Michael Heimpold]

Use GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW instead of 0 and 1.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>
---
Changes since v1:
- none

 arch/arm/boot/dts/imx28-duckbill.dts |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx28-duckbill.dts b/arch/arm/boot/dts/imx28-duckbill.dts
index 91c1a9a..ce1a7ef 100644
--- a/arch/arm/boot/dts/imx28-duckbill.dts
+++ b/arch/arm/boot/dts/imx28-duckbill.dts
@@ -110,12 +110,12 @@
 
 		status {
 			label = "duckbill:green:status";
-			gpios = <&gpio3 5 0>;
+			gpios = <&gpio3 5 GPIO_ACTIVE_HIGH>;
 		};
 
 		failure {
 			label = "duckbill:red:status";
-			gpios = <&gpio3 4 0>;
+			gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
 		};
 	};
 };
-- 
1.7.10.4

[PATCH v2 0/4] arm: mxs: dts: small fixes for I2SE's duckbills

[Stefan Wahren]

Am 27.03.2014 23:51, schrieb Michael Heimpold:
> This series fixes two issues with the DT file: first, it frees up
> some GPIOs which are mis-used by MMC interface, and second, it
> fixes the GPIO used to reset the ethernet phy.
>
> While at it, use symbolic names for LED definitions.
>
> Changes in v2:
>   - add missing patch for imx28.dtsi to include gpio.h
>
>
> Michael Heimpold (4):
>    arm: mxs: dt: imx28-duckbill: fix mmc settings
>    arm: mxs: dt: imx28-duckbill: fix phy reset gpio
>    arm: mxs: dt: imx28: include gpio.h to allow use of symbolic names
>    arm: mxs: dt: imx28-duckbill: use symbolic names from gpio.h
>
>   arch/arm/boot/dts/imx28-duckbill.dts |   12 ++++++------
>   arch/arm/boot/dts/imx28.dtsi         |    1 +
>   2 files changed, 7 insertions(+), 6 deletions(-)
>

They all look good to me.

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>

BR Stefan Wahren

[PATCH v2 0/4] arm: mxs: dts: small fixes for I2SE's duckbills

[Shawn Guo]

On Thu, Mar 27, 2014 at 11:51:26PM +0100, Michael Heimpold wrote:
> This series fixes two issues with the DT file: first, it frees up
> some GPIOs which are mis-used by MMC interface, and second, it
> fixes the GPIO used to reset the ethernet phy.
> 
> While at it, use symbolic names for LED definitions.
> 
> Changes in v2:
>  - add missing patch for imx28.dtsi to include gpio.h
> 
> 
> Michael Heimpold (4):
>   arm: mxs: dt: imx28-duckbill: fix mmc settings
>   arm: mxs: dt: imx28-duckbill: fix phy reset gpio
>   arm: mxs: dt: imx28: include gpio.h to allow use of symbolic names
>   arm: mxs: dt: imx28-duckbill: use symbolic names from gpio.h

Changed patch prefix as below and applied all patches.

  ARM: dts: imx28-duckbill: fix mmc settings
  ARM: dts: imx28-duckbill: fix phy reset gpio
  ARM: dts: imx28: include gpio.h to allow use of symbolic names
  ARM: dts: imx28-duckbill: use symbolic names from gpio.h

Shawn

[PATCH v2 0/4] arm: mxs: dts: small fixes for I2SE's duckbills

[Shawn Guo]

On Wed, Apr 02, 2014 at 04:52:26PM +0800, Shawn Guo wrote:
> On Thu, Mar 27, 2014 at 11:51:26PM +0100, Michael Heimpold wrote:
> > This series fixes two issues with the DT file: first, it frees up
> > some GPIOs which are mis-used by MMC interface, and second, it
> > fixes the GPIO used to reset the ethernet phy.
> > 
> > While at it, use symbolic names for LED definitions.
> > 
> > Changes in v2:
> >  - add missing patch for imx28.dtsi to include gpio.h
> > 
> > 
> > Michael Heimpold (4):
> >   arm: mxs: dt: imx28-duckbill: fix mmc settings
> >   arm: mxs: dt: imx28-duckbill: fix phy reset gpio
> >   arm: mxs: dt: imx28: include gpio.h to allow use of symbolic names
> >   arm: mxs: dt: imx28-duckbill: use symbolic names from gpio.h
> 
> Changed patch prefix as below and applied all patches.
> 
>   ARM: dts: imx28-duckbill: fix mmc settings
>   ARM: dts: imx28-duckbill: fix phy reset gpio
>   ARM: dts: imx28: include gpio.h to allow use of symbolic names
>   ARM: dts: imx28-duckbill: use symbolic names from gpio.h

Forgot mentioning that the patches should be reordered as below, since
the patch fixing phy reset gpio already uses GPIO symbolic name.

   ARM: dts: imx28-duckbill: fix mmc settings
   ARM: dts: imx28: include gpio.h to allow use of symbolic names
   ARM: dts: imx28-duckbill: fix phy reset gpio
   ARM: dts: imx28-duckbill: use symbolic names from gpio.h

Shawn