From: Andrew Lunn <andrew@lunn.ch>
To: Caleb James DeLisle <cjd@cjdns.fr>
Cc: Christian Marangi <ansuelsmth@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Daniel Golle <daniel@makrotopia.org>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next v2 5/6] net: phy: mediatek: add calibration logic for AN7581
Date: Tue, 25 Aug 2026 21:41:34 +0200 [thread overview]
Message-ID: <53415965-602e-4638-98db-43e0b899f837@lunn.ch> (raw)
In-Reply-To: <d18d84e4-af86-405e-aadd-bd9a8dfe8742@cjdns.fr>
> > + ret = devm_phy_package_join(&phydev->mdio.dev, phydev, 0,
>
>
> This should use AIROHA_DEFAULT_PORT0_ADDR as the base_addr to avoid a
> collision if another PHY driver also uses devm_phy_package_join().
Please trim the text when replying, otherwise comments get lost.
Andrew
next prev parent reply other threads:[~2026-08-25 19:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 19:08 [PATCH net-next v2 0/6] net: phy: mediatek: calibration for AN7581/3 Christian Marangi
2026-07-24 19:08 ` [PATCH net-next v2 1/6] net: phy: mediatek: export __mtk_tr_write Christian Marangi
2026-07-24 19:08 ` [PATCH net-next v2 2/6] net: phy: mediatek: move MTK GE SoC registers define to dedicated header Christian Marangi
2026-07-24 19:08 ` [PATCH net-next v2 3/6] net: phy: mediatek: generalize cal_cycle function for GE SoC Christian Marangi
2026-07-24 19:08 ` [PATCH net-next v2 4/6] net: phy: mediatek: split Airoha code to dedicated source Christian Marangi
2026-07-24 19:08 ` [PATCH net-next v2 5/6] net: phy: mediatek: add calibration logic for AN7581 Christian Marangi
2026-07-30 20:10 ` Jakub Kicinski
2026-08-22 16:24 ` Caleb James DeLisle
2026-08-25 18:15 ` Caleb James DeLisle
2026-08-25 19:41 ` Andrew Lunn [this message]
2026-07-24 19:08 ` [PATCH net-next v2 6/6] net: phy: mediatek: add calibration logic for AN7583 Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53415965-602e-4638-98db-43e0b899f837@lunn.ch \
--to=andrew@lunn.ch \
--cc=SkyLake.Huang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=cjd@cjdns.fr \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox