From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Peter Robinson" <pbrobinson@gmail.com>,
"Maíra Canal" <mcanal@igalia.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Stefan Wahren <wahrenst@gmx.net>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel-dev@igalia.com
Subject: Re: [PATCH v2] arm64: dts: broadcom: bcm2712: Add V3D device node
Date: Fri, 16 Jan 2026 14:02:50 +0100 [thread overview]
Message-ID: <5341693c-12fd-428f-b742-ff24d3c1a0cc@kernel.org> (raw)
In-Reply-To: <CALeDE9PGzTe4LXnDJcyhh_ietWkrf8Sp7xX=X6pZvdCWLx2huw@mail.gmail.com>
On 16/01/2026 11:56, Peter Robinson wrote:
>>>> +
>>>> +&v3d {
>>>> + clocks = <&firmware_clocks 5>;
>>>
>>> Looking at the upstream DT [1] I think this also needs a clock-names entry.
>>
>> Differently from the `hvs` node [1] you sent (which specifies clock-
>> names), the `v3d` binding [2] doesn't have a clock-names property.
>> Therefore, it is not needed.
>
> There's a name in the clk driver [1] so maybe the bindings should be updated?
That's a clock provider, not consumer.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/bcm/clk-raspberrypi.c#n26
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-16 13:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 12:04 [PATCH v2] arm64: dts: broadcom: bcm2712: Add V3D device node Maíra Canal
2026-01-16 3:53 ` Peter Robinson
2026-01-16 10:15 ` Maíra Canal
2026-01-16 10:56 ` Peter Robinson
2026-01-16 12:41 ` Maíra Canal
2026-01-16 13:02 ` Krzysztof Kozlowski [this message]
2026-01-16 19:09 ` Stefan Wahren
2026-01-28 10:39 ` Maíra Canal
2026-01-28 22:27 ` Florian Fainelli
2026-01-29 0:00 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5341693c-12fd-428f-b742-ff24d3c1a0cc@kernel.org \
--to=krzk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=florian.fainelli@broadcom.com \
--cc=kernel-dev@igalia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mcanal@igalia.com \
--cc=pbrobinson@gmail.com \
--cc=robh@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox