From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CD8AC83F10 for ; Thu, 31 Aug 2023 06:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xleKrqNQYZoWREdteFs+/ZUfLcZyrvCiRLrO0+O6BtE=; b=cTZGVu3bA5UGH5 EjlyyRJqNVdCUgj7OF66cMLUC55dZl1Oo69Zq3+Mm2acODg6kmwHvrj+unSO2SegYELKsbzT+v7ko vA+h4JIu7UrT46uuwGz9peY/C+3RKk0M2Jca2oEMNpRRvgJ7ndITwri5QctY6R50bZ2cqg9/6+JiN m0YwQIBY6dGE/4syj/CQ6hUtv/EkL4B0vAIB+48/J8UUSx60f6LAynXDMQzeq4dG7SqHWE8/rlcwW oueAnOOpX+cUCROtqdCIwCvMmYBhUh43ptK8Y+/wpB70nFRJeWQ6H+L7H5q7jFrT18yzt1VPKGetd wcBT5tzIPv2AwhV130wA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbbIN-00ElKN-0j; Thu, 31 Aug 2023 06:36:47 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbbIG-00ElK4-0B for linux-arm-kernel@lists.infradead.org; Thu, 31 Aug 2023 06:36:41 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1bf57366ccdso11253775ad.1 for ; Wed, 30 Aug 2023 23:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693463799; x=1694068599; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/kyvkupLew9Yd6VCA9XQC4cAMSTlDnrwdbWSR056bSo=; b=KKK7Mj0S7Xsy7+Hv91xj1rOXI1N8IwTOocXtSA4ekEK0ERf4ZFmwRF5BgO2MZ0Cbis wGbhOPlUO812DTSPEYk6eXNadTrO4UtXwENXD8ALV6ymnW/vy15tKRbGBeUitfsxjYUR 7aGDez2Gf9p1I6z84H6BlDXdjElh9THZz2PTEIy7dVyf4yqEkbEiaFqn4lu6991Hlhev CU98bDTgkMJxGVSoEB0fGm87a9O2gOxiuf37HAG33YviEgyaiu5qoSR5ts4BjLW3T50Y 4t+sGCaDeATK3VxlNvPLD4KlPFjIBCcKXwafelWeVkNjjCzd1JdBUowoxH7aDTyWQl58 EV1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693463799; x=1694068599; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/kyvkupLew9Yd6VCA9XQC4cAMSTlDnrwdbWSR056bSo=; b=EuV7+AP8bbwAZFQpM4l3gIHitk3GoE4AxTpSuzMP7x8SjTkjpee4o2AyNNTIfgxeXB RaKAq8ToAhLQ+gyqMVPF9CWKYam6yxOfCxA90jaCFnb3klJyMXEQAskX6oTDRNTBBjtR ip5uUgIUlsI3aIuNBeL5GYvM+YViAvx2o5huyjyOnRDriJG01K8SnajUO+5PqIkmnjBh /QJn9mvGV3asrK98MiLfzndFhwunN+E4BUZrwGrVqpUdhwt2wcVWpTOGBeHOD6CizcW4 UipbUdvf0viIyAo+wyeENbk2AuuQBZ5PFJMwmR1kdnKSQz1QJZWhjWXECzfPRBisRWWl KhMg== X-Gm-Message-State: AOJu0YyFdsjiZFSLn8Cs5R0AnwTXu4XB1PonmPWaCtQdHNa5adUKPKui 7zWqs7TAlZmfvMvRT7/s6Qo= X-Google-Smtp-Source: AGHT+IF/QcbvfmvsqDftpHC9Yc9k9k1Flp6pBjturyK95MU7VeorHlVJlOFx/tBxCTurN4IFl3DROQ== X-Received: by 2002:a17:903:18a:b0:1b7:ca9c:4f5c with SMTP id z10-20020a170903018a00b001b7ca9c4f5cmr2147913plg.28.1693463799233; Wed, 30 Aug 2023 23:36:39 -0700 (PDT) Received: from [10.10.14.80] (1-34-21-66.hinet-ip.hinet.net. [1.34.21.66]) by smtp.gmail.com with ESMTPSA id l19-20020a170902eb1300b001bf00317a49sm552633plb.104.2023.08.30.23.36.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Aug 2023 23:36:38 -0700 (PDT) Message-ID: <5347163b-c225-d805-d851-fe28e6b57c56@gmail.com> Date: Thu, 31 Aug 2023 14:34:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5 1/2] ARM: dts: aspeed: Minerva: Add Facebook Minerva (AST2600) BMC Content-Language: en-US To: Krzysztof Kozlowski , patrick@stwcx.xyz, Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Arnd Bergmann , Olof Johansson , soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: cosmo.chou@quantatw.com, potin.lai@quantatw.com, daniel-hsu@quantatw.com References: <20230831055030.3958798-1-peteryin.openbmc@gmail.com> <20230831055030.3958798-2-peteryin.openbmc@gmail.com> <4cbe662d-cd20-ceef-e3e4-6608029f94b7@linaro.org> From: PeterYin In-Reply-To: <4cbe662d-cd20-ceef-e3e4-6608029f94b7@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230830_233640_101919_DEE21254 X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/31/23 14:20, Krzysztof Kozlowski wrote: > On 31/08/2023 07:50, Peter Yin wrote: >> Add linux device tree entry related to >> Minerva specific devices connected to BMC SoC. >> >> Signed-off-by: Peter Yin >> --- >> arch/arm/boot/dts/Makefile | 1 + >> .../boot/dts/aspeed-bmc-facebook-minerva.dts | 377 ++++++++++++++++++ >> 2 files changed, 378 insertions(+) >> create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-minerva.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 9e1d7bf3cff6..edb0b2105333 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -1604,6 +1604,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ >> aspeed-bmc-facebook-wedge400.dtb \ >> aspeed-bmc-facebook-yamp.dtb \ >> aspeed-bmc-facebook-yosemitev2.dtb \ >> + aspeed-bmc-facebook-minerva.dtb \ > Third or fourth time: that's not a correct order. This is a nit, but > since you keep ignoring it, I don't believe any other feedback was > applied. Why you did not respond to my comments but just ignored them? Sorry, I don't notice this is different file. > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel