linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 10/20] ARM: exynos: cpuidle: Move clock setup to pm.c
Date: Fri, 11 Apr 2014 10:55:41 +0200	[thread overview]
Message-ID: <5347AE0D.5060008@linaro.org> (raw)
In-Reply-To: <5347AC8A.7090006@samsung.com>

On 04/11/2014 10:49 AM, Tomasz Figa wrote:
> On 11.04.2014 10:30, Daniel Lezcano wrote:
>> On 04/10/2014 05:34 PM, Tomasz Figa wrote:
>>> On 10.04.2014 16:23, Daniel Lezcano wrote:
>>>> On 04/10/2014 03:57 PM, Tomasz Figa wrote:
>>>>> Hi Daniel,
>>>>>
>>>>> On 10.04.2014 11:55, Daniel Lezcano wrote:
>>>>>> One more step is moving the clock ratio setting at idle time in pm.c
>>>>>>
>>>>>> The macro names have been changed to be consistent with the other
>>>>>> macros
>>>>>> name in the file.
>>>>>>
>>>>>> Note, the clock divider was working only when cpuidle was enabled
>>>>>> because it
>>>>>> was in its init routine. With this change, the clock divider is
>>>>>> set in
>>>>>> the pm's
>>>>>> init routine, so it will also operate when the cpuidle driver is not
>>>>>> set, which
>>>>>> is good.
>>>>>>
>>>>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>>>>> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
>>>>>> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>>>>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>>>>>> ---
>>>>>>   arch/arm/mach-exynos/cpuidle.c  |   54
>>>>>> ---------------------------------------
>>>>>>   arch/arm/mach-exynos/pm.c       |   35 +++++++++++++++++++++++++
>>>>>>   arch/arm/mach-exynos/regs-pmu.h |   19 ++++++++++++++
>>>>>>   3 files changed, 54 insertions(+), 54 deletions(-)
>>>>>
>>>>> Sorry that I didn't mention that before, but now I recall that there
>>>>> was
>>>>> already a similar patch moving this code to Exynos5250 clock driver,
>>>>> which is the best place for setup of any CMU registers and a step
>>>>> towards removing one more static IO mapping.
>>>>
>>>> Yes, Bartlomiej mentioned it.
>>>>
>>>> Is it possible to merge this mentioned patch or to give a pointer to it
>>>> so I can integrate it into the patchset ?
>>>
>>> http://marc.info/?l=linux-arm-kernel&m=138147021207626&w=2
>>>
>>> I wonder if it still applies cleanly, though...
>>
>> Ok, if I refer to the date, this patch has been lost in the limbus. So I
>> can integrate it with my patchset without conflicting with any tree.
>> Right ?
>>
>
> As I suspected, it doesn't apply onto current sources. I have attached a
> rebased version. Feel free to send it as a part of next version of your
> series.

Thanks Tomasz !



-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2014-04-11  8:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10  9:55 [PATCH V4 00/20] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 01/20] ARM: exynos: cpuidle: Prevent forward declaration Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 02/20] ARM: exynos: cpuidle: Use cpuidle_register Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 03/20] ARM: exynos: cpuidle: Change function name prefix Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 04/20] ARM: exynos: cpuidle: Encapsulate register access inside a function Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 05/20] ARM: exynos: cpuidle: Move some code inside the idle_finisher Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 06/20] ARM: exynos: cpuidle: Fix S5P_WAKEUP_STAT call Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 07/20] ARM: exynos: cpuidle: Use the cpu_pm notifier Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 08/20] ARM: exynos: cpuidle: Move scu_enable in " Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 09/20] ARM: exynos: cpuidle: Remove ifdef for scu_enable Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 10/20] ARM: exynos: cpuidle: Move clock setup to pm.c Daniel Lezcano
2014-04-10 13:57   ` Tomasz Figa
2014-04-10 14:23     ` Daniel Lezcano
2014-04-10 15:34       ` Tomasz Figa
2014-04-11  8:30         ` Daniel Lezcano
2014-04-11  8:49           ` Tomasz Figa
2014-04-11  8:55             ` Daniel Lezcano [this message]
2014-04-10  9:55 ` [PATCH V4 11/20] ARM: exynos: cpuidle: Pass wakeup mask parameter to function Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 12/20] ARM: exynos: cpuidle: Encapsulate boot vector code into a function Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 13/20] ARM: exynos: cpuidle: Disable cpuidle for 5440 Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 14/20] ARM: exynos: cpuidle: Encapsulate the AFTR code into a function Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 15/20] ARM: exynos: cpuidle: Move the AFTR state function into pm.c Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 16/20] ARM: exynos: cpuidle: Move the power sequence call in the cpu_pm notifier Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 17/20] ARM: exynos: cpuidle: Move S5P_CHECK_SLEEP into pm.c Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 18/20] ARM: exynos: cpuidle: Pass the AFTR callback to the platform_data Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 19/20] ARM: exynos: cpuidle: Cleanup all unneeded headers from cpuidle.c Daniel Lezcano
2014-04-10  9:55 ` [PATCH V4 20/20] ARM: exynos: cpuidle: Move the driver to drivers/cpuidle directory Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5347AE0D.5060008@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).