From mboxrd@z Thu Jan  1 00:00:00 1970
From: joelf@ti.com (Joel Fernandes)
Date: Fri, 11 Apr 2014 14:57:48 -0500
Subject: [PATCH v2 10/14] dma: edma: Simplify direction configuration
 in edma_config_pset()
In-Reply-To: <53478E0E.8040709@ti.com>
References: <1396357575-30585-1-git-send-email-peter.ujfalusi@ti.com>
 <1396357575-30585-11-git-send-email-peter.ujfalusi@ti.com>
 <53471DC5.4090001@ti.com> <53478E0E.8040709@ti.com>
Message-ID: <5348493C.8040408@ti.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 04/11/2014 01:39 AM, Peter Ujfalusi wrote:
> On 04/11/2014 01:40 AM, Joel Fernandes wrote:
>> On 04/01/2014 08:06 AM, Peter Ujfalusi wrote:
>>> We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the
>>> check for the direction has been already done in the function calling
>>> edma_config_pset().
>>> The error reporting is redundant and also the "else if ()" can be removed.
>>>
>>
>> NAK. Please don't do this. I have been working on MEM_TO_MEM support as
>> well so leave it as it is for future.
> 
> Sure. It is still valid to say that the error else {} will never going to
> happen since you have the same check in the calling function and they already
> filtered the non implemented direction.
> 

That's true. Though the patch removes the else if which would mean more
work later ;)

> I'll leave this out from v3.

Thanks.

Regards,
-Joel