From: lokeshvutla@ti.com (Lokesh Vutla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: AM33xx: hwmod: Add INIT_NO_IDLE flag for debugss hwmod
Date: Mon, 14 Apr 2014 13:59:26 +0530 [thread overview]
Message-ID: <534B9C66.9020007@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1404111807210.14347@utopia.booyaka.com>
Hi Paul,
On Friday 11 April 2014 11:39 PM, Paul Walmsley wrote:
> On Fri, 11 Apr 2014, Paul Walmsley wrote:
>
>> On Wed, 9 Apr 2014, Lokesh Vutla wrote:
>>
>>> During boot, when hwmod tries to cut clocks for debugss it always
>>> gets stuck in transition state and throws the following warning:
>>>
>>> [ 0.139581] omap_hwmod: debugss: _wait_target_disable failed
>>>
>>> As per the information provided by folks, clocks to debugss cannot be cut.
>>> So adding HWMOD_INIT_NO_IDLE flag to debugss hwmod.
>>>
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>
>> Thanks, queued for v3.15-rc.
>
> Hmmm. On second thought, this doesn't look like the right fix. Could
> you please comment on the issues raised here:
>
> https://patchwork.kernel.org/patch/2212111/
Yes, I initially created a driver for enabling and disabling clocks for DEBUGSS.
But I always see that DEBUGSS is always stuck in transition whenever clocks are cut
to DEBUGSS.
During boot also when hwmod tries to cut clocks the following warning comes:
[ 0.139581] omap_hwmod: debugss: _wait_target_disable failed.
As confirmed by the hardware team that this is a bug in silicon that clocks cannot
be cut to DEBUGSS.
So I am just adding HWMOD_INIT_NO_IDLE flag to debugss hwmod.
I have also tested suspend-resume with $subject patch with TI internal tree.
Please let me know if I am not clear.
Thanks and regards,
Lokesh
>
> Looks to me like there should be at least one device driver, either for
> the entire DEBUGSS, or for the individual IP blocks inside the DEBUGSS.
>
> Dropping this patch for now.
>
>
> - Paul
>
next prev parent reply other threads:[~2014-04-14 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 5:47 [PATCH] ARM: AM33xx: hwmod: Add INIT_NO_IDLE flag for debugss hwmod Lokesh Vutla
2014-04-11 18:00 ` Paul Walmsley
2014-04-11 18:09 ` Paul Walmsley
2014-04-14 8:29 ` Lokesh Vutla [this message]
2014-05-07 23:55 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534B9C66.9020007@ti.com \
--to=lokeshvutla@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).