linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 25/29] ARM: orion5x: remove unneeded code for edmini_v2
Date: Mon, 14 Apr 2014 13:18:04 +0200	[thread overview]
Message-ID: <534BC3EC.5060202@gmail.com> (raw)
In-Reply-To: <1397400006-4315-26-git-send-email-thomas.petazzoni@free-electrons.com>

On 04/13/2014 04:40 PM, Thomas Petazzoni wrote:
> The edmini_v2 platform is now fully converted to the Device Tree, so
> we can get rid of the old style board-file and the related Kconfig
> option.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

I love code removal ;)

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>

> ---
>   arch/arm/mach-orion5x/Kconfig           |  8 -----
>   arch/arm/mach-orion5x/Makefile          |  1 -
>   arch/arm/mach-orion5x/board-dt.c        |  3 --
>   arch/arm/mach-orion5x/common.h          |  7 -----
>   arch/arm/mach-orion5x/edmini_v2-setup.c | 53 ---------------------------------
>   5 files changed, 72 deletions(-)
>   delete mode 100644 arch/arm/mach-orion5x/edmini_v2-setup.c
>
> diff --git a/arch/arm/mach-orion5x/Kconfig b/arch/arm/mach-orion5x/Kconfig
> index 3c69a3c..928f4cb 100644
> --- a/arch/arm/mach-orion5x/Kconfig
> +++ b/arch/arm/mach-orion5x/Kconfig
> @@ -107,14 +107,6 @@ config MACH_MV2120
>   	  Say 'Y' here if you want your kernel to support the
>   	  HP Media Vault mv2120 or mv5100.
>
> -config MACH_EDMINI_V2_DT
> -	bool "LaCie Ethernet Disk mini V2 (Flattened Device Tree)"
> -	select I2C_BOARDINFO
> -	select ARCH_ORION5X_DT
> -	help
> -	  Say 'Y' here if you want your kernel to support the
> -	  LaCie Ethernet Disk mini V2 (Flattened Device Tree).
> -
>   config MACH_D2NET
>   	bool "LaCie d2 Network"
>   	select I2C_BOARDINFO
> diff --git a/arch/arm/mach-orion5x/Makefile b/arch/arm/mach-orion5x/Makefile
> index 45da805..e8fdbdd 100644
> --- a/arch/arm/mach-orion5x/Makefile
> +++ b/arch/arm/mach-orion5x/Makefile
> @@ -23,4 +23,3 @@ obj-$(CONFIG_MACH_RD88F6183AP_GE)	+= rd88f6183ap-ge-setup.o
>   obj-$(CONFIG_MACH_LINKSTATION_LSCHL)	+= ls-chl-setup.o
>
>   obj-$(CONFIG_ARCH_ORION5X_DT)		+= board-dt.o
> -obj-$(CONFIG_MACH_EDMINI_V2_DT)	+= edmini_v2-setup.o
> diff --git a/arch/arm/mach-orion5x/board-dt.c b/arch/arm/mach-orion5x/board-dt.c
> index 38b54f1..c621f37 100644
> --- a/arch/arm/mach-orion5x/board-dt.c
> +++ b/arch/arm/mach-orion5x/board-dt.c
> @@ -66,9 +66,6 @@ static void __init orion5x_dt_init(void)
>   		cpu_idle_poll_ctrl(true);
>   	}
>
> -	if (of_machine_is_compatible("lacie,ethernet-disk-mini-v2"))
> -		edmini_v2_init();
> -
>   	of_platform_populate(NULL, of_default_bus_match_table,
>   			     orion5x_auxdata_lookup, NULL);
>   }
> diff --git a/arch/arm/mach-orion5x/common.h b/arch/arm/mach-orion5x/common.h
> index 7548db2..4470e31 100644
> --- a/arch/arm/mach-orion5x/common.h
> +++ b/arch/arm/mach-orion5x/common.h
> @@ -64,13 +64,6 @@ int orion5x_pci_sys_setup(int nr, struct pci_sys_data *sys);
>   struct pci_bus *orion5x_pci_sys_scan_bus(int nr, struct pci_sys_data *sys);
>   int orion5x_pci_map_irq(const struct pci_dev *dev, u8 slot, u8 pin);
>
> -/* board init functions for boards not fully converted to fdt */
> -#ifdef CONFIG_MACH_EDMINI_V2_DT
> -void edmini_v2_init(void);
> -#else
> -static inline void edmini_v2_init(void) {};
> -#endif
> -
>   struct meminfo;
>   struct tag;
>   extern void __init tag_fixup_mem32(struct tag *, char **, struct meminfo *);
> diff --git a/arch/arm/mach-orion5x/edmini_v2-setup.c b/arch/arm/mach-orion5x/edmini_v2-setup.c
> deleted file mode 100644
> index 6bef2d5..0000000
> --- a/arch/arm/mach-orion5x/edmini_v2-setup.c
> +++ /dev/null
> @@ -1,53 +0,0 @@
> -/*
> - * arch/arm/mach-orion5x/edmini_v2-setup.c
> - *
> - * LaCie Ethernet Disk mini V2 Setup
> - *
> - * Copyright (C) 2008 Christopher Moore <moore@free.fr>
> - * Copyright (C) 2008 Albert Aribaud <albert.aribaud@free.fr>
> - *
> - * This file is licensed under the terms of the GNU General Public
> - * License version 2. This program is licensed "as is" without any
> - * warranty of any kind, whether express or implied.
> - */
> -
> -/*
> - * TODO: add Orion USB device port init when kernel.org support is added.
> - * TODO: add flash write support: see below.
> - * TODO: add power-off support.
> - * TODO: add I2C EEPROM support.
> - */
> -
> -#include <linux/kernel.h>
> -#include <linux/init.h>
> -#include <linux/platform_device.h>
> -#include <linux/pci.h>
> -#include <linux/irq.h>
> -#include <linux/mbus.h>
> -#include <linux/mtd/physmap.h>
> -#include <linux/leds.h>
> -#include <linux/gpio_keys.h>
> -#include <linux/input.h>
> -#include <linux/i2c.h>
> -#include <linux/ata_platform.h>
> -#include <linux/gpio.h>
> -#include <asm/mach-types.h>
> -#include <asm/mach/arch.h>
> -#include <asm/mach/pci.h>
> -#include <mach/orion5x.h>
> -#include "common.h"
> -#include "mpp.h"
> -
> -/*****************************************************************************
> - * EDMINI_V2 Info
> - ****************************************************************************/
> -
> -/*****************************************************************************
> - * General Setup
> - ****************************************************************************/
> -
> -void __init edmini_v2_init(void)
> -{
> -	pr_notice("edmini_v2: USB device port, flash write and power-off "
> -		  "are not yet supported.\n");
> -}
>

  reply	other threads:[~2014-04-14 11:18 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-13 14:39 [PATCH 00/29] ARM: orion5x: big step towards DT conversion Thomas Petazzoni
2014-04-13 14:39 ` [PATCH 01/29] ARM: orion5x: fix target ID for crypto SRAM window Thomas Petazzoni
2014-04-14  8:59   ` Sebastian Hesselbarth
2014-04-17  4:55   ` Jason Cooper
2014-04-13 14:39 ` [PATCH 02/29] pinctrl: mvebu: new driver for Orion platforms Thomas Petazzoni
2014-04-14  9:15   ` Sebastian Hesselbarth
2014-04-19 17:28     ` Thomas Petazzoni
2014-04-20 10:04       ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 03/29] clk: mvebu: add Orion5x clock driver Thomas Petazzoni
2014-04-14  9:27   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 04/29] memory: mvebu-devbus: fix the conversion of the bus width Thomas Petazzoni
2014-04-14  9:30   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 05/29] memory: mvebu-devbus: use ARMADA_ prefix in defines Thomas Petazzoni
2014-04-14  9:33   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 06/29] memory: mvebu-devbus: split functions Thomas Petazzoni
2014-04-14  9:36   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 07/29] memory: mvebu-devbus: add Orion5x support Thomas Petazzoni
2014-04-14  9:41   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 08/29] ARM: orion5x: move interrupt controller node into ocp Thomas Petazzoni
2014-04-14  9:42   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 09/29] ARM: orion5x: switch to preprocessor includes in DT Thomas Petazzoni
2014-04-14  9:43   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 10/29] ARM: orion5x: use existing dt-bindings include for Device Tree files Thomas Petazzoni
2014-04-14  9:43   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 11/29] ARM: orion5x: convert DT to use the mvebu-mbus driver Thomas Petazzoni
2014-04-14 10:33   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 12/29] ARM: orion5x: add interrupt for Ethernet in Device Tree Thomas Petazzoni
2014-04-14 10:33   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 13/29] ARM: orion5x: switch to use the clock driver for DT platforms Thomas Petazzoni
2014-04-14 10:35   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 14/29] ARM: orion: switch to a per-platform handle_irq() function Thomas Petazzoni
2014-04-14 10:40   ` Sebastian Hesselbarth
2014-04-19  7:27     ` Thomas Petazzoni
2014-04-19  9:09       ` Sebastian Hesselbarth
2014-04-19 12:04         ` Thomas Petazzoni
2014-04-19 16:16           ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 15/29] ARM: orion5x: switch to DT interrupts and timer Thomas Petazzoni
2014-04-14 10:43   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 16/29] ARM: orion5x: enable pinctrl driver at SoC level Thomas Petazzoni
2014-04-14 10:44   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 17/29] ARM: orion5x: update I2C description " Thomas Petazzoni
2014-04-14 10:45   ` Sebastian Hesselbarth
2014-04-19  7:38     ` Thomas Petazzoni
2014-04-19  9:10       ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 18/29] ARM: orion5x: add Device Bus " Thomas Petazzoni
2014-04-14 10:47   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 19/29] ARM: orion5x: add standard pinctrl configs for sata0 and sata1 Thomas Petazzoni
2014-04-14 10:48   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 20/29] ARM: orion5x: convert edmini_v2 to DT pinctrl Thomas Petazzoni
2014-04-13 15:26   ` Andrew Lunn
2014-04-13 15:41     ` Thomas Petazzoni
2014-04-14 10:51   ` Sebastian Hesselbarth
2014-04-14 11:23     ` Thomas Petazzoni
2014-04-14 11:27       ` Sebastian Hesselbarth
2014-04-14 12:06         ` Andrew Lunn
2014-04-14 12:24           ` Ezequiel Garcia
2014-04-14 12:28           ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 21/29] ARM: orion5x: use DT to describe I2C devices on edmini_v2 Thomas Petazzoni
2014-04-13 15:28   ` Andrew Lunn
2014-04-13 15:43     ` Thomas Petazzoni
2014-04-13 15:53       ` Andrew Lunn
2014-04-14 10:53   ` Sebastian Hesselbarth
2014-04-13 14:39 ` [PATCH 22/29] ARM: orion5x: use DT to describe EHCI " Thomas Petazzoni
2014-04-14 10:57   ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 23/29] ARM: orion5x: use DT to describe NOR " Thomas Petazzoni
2014-04-13 15:31   ` Andrew Lunn
2014-04-13 15:45     ` Thomas Petazzoni
2014-04-14  2:10       ` Chris Moore
2014-04-14  2:19         ` Chris Moore
2014-04-14 18:44       ` Andrew Lunn
2014-04-14 11:14   ` Sebastian Hesselbarth
2014-04-14 11:24     ` Thomas Petazzoni
2014-04-14 11:28       ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 24/29] ARM: orion5x: keep TODO list in edmini_v2 DT Thomas Petazzoni
2014-04-14 11:17   ` Sebastian Hesselbarth
2014-04-15  2:59     ` Chris Moore
2014-04-13 14:40 ` [PATCH 25/29] ARM: orion5x: remove unneeded code for edmini_v2 Thomas Petazzoni
2014-04-14 11:18   ` Sebastian Hesselbarth [this message]
2014-04-13 14:40 ` [PATCH 26/29] ARM: orion5x: convert RD-88F5182 to Device Tree Thomas Petazzoni
2014-04-13 15:47   ` Andrew Lunn
2014-04-13 15:56     ` Thomas Petazzoni
2014-04-13 15:59       ` Andrew Lunn
2014-04-13 16:53         ` Thomas Petazzoni
2014-04-13 16:59           ` Sebastian Hesselbarth
2014-04-13 17:50       ` Arnd Bergmann
2014-04-14  8:01         ` Andrew Lunn
2014-04-14  9:08           ` Arnd Bergmann
2014-04-14 11:26   ` Sebastian Hesselbarth
2014-04-19  7:46     ` Thomas Petazzoni
2014-04-19  9:18       ` Sebastian Hesselbarth
2014-04-13 14:40 ` [PATCH 27/29] ARM: orion5x: convert d2net " Thomas Petazzoni
2014-04-13 14:40 ` [PATCH 28/29] ARM: orion: remove no longer needed DT IRQ code Thomas Petazzoni
2014-04-13 14:40 ` [PATCH 29/29] ARM: orion: remove no longer needed gpio DT code Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534BC3EC.5060202@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).