From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] pinctrl: tegra: remove fsafe from data tables
Date: Tue, 15 Apr 2014 18:00:50 +0530 [thread overview]
Message-ID: <534D267A.4030708@nvidia.com> (raw)
In-Reply-To: <1397511222-28533-2-git-send-email-swarren@wwwdotorg.org>
On Tuesday 15 April 2014 03:03 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The fsafe value in the pingroup data tables is only used to implement
> tegra_pinctrl_disable(). The only reason this function is called is when
> dynamically switching between pinmux states, i.e. when disabling the old
> state before programming the new state. It's simpler to have the new
> target state define the expected value of each pin (and all current DTs
> do that). This also gives more flexibility, since it allows individual
> boards explicit control over the "inactive" mux function for each pin,
> rather than requiring it to be an SoC-specific value. Assuming this, we
> can get rid of the fsafe value from the driver completely, thus saving
> some more space in the driver tables.
>
> While re-writing the content of tegra124_pingroups[], fix the indentation
> to use a TAB instead of spaces.
>
Looks good to me.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
next prev parent reply other threads:[~2014-04-15 12:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 21:33 [PATCH 1/4] pinctrl: tegra: remove redundant data table fields Stephen Warren
2014-04-14 21:33 ` [PATCH 3/4] pinctrl: tegra: reduce size of " Stephen Warren
2014-04-15 12:31 ` Laxman Dewangan
2014-04-22 14:53 ` Linus Walleij
2014-04-14 21:33 ` [PATCH 4/4] pinctrl: tegra: print better error messages Stephen Warren
2014-04-22 14:54 ` Linus Walleij
2014-04-15 12:28 ` [PATCH 1/4] pinctrl: tegra: remove redundant data table fields Laxman Dewangan
2014-04-15 16:30 ` Stephen Warren
[not found] ` <1397511222-28533-2-git-send-email-swarren@wwwdotorg.org>
2014-04-15 12:30 ` Laxman Dewangan [this message]
2014-04-22 14:52 ` [PATCH 2/4] pinctrl: tegra: remove fsafe from data tables Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534D267A.4030708@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).