* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY @ 2014-03-13 11:11 Grygorii Strashko 2014-03-13 13:37 ` Santosh Shilimkar 2014-03-13 15:20 ` Felipe Balbi 0 siblings, 2 replies; 11+ messages in thread From: Grygorii Strashko @ 2014-03-13 11:11 UTC (permalink / raw) To: linux-arm-kernel This fixes a regression on Keystone 2 platforms caused by patch 57303488cd37da58263e842de134dc65f7c626d5 "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds optional support of generic phy in DWC3 core. On Keystone 2 platforms the USB is not working now because CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs return -ENOSYS always. The log shows: dwc3 2690000.dwc3: failed to initialize core dwc3: probe of 2690000.dwc3 failed with error -38 Hence, fix it by making NULL a valid phy reference in Generic PHY APIs stubs in the same way as it was done by the patch 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL a valid phy reference". CC: Kishon Vijay Abraham I <kishon@ti.com> CC: Felipe Balbi <balbi@ti.com> CC: Santosh Shilimkar <santosh.shilimkar@ti.com> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- include/linux/phy/phy.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index e2f5ca9..5a9b193 100644 --- a/include/linux/phy/phy.h +++ b/include/linux/phy/phy.h @@ -204,21 +204,29 @@ static inline void phy_pm_runtime_forbid(struct phy *phy) static inline int phy_init(struct phy *phy) { + if (!phy) + return 0; return -ENOSYS; } static inline int phy_exit(struct phy *phy) { + if (!phy) + return 0; return -ENOSYS; } static inline int phy_power_on(struct phy *phy) { + if (!phy) + return 0; return -ENOSYS; } static inline int phy_power_off(struct phy *phy) { + if (!phy) + return 0; return -ENOSYS; } -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY 2014-03-13 11:11 [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY Grygorii Strashko @ 2014-03-13 13:37 ` Santosh Shilimkar 2014-03-13 13:43 ` Kishon Vijay Abraham I 2014-04-16 10:09 ` Kishon Vijay Abraham I 2014-03-13 15:20 ` Felipe Balbi 1 sibling, 2 replies; 11+ messages in thread From: Santosh Shilimkar @ 2014-03-13 13:37 UTC (permalink / raw) To: linux-arm-kernel On Thursday 13 March 2014 07:11 PM, Strashko, Grygorii wrote: > This fixes a regression on Keystone 2 platforms caused by patch > 57303488cd37da58263e842de134dc65f7c626d5 > "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds > optional support of generic phy in DWC3 core. > > On Keystone 2 platforms the USB is not working now because > CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs > return -ENOSYS always. The log shows: > dwc3 2690000.dwc3: failed to initialize core > dwc3: probe of 2690000.dwc3 failed with error -38 > > Hence, fix it by making NULL a valid phy reference in Generic PHY > APIs stubs in the same way as it was done by the patch > 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL > a valid phy reference". > > CC: Kishon Vijay Abraham I <kishon@ti.com> > CC: Felipe Balbi <balbi@ti.com> > CC: Santosh Shilimkar <santosh.shilimkar@ti.com> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- This fixes the regression seen in Linux next and patch seems reasonable to me. Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com> Felipe, Kishon, Can you guys pick this fix if you are ok by it. Thanks > include/linux/phy/phy.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index e2f5ca9..5a9b193 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -204,21 +204,29 @@ static inline void phy_pm_runtime_forbid(struct phy *phy) > > static inline int phy_init(struct phy *phy) > { > + if (!phy) > + return 0; > return -ENOSYS; > } > > static inline int phy_exit(struct phy *phy) > { > + if (!phy) > + return 0; > return -ENOSYS; > } > > static inline int phy_power_on(struct phy *phy) > { > + if (!phy) > + return 0; > return -ENOSYS; > } > > static inline int phy_power_off(struct phy *phy) > { > + if (!phy) > + return 0; > return -ENOSYS; > } > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY 2014-03-13 13:37 ` Santosh Shilimkar @ 2014-03-13 13:43 ` Kishon Vijay Abraham I 2014-03-13 13:47 ` Santosh Shilimkar 2014-04-16 10:09 ` Kishon Vijay Abraham I 1 sibling, 1 reply; 11+ messages in thread From: Kishon Vijay Abraham I @ 2014-03-13 13:43 UTC (permalink / raw) To: linux-arm-kernel Hi Santosh, On Thursday 13 March 2014 07:07 PM, Santosh Shilimkar wrote: > On Thursday 13 March 2014 07:11 PM, Strashko, Grygorii wrote: >> This fixes a regression on Keystone 2 platforms caused by patch >> 57303488cd37da58263e842de134dc65f7c626d5 >> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds >> optional support of generic phy in DWC3 core. >> >> On Keystone 2 platforms the USB is not working now because >> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs >> return -ENOSYS always. The log shows: >> dwc3 2690000.dwc3: failed to initialize core >> dwc3: probe of 2690000.dwc3 failed with error -38 >> >> Hence, fix it by making NULL a valid phy reference in Generic PHY >> APIs stubs in the same way as it was done by the patch >> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL >> a valid phy reference". >> >> CC: Kishon Vijay Abraham I <kishon@ti.com> >> CC: Felipe Balbi <balbi@ti.com> >> CC: Santosh Shilimkar <santosh.shilimkar@ti.com> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> --- > This fixes the regression seen in Linux next and patch seems > reasonable to me. > Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com> > > Felipe, Kishon, > Can you guys pick this fix if you are ok by it. Thanks I've already given a PULL request to Greg for 3.15. Is it ok to take this in -rc cycle? -Kishon > > >> include/linux/phy/phy.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >> index e2f5ca9..5a9b193 100644 >> --- a/include/linux/phy/phy.h >> +++ b/include/linux/phy/phy.h >> @@ -204,21 +204,29 @@ static inline void phy_pm_runtime_forbid(struct phy *phy) >> >> static inline int phy_init(struct phy *phy) >> { >> + if (!phy) >> + return 0; >> return -ENOSYS; >> } >> >> static inline int phy_exit(struct phy *phy) >> { >> + if (!phy) >> + return 0; >> return -ENOSYS; >> } >> >> static inline int phy_power_on(struct phy *phy) >> { >> + if (!phy) >> + return 0; >> return -ENOSYS; >> } >> >> static inline int phy_power_off(struct phy *phy) >> { >> + if (!phy) >> + return 0; >> return -ENOSYS; >> } >> >> > ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY 2014-03-13 13:43 ` Kishon Vijay Abraham I @ 2014-03-13 13:47 ` Santosh Shilimkar 0 siblings, 0 replies; 11+ messages in thread From: Santosh Shilimkar @ 2014-03-13 13:47 UTC (permalink / raw) To: linux-arm-kernel On Thursday 13 March 2014 09:43 PM, Kishon Vijay Abraham I wrote: > Hi Santosh, > > On Thursday 13 March 2014 07:07 PM, Santosh Shilimkar wrote: >> On Thursday 13 March 2014 07:11 PM, Strashko, Grygorii wrote: >>> This fixes a regression on Keystone 2 platforms caused by patch >>> 57303488cd37da58263e842de134dc65f7c626d5 >>> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds >>> optional support of generic phy in DWC3 core. >>> >>> On Keystone 2 platforms the USB is not working now because >>> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs >>> return -ENOSYS always. The log shows: >>> dwc3 2690000.dwc3: failed to initialize core >>> dwc3: probe of 2690000.dwc3 failed with error -38 >>> >>> Hence, fix it by making NULL a valid phy reference in Generic PHY >>> APIs stubs in the same way as it was done by the patch >>> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL >>> a valid phy reference". >>> >>> CC: Kishon Vijay Abraham I <kishon@ti.com> >>> CC: Felipe Balbi <balbi@ti.com> >>> CC: Santosh Shilimkar <santosh.shilimkar@ti.com> >>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >>> --- >> This fixes the regression seen in Linux next and patch seems >> reasonable to me. >> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com> >> >> Felipe, Kishon, >> Can you guys pick this fix if you are ok by it. Thanks > > I've already given a PULL request to Greg for 3.15. Is it ok to take this in -rc cycle? > Am not sure because this is breaking the existing functionality. May be you can request Greg to pull this fix as well. Regards, Santosh ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY 2014-03-13 13:37 ` Santosh Shilimkar 2014-03-13 13:43 ` Kishon Vijay Abraham I @ 2014-04-16 10:09 ` Kishon Vijay Abraham I 1 sibling, 0 replies; 11+ messages in thread From: Kishon Vijay Abraham I @ 2014-04-16 10:09 UTC (permalink / raw) To: linux-arm-kernel Hi, On Thursday 13 March 2014 07:07 PM, Santosh Shilimkar wrote: > On Thursday 13 March 2014 07:11 PM, Strashko, Grygorii wrote: >> This fixes a regression on Keystone 2 platforms caused by patch >> 57303488cd37da58263e842de134dc65f7c626d5 >> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds >> optional support of generic phy in DWC3 core. >> >> On Keystone 2 platforms the USB is not working now because >> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs >> return -ENOSYS always. The log shows: >> dwc3 2690000.dwc3: failed to initialize core >> dwc3: probe of 2690000.dwc3 failed with error -38 >> >> Hence, fix it by making NULL a valid phy reference in Generic PHY >> APIs stubs in the same way as it was done by the patch >> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL >> a valid phy reference". >> >> CC: Kishon Vijay Abraham I <kishon@ti.com> >> CC: Felipe Balbi <balbi@ti.com> >> CC: Santosh Shilimkar <santosh.shilimkar@ti.com> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> --- > This fixes the regression seen in Linux next and patch seems > reasonable to me. > Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com> > > Felipe, Kishon, > Can you guys pick this fix if you are ok by it. Thanks > > >> include/linux/phy/phy.h | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h >> index e2f5ca9..5a9b193 100644 >> --- a/include/linux/phy/phy.h >> +++ b/include/linux/phy/phy.h >> @@ -204,21 +204,29 @@ static inline void phy_pm_runtime_forbid(struct phy *phy) >> >> static inline int phy_init(struct phy *phy) >> { >> + if (!phy) >> + return 0; >> return -ENOSYS; >> } >> >> static inline int phy_exit(struct phy *phy) >> { >> + if (!phy) >> + return 0; >> return -ENOSYS; >> } >> >> static inline int phy_power_on(struct phy *phy) >> { >> + if (!phy) >> + return 0; >> return -ENOSYS; >> } >> >> static inline int phy_power_off(struct phy *phy) >> { >> + if (!phy) >> + return 0; >> return -ENOSYS; >> } Can you add these checks for other stubs in phy.h too? Thanks Kishon ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY 2014-03-13 11:11 [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY Grygorii Strashko 2014-03-13 13:37 ` Santosh Shilimkar @ 2014-03-13 15:20 ` Felipe Balbi 2014-03-13 21:44 ` Felipe Balbi 1 sibling, 1 reply; 11+ messages in thread From: Felipe Balbi @ 2014-03-13 15:20 UTC (permalink / raw) To: linux-arm-kernel On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote: > This fixes a regression on Keystone 2 platforms caused by patch > 57303488cd37da58263e842de134dc65f7c626d5 > "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds > optional support of generic phy in DWC3 core. > > On Keystone 2 platforms the USB is not working now because > CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs > return -ENOSYS always. The log shows: > dwc3 2690000.dwc3: failed to initialize core > dwc3: probe of 2690000.dwc3 failed with error -38 > > Hence, fix it by making NULL a valid phy reference in Generic PHY > APIs stubs in the same way as it was done by the patch > 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL > a valid phy reference". > > CC: Kishon Vijay Abraham I <kishon@ti.com> > CC: Felipe Balbi <balbi@ti.com> > CC: Santosh Shilimkar <santosh.shilimkar@ti.com> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> nice :-) Acked-by: Felipe Balbi <balbi@ti.com> -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140313/f77ff56e/attachment.sig> ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY 2014-03-13 15:20 ` Felipe Balbi @ 2014-03-13 21:44 ` Felipe Balbi 2014-04-02 17:53 ` Santosh Shilimkar 0 siblings, 1 reply; 11+ messages in thread From: Felipe Balbi @ 2014-03-13 21:44 UTC (permalink / raw) To: linux-arm-kernel Hi, On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote: > On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote: > > This fixes a regression on Keystone 2 platforms caused by patch > > 57303488cd37da58263e842de134dc65f7c626d5 > > "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds > > optional support of generic phy in DWC3 core. > > > > On Keystone 2 platforms the USB is not working now because > > CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs > > return -ENOSYS always. The log shows: > > dwc3 2690000.dwc3: failed to initialize core > > dwc3: probe of 2690000.dwc3 failed with error -38 > > > > Hence, fix it by making NULL a valid phy reference in Generic PHY > > APIs stubs in the same way as it was done by the patch > > 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL > > a valid phy reference". > > > > CC: Kishon Vijay Abraham I <kishon@ti.com> > > CC: Felipe Balbi <balbi@ti.com> > > CC: Santosh Shilimkar <santosh.shilimkar@ti.com> > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > > nice :-) > > Acked-by: Felipe Balbi <balbi@ti.com> Greg, if your tree isn't closed yet, could you consider this patch still for v3.15 merge window ? Grygorii found a regression on Keystone platforms which this patch fixes. Let me know if you need the original patch and myself or Kishon can send it to you. -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140313/55851acc/attachment.sig> ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY 2014-03-13 21:44 ` Felipe Balbi @ 2014-04-02 17:53 ` Santosh Shilimkar 2014-04-02 18:16 ` Greg KH 0 siblings, 1 reply; 11+ messages in thread From: Santosh Shilimkar @ 2014-04-02 17:53 UTC (permalink / raw) To: linux-arm-kernel On Thursday 13 March 2014 05:44 PM, Felipe Balbi wrote: > Hi, > > On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote: >> On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote: >>> This fixes a regression on Keystone 2 platforms caused by patch >>> 57303488cd37da58263e842de134dc65f7c626d5 >>> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds >>> optional support of generic phy in DWC3 core. >>> >>> On Keystone 2 platforms the USB is not working now because >>> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs >>> return -ENOSYS always. The log shows: >>> dwc3 2690000.dwc3: failed to initialize core >>> dwc3: probe of 2690000.dwc3 failed with error -38 >>> >>> Hence, fix it by making NULL a valid phy reference in Generic PHY >>> APIs stubs in the same way as it was done by the patch >>> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL >>> a valid phy reference". >>> >>> CC: Kishon Vijay Abraham I <kishon@ti.com> >>> CC: Felipe Balbi <balbi@ti.com> >>> CC: Santosh Shilimkar <santosh.shilimkar@ti.com> >>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> >> nice :-) >> >> Acked-by: Felipe Balbi <balbi@ti.com> > > Greg, if your tree isn't closed yet, could you consider this patch still > for v3.15 merge window ? Grygorii found a regression on Keystone > platforms which this patch fixes. Let me know if you need the original > patch and myself or Kishon can send it to you. > Just checking whether the fix was picked up for the 3.14 merge window ? Regards, Santosh ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY 2014-04-02 17:53 ` Santosh Shilimkar @ 2014-04-02 18:16 ` Greg KH 2014-04-02 18:17 ` Santosh Shilimkar 0 siblings, 1 reply; 11+ messages in thread From: Greg KH @ 2014-04-02 18:16 UTC (permalink / raw) To: linux-arm-kernel On Wed, Apr 02, 2014 at 01:53:19PM -0400, Santosh Shilimkar wrote: > On Thursday 13 March 2014 05:44 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote: > >> On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote: > >>> This fixes a regression on Keystone 2 platforms caused by patch > >>> 57303488cd37da58263e842de134dc65f7c626d5 > >>> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds > >>> optional support of generic phy in DWC3 core. > >>> > >>> On Keystone 2 platforms the USB is not working now because > >>> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs > >>> return -ENOSYS always. The log shows: > >>> dwc3 2690000.dwc3: failed to initialize core > >>> dwc3: probe of 2690000.dwc3 failed with error -38 > >>> > >>> Hence, fix it by making NULL a valid phy reference in Generic PHY > >>> APIs stubs in the same way as it was done by the patch > >>> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL > >>> a valid phy reference". > >>> > >>> CC: Kishon Vijay Abraham I <kishon@ti.com> > >>> CC: Felipe Balbi <balbi@ti.com> > >>> CC: Santosh Shilimkar <santosh.shilimkar@ti.com> > >>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > >> > >> nice :-) > >> > >> Acked-by: Felipe Balbi <balbi@ti.com> > > > > Greg, if your tree isn't closed yet, could you consider this patch still > > for v3.15 merge window ? Grygorii found a regression on Keystone > > platforms which this patch fixes. Let me know if you need the original > > patch and myself or Kishon can send it to you. > > > Just checking whether the fix was picked up for the 3.14 merge window ? 3.14 is long released, the merge window for that was months ago. greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY 2014-04-02 18:16 ` Greg KH @ 2014-04-02 18:17 ` Santosh Shilimkar 2014-04-02 18:26 ` Greg KH 0 siblings, 1 reply; 11+ messages in thread From: Santosh Shilimkar @ 2014-04-02 18:17 UTC (permalink / raw) To: linux-arm-kernel On Wednesday 02 April 2014 02:16 PM, Greg KH wrote: > On Wed, Apr 02, 2014 at 01:53:19PM -0400, Santosh Shilimkar wrote: >> On Thursday 13 March 2014 05:44 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote: >>>> On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote: >>>>> This fixes a regression on Keystone 2 platforms caused by patch >>>>> 57303488cd37da58263e842de134dc65f7c626d5 >>>>> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds >>>>> optional support of generic phy in DWC3 core. >>>>> >>>>> On Keystone 2 platforms the USB is not working now because >>>>> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs >>>>> return -ENOSYS always. The log shows: >>>>> dwc3 2690000.dwc3: failed to initialize core >>>>> dwc3: probe of 2690000.dwc3 failed with error -38 >>>>> >>>>> Hence, fix it by making NULL a valid phy reference in Generic PHY >>>>> APIs stubs in the same way as it was done by the patch >>>>> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL >>>>> a valid phy reference". >>>>> >>>>> CC: Kishon Vijay Abraham I <kishon@ti.com> >>>>> CC: Felipe Balbi <balbi@ti.com> >>>>> CC: Santosh Shilimkar <santosh.shilimkar@ti.com> >>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >>>> >>>> nice :-) >>>> >>>> Acked-by: Felipe Balbi <balbi@ti.com> >>> >>> Greg, if your tree isn't closed yet, could you consider this patch still >>> for v3.15 merge window ? Grygorii found a regression on Keystone >>> platforms which this patch fixes. Let me know if you need the original >>> patch and myself or Kishon can send it to you. >>> >> Just checking whether the fix was picked up for the 3.14 merge window ? > > 3.14 is long released, the merge window for that was months ago. > Sorry for the typo. I mean for upcoming v3.15 merge window. regards, Santosh ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY 2014-04-02 18:17 ` Santosh Shilimkar @ 2014-04-02 18:26 ` Greg KH 0 siblings, 0 replies; 11+ messages in thread From: Greg KH @ 2014-04-02 18:26 UTC (permalink / raw) To: linux-arm-kernel On Wed, Apr 02, 2014 at 02:17:19PM -0400, Santosh Shilimkar wrote: > On Wednesday 02 April 2014 02:16 PM, Greg KH wrote: > > On Wed, Apr 02, 2014 at 01:53:19PM -0400, Santosh Shilimkar wrote: > >> On Thursday 13 March 2014 05:44 PM, Felipe Balbi wrote: > >>> Hi, > >>> > >>> On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote: > >>>> On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote: > >>>>> This fixes a regression on Keystone 2 platforms caused by patch > >>>>> 57303488cd37da58263e842de134dc65f7c626d5 > >>>>> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds > >>>>> optional support of generic phy in DWC3 core. > >>>>> > >>>>> On Keystone 2 platforms the USB is not working now because > >>>>> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs > >>>>> return -ENOSYS always. The log shows: > >>>>> dwc3 2690000.dwc3: failed to initialize core > >>>>> dwc3: probe of 2690000.dwc3 failed with error -38 > >>>>> > >>>>> Hence, fix it by making NULL a valid phy reference in Generic PHY > >>>>> APIs stubs in the same way as it was done by the patch > >>>>> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL > >>>>> a valid phy reference". > >>>>> > >>>>> CC: Kishon Vijay Abraham I <kishon@ti.com> > >>>>> CC: Felipe Balbi <balbi@ti.com> > >>>>> CC: Santosh Shilimkar <santosh.shilimkar@ti.com> > >>>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > >>>> > >>>> nice :-) > >>>> > >>>> Acked-by: Felipe Balbi <balbi@ti.com> > >>> > >>> Greg, if your tree isn't closed yet, could you consider this patch still > >>> for v3.15 merge window ? Grygorii found a regression on Keystone > >>> platforms which this patch fixes. Let me know if you need the original > >>> patch and myself or Kishon can send it to you. > >>> > >> Just checking whether the fix was picked up for the 3.14 merge window ? > > > > 3.14 is long released, the merge window for that was months ago. > > > Sorry for the typo. I mean for upcoming v3.15 merge window. My trees are now "empty" now, with everything I had for the 3.15-rc1 merge window already in Linus's tree. So I suggest looking there to see if this made it in or not. If not, be sure to resend it. thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-04-16 10:09 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-03-13 11:11 [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY Grygorii Strashko 2014-03-13 13:37 ` Santosh Shilimkar 2014-03-13 13:43 ` Kishon Vijay Abraham I 2014-03-13 13:47 ` Santosh Shilimkar 2014-04-16 10:09 ` Kishon Vijay Abraham I 2014-03-13 15:20 ` Felipe Balbi 2014-03-13 21:44 ` Felipe Balbi 2014-04-02 17:53 ` Santosh Shilimkar 2014-04-02 18:16 ` Greg KH 2014-04-02 18:17 ` Santosh Shilimkar 2014-04-02 18:26 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).