From: elder@linaro.org (Alex Elder)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/10] ARM: bcm: tidy up a few includes
Date: Fri, 18 Apr 2014 07:05:11 -0500 [thread overview]
Message-ID: <535114F7.20307@linaro.org> (raw)
In-Reply-To: <20140418082936.GA24070@n2100.arm.linux.org.uk>
On 04/18/2014 03:29 AM, Russell King - ARM Linux wrote:
> On Thu, Apr 17, 2014 at 09:30:12PM -0500, Alex Elder wrote:
>> Clean up a few header file includes, eliminating a few that are not
>> really needed and putting in their place some that are.
>>
>> Signed-off-by: Alex Elder <elder@linaro.org>
>> Reviewed-by: Matt Porter <mporter@linaro.org>
>> ---
>> arch/arm/mach-bcm/board_bcm21664.c | 3 +--
>> arch/arm/mach-bcm/kona.c | 5 +++--
>> arch/arm/mach-bcm/kona.h | 1 +
>> 3 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-bcm/board_bcm21664.c b/arch/arm/mach-bcm/board_bcm21664.c
>> index acc1573..ab96c3f 100644
>> --- a/arch/arm/mach-bcm/board_bcm21664.c
>> +++ b/arch/arm/mach-bcm/board_bcm21664.c
>> @@ -11,13 +11,12 @@
>> * GNU General Public License for more details.
>> */
>>
>> -#include <linux/clocksource.h>
>> #include <linux/of_address.h>
>> #include <linux/of_platform.h>
>>
>> #include <asm/mach/arch.h>
>> +#include <asm/io.h>
>
> It's linux/io.h
Fixed, as you'll see when I post v2 later.
>> diff --git a/arch/arm/mach-bcm/kona.h b/arch/arm/mach-bcm/kona.h
>> index 110185f..bcdcf06 100644
>> --- a/arch/arm/mach-bcm/kona.h
>> +++ b/arch/arm/mach-bcm/kona.h
>> @@ -12,6 +12,7 @@
>> */
>>
>> #ifdef CONFIG_ARCH_BCM_MOBILE_L2_CACHE
>> +#include <linux/init.h>
>>
>> void __init kona_l2_cache_init(void);
>
> Just get rid of the __init instead.
Because __init is a "section" attribute, which affects
code and not the prototype. That's great, thanks a lot.
-Alex
next prev parent reply other threads:[~2014-04-18 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 2:30 [PATCH 00/10] ARM: bcm: SCM and L2 cache code cleanup Alex Elder
2014-04-18 2:30 ` [PATCH 01/10] ARM: bcm: use memory accessors for ioremapped area Alex Elder
2014-04-18 2:30 ` [PATCH 02/10] ARM: bcm: err, don't BUG() on SMC init failures Alex Elder
2014-04-18 2:30 ` [PATCH 03/10] ARM: bcm: clean up SMC code Alex Elder
2014-04-18 2:30 ` [PATCH 04/10] ARM: bcm: have bcm_kona_smc() return request result Alex Elder
2014-04-18 2:30 ` [PATCH 05/10] ARM: bcm: don't special-case CPU 0 in bcm_kona_smc() Alex Elder
2014-04-18 2:30 ` [PATCH 06/10] ARM: bcm: config option for l2 cache support Alex Elder
2014-04-18 2:30 ` [PATCH 07/10] ARM: bcm: tidy up a few includes Alex Elder
2014-04-18 8:29 ` Russell King - ARM Linux
2014-04-18 12:05 ` Alex Elder [this message]
2014-04-18 2:30 ` [PATCH 08/10] ARM: bcm: use inline assembly for "smc" request Alex Elder
2014-04-18 2:30 ` [PATCH 09/10] ARM: bcm: rewrite commentary for bcm_kona_do_smc() Alex Elder
2014-04-18 2:30 ` [PATCH 10/10] ARM: bcm: rename "kona.h" and "kona.c" Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535114F7.20307@linaro.org \
--to=elder@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).