[PATCH 0/2] Add chip ID for Exynos7870 SoC

[PATCH 0/2] Add chip ID for Exynos7870 SoC

[Kaustabh Chakraborty]

This patch series is a part of Exynos7870 upstreaming.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
Kaustabh Chakraborty (2):
      dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible
      soc: samsung: exynos-chipid: add support for exynos7870

 Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
 drivers/soc/samsung/exynos-chipid.c                                 | 1 +
 2 files changed, 2 insertions(+)
---
base-commit: df4b2bbff898227db0c14264ac7edd634e79f755
change-id: 20250203-exynos7870-chipid-c6f24a9a814d

Best regards,
-- 
Kaustabh Chakraborty <kauschluss@disroot.org>

[PATCH 1/2] dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible

[Kaustabh Chakraborty]

Document the compatible string "samsung,exynos7870-chipid". The
registers are entirely compatible with "samsung,exynos4210-chipid".

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
index 385aac7161a0db9334a92d78a57a125f23ca1920..9105ad48563a42ecaeb3dbca37df734d5b93f52c 100644
--- a/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
+++ b/Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml
@@ -19,6 +19,7 @@ properties:
           - enum:
               - samsung,exynos5433-chipid
               - samsung,exynos7-chipid
+              - samsung,exynos7870-chipid
           - const: samsung,exynos4210-chipid
       - items:
           - enum:

-- 
2.48.1

[PATCH 2/2] soc: samsung: exynos-chipid: add support for exynos7870

[Kaustabh Chakraborty]

Add the product ID of Exynos7870 (S5E7870) to the existing list.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 drivers/soc/samsung/exynos-chipid.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
index e37dde1fb588ec61d4e6b7cfe156161a62e035af..db0529fe13ae8e2ff96f055562c0a70e1ef74cb7 100644
--- a/drivers/soc/samsung/exynos-chipid.c
+++ b/drivers/soc/samsung/exynos-chipid.c
@@ -55,6 +55,7 @@ static const struct exynos_soc_id {
 	{ "EXYNOS5440", 0xE5440000 },
 	{ "EXYNOS5800", 0xE5422000 },
 	{ "EXYNOS7420", 0xE7420000 },
+	{ "EXYNOS7870", 0xE7870000 },
 	/* Compatible with: samsung,exynos850-chipid */
 	{ "EXYNOS7885", 0xE7885000 },
 	{ "EXYNOS850", 0xE3830000 },

-- 
2.48.1

Re: [PATCH 0/2] Add chip ID for Exynos7870 SoC

[Krzysztof Kozlowski]

On 03/02/2025 21:32, Kaustabh Chakraborty wrote:
> This patch series is a part of Exynos7870 upstreaming.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
> Kaustabh Chakraborty (2):
>       dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible
>       soc: samsung: exynos-chipid: add support for exynos7870
> 
>  Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
>  drivers/soc/samsung/exynos-chipid.c                                 | 1 +
>  2 files changed, 2 insertions(+)

When I asked to split, I said per subsystem. Soc is one subsystem.
Everything targeting SoC should be in one patchset. get_maintainers.pl
tells the name of the subsystem and its maintainers.

If there is going to be resend/new version, combine patchsets for soc
into one patchset (just like the example I gave last time).

Best regards,
Krzysztof

Re: [PATCH 0/2] Add chip ID for Exynos7870 SoC

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

On Tue, Feb 04, 2025 at 08:53:31AM +0100, Krzysztof Kozlowski wrote:
> On 03/02/2025 21:32, Kaustabh Chakraborty wrote:
> > This patch series is a part of Exynos7870 upstreaming.
> > 
> > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> > ---
> > Kaustabh Chakraborty (2):
> >       dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible
> >       soc: samsung: exynos-chipid: add support for exynos7870
> > 
> >  Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
> >  drivers/soc/samsung/exynos-chipid.c                                 | 1 +
> >  2 files changed, 2 insertions(+)
> 
> When I asked to split, I said per subsystem. Soc is one subsystem.
> Everything targeting SoC should be in one patchset. get_maintainers.pl
> tells the name of the subsystem and its maintainers.
> 
> If there is going to be resend/new version, combine patchsets for soc
> into one patchset (just like the example I gave last time).

And please send patches to the address people list in maintainers, don't
modify the addresses.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 0/2] Add chip ID for Exynos7870 SoC

[Kaustabh Chakraborty]

On 2025-02-04 07:53, Krzysztof Kozlowski wrote:
> On 03/02/2025 21:32, Kaustabh Chakraborty wrote:
>> This patch series is a part of Exynos7870 upstreaming.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>> Kaustabh Chakraborty (2):
>>       dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible
>>       soc: samsung: exynos-chipid: add support for exynos7870
>> 
>>  Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
>>  drivers/soc/samsung/exynos-chipid.c                                 | 1 +
>>  2 files changed, 2 insertions(+)
> 
> When I asked to split, I said per subsystem. Soc is one subsystem.
> Everything targeting SoC should be in one patchset. get_maintainers.pl
> tells the name of the subsystem and its maintainers.
> 
> If there is going to be resend/new version, combine patchsets for soc
> into one patchset (just like the example I gave last time).

Alright, so I'll move these patches to the one which has the devicetrees.

There's also a Documentation/devicetree/bindings/soc/ patch in
exynos7870-pmu-clocks [1]. The CLKOUT driver uses the compatible declared
in there, i.e., the CLKOUT driver depends on that commit. So, should it
stay there? Or...?

[1] https://lore.kernel.org/r/20250204-exynos7870-pmu-clocks-v1-0-a3030ae5bb53@disroot.org

> 
> Best regards,
> Krzysztof

Re: [PATCH 0/2] Add chip ID for Exynos7870 SoC

[Krzysztof Kozlowski]

On 04/02/2025 20:29, Kaustabh Chakraborty wrote:
> On 2025-02-04 07:53, Krzysztof Kozlowski wrote:
>> On 03/02/2025 21:32, Kaustabh Chakraborty wrote:
>>> This patch series is a part of Exynos7870 upstreaming.
>>>
>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>> ---
>>> Kaustabh Chakraborty (2):
>>>       dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible
>>>       soc: samsung: exynos-chipid: add support for exynos7870
>>>
>>>  Documentation/devicetree/bindings/hwinfo/samsung,exynos-chipid.yaml | 1 +
>>>  drivers/soc/samsung/exynos-chipid.c                                 | 1 +
>>>  2 files changed, 2 insertions(+)
>>
>> When I asked to split, I said per subsystem. Soc is one subsystem.
>> Everything targeting SoC should be in one patchset. get_maintainers.pl
>> tells the name of the subsystem and its maintainers.
>>
>> If there is going to be resend/new version, combine patchsets for soc
>> into one patchset (just like the example I gave last time).
> 
> Alright, so I'll move these patches to the one which has the devicetrees.
> 
> There's also a Documentation/devicetree/bindings/soc/ patch in
> exynos7870-pmu-clocks [1]. The CLKOUT driver uses the compatible declared
> in there, i.e., the CLKOUT driver depends on that commit. So, should it
> stay there? Or...?

The binding stays with the driver.




Best regards,
Krzysztof