[PATCH 0/2] phy: samsung: add exynos5 SoCs for as simple phy providers

[PATCH 0/2] phy: samsung: add exynos5 SoCs for as simple phy providers

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Add Exynos5250 and 5420 as Simple phy providers to
the proposed simple phy driver by Tomasz Stanislawski
at https://lkml.org/lkml/2014/4/8/226.

Rahul Sharma (2):
  phy: samsung: add simple phys for exynos5250 SoC
  phy: samsung: add simple phys for exynos5420 SoC

 .../devicetree/bindings/phy/samsung-phy.txt        |   28 ++++++++++++++++++++
 drivers/phy/exynos-simple-phy.c                    |   17 ++++++++++++
 2 files changed, 45 insertions(+)
 mode change 100644 => 100755 drivers/phy/exynos-simple-phy.c

-- 
1.7.9.5

[PATCH 1/2] phy: samsung: add simple phys for exynos5250 SoC

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Extend the support for simple phys for exynos5250 SoC
in simple phy driver.

Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130
---
 .../devicetree/bindings/phy/samsung-phy.txt        |   22 ++++++++++++++++++++
 drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
 2 files changed, 31 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
index f97c4c3..f469099 100644
--- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
+++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
@@ -122,6 +122,7 @@ Required properties:
 - compatible : should be one of the listed compatibles:
 	- "samsung,exynos4210-simple-phy"
 	- "samsung,exynos4412-simple-phy"
+	- "samsung,exynos5250-simple-phy"
 - reg : offset and length of the register set;
 - #phy-cells : from the generic phy bindings, must be 1;
 
@@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its meaning is as follows:
   0 - HDMI PHY,
   1 - ADC PHY,
 
+For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in
+the PHY specifier identifies the PHY and its meaning is as follows:
+  0 - HDMI PHY,
+  1 - ADC PHY,
+  2 - ADC PHY,
+
+Example:
+Simple PHY provider node:
+
+	simplephys: simple-phys at 10040000 {
+		compatible = "samsung,exynos5250-simple-phy";
+		reg = <0x10040000 0x10000>;
+		#phy-cells = <1>;
+	};
+
+Other nodes accessing simple PHYs:
+
+	hdmi {
+		phys = <&simplephys 0>;
+		phy-names = "hdmiphy";
+	};
diff --git a/drivers/phy/exynos-simple-phy.c b/drivers/phy/exynos-simple-phy.c
index 57ad338..187f6b1 100644
--- a/drivers/phy/exynos-simple-phy.c
+++ b/drivers/phy/exynos-simple-phy.c
@@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
 	~0, /* end mark */
 };
 
+static const u32 exynos5250_offsets[] = {
+	0x0700, /* HDMI_PHY */
+	0x0718, /* ADC_PHY */
+	0x0724, /* SATA_PHY */
+	~0, /* end mark */
+};
+
 static const struct of_device_id exynos_phy_of_match[] = {
 	{ .compatible = "samsung,exynos4210-simple-phy",
 	  .data = exynos4210_offsets},
 	{ .compatible = "samsung,exynos4412-simple-phy",
 	  .data = exynos4412_offsets},
+	{ .compatible = "samsung,exynos5250-simple-phy",
+	  .data = exynos5250_offsets},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, exynos_phy_of_match);
-- 
1.7.9.5

[PATCH 2/2] phy: samsung: add simple phys for exynos5420 SoC

[Rahul Sharma]

From: Rahul Sharma <Rahul.Sharma@samsung.com>

Extend the support for simple phys for exynos5420
SoC in simple phy driver.

Change-Id: I0ab7b59b1f013db9e924fc868bd8b1b6ed8acbb3
Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
---
 .../devicetree/bindings/phy/samsung-phy.txt        |    6 ++++++
 drivers/phy/exynos-simple-phy.c                    |    8 ++++++++
 2 files changed, 14 insertions(+)
 mode change 100644 => 100755 drivers/phy/exynos-simple-phy.c

diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
index f469099..f0ae619 100644
--- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
+++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
@@ -123,6 +123,7 @@ Required properties:
 	- "samsung,exynos4210-simple-phy"
 	- "samsung,exynos4412-simple-phy"
 	- "samsung,exynos5250-simple-phy"
+	- "samsung,exynos5420-simple-phy"
 - reg : offset and length of the register set;
 - #phy-cells : from the generic phy bindings, must be 1;
 
@@ -145,6 +146,11 @@ the PHY specifier identifies the PHY and its meaning is as follows:
   1 - ADC PHY,
   2 - ADC PHY,
 
+For "samsung,exynos5420-simple-phy" compatible PHYs the second cell in
+the PHY specifier identifies the PHY and its meaning is as follows:
+  0 - HDMI PHY,
+  1 - ADC PHY,
+
 Example:
 Simple PHY provider node:
 
diff --git a/drivers/phy/exynos-simple-phy.c b/drivers/phy/exynos-simple-phy.c
old mode 100644
new mode 100755
index 187f6b1..9681a43
--- a/drivers/phy/exynos-simple-phy.c
+++ b/drivers/phy/exynos-simple-phy.c
@@ -71,6 +71,12 @@ static const u32 exynos5250_offsets[] = {
 	~0, /* end mark */
 };
 
+static const u32 exynos5420_offsets[] = {
+	0x0700, /* HDMI_PHY */
+	0x0720, /* ADC_PHY */
+	~0, /* end mark */
+};
+
 static const struct of_device_id exynos_phy_of_match[] = {
 	{ .compatible = "samsung,exynos4210-simple-phy",
 	  .data = exynos4210_offsets},
@@ -78,6 +84,8 @@ static const struct of_device_id exynos_phy_of_match[] = {
 	  .data = exynos4412_offsets},
 	{ .compatible = "samsung,exynos5250-simple-phy",
 	  .data = exynos5250_offsets},
+	{ .compatible = "samsung,exynos5420-simple-phy",
+	  .data = exynos5420_offsets},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, exynos_phy_of_match);
-- 
1.7.9.5

[PATCH 1/2] phy: samsung: add simple phys for exynos5250 SoC

[Pankaj Dubey]

Hi Rahul,

On 04/20/2014 07:08 PM, Rahul Sharma wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>
> Extend the support for simple phys for exynos5250 SoC
> in simple phy driver.
>
> Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130
Change-Id should be removed. Missing Signed-off-by.
> ---
>   .../devicetree/bindings/phy/samsung-phy.txt        |   22 ++++++++++++++++++++
>   drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
>   2 files changed, 31 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> index f97c4c3..f469099 100644
> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> @@ -122,6 +122,7 @@ Required properties:
>   - compatible : should be one of the listed compatibles:
>   	- "samsung,exynos4210-simple-phy"
>   	- "samsung,exynos4412-simple-phy"
> +	- "samsung,exynos5250-simple-phy"
>   - reg : offset and length of the register set;
>   - #phy-cells : from the generic phy bindings, must be 1;
>   
> @@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its meaning is as follows:
>     0 - HDMI PHY,
>     1 - ADC PHY,
>   
> +For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in
> +the PHY specifier identifies the PHY and its meaning is as follows:
> +  0 - HDMI PHY,
> +  1 - ADC PHY,
> +  2 - ADC PHY,
> +
> +Example:
> +Simple PHY provider node:
> +
> +	simplephys: simple-phys at 10040000 {
> +		compatible = "samsung,exynos5250-simple-phy";
> +		reg = <0x10040000 0x10000>;
> +		#phy-cells = <1>;
> +	};
> +
> +Other nodes accessing simple PHYs:
> +
> +	hdmi {
> +		phys = <&simplephys 0>;
> +		phy-names = "hdmiphy";
> +	};
> diff --git a/drivers/phy/exynos-simple-phy.c b/drivers/phy/exynos-simple-phy.c
> index 57ad338..187f6b1 100644
> --- a/drivers/phy/exynos-simple-phy.c
> +++ b/drivers/phy/exynos-simple-phy.c
> @@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
>   	~0, /* end mark */
>   };
>   
> +static const u32 exynos5250_offsets[] = {
> +	0x0700, /* HDMI_PHY */
> +	0x0718, /* ADC_PHY */
> +	0x0724, /* SATA_PHY */
> +	~0, /* end mark */
> +};
> +
>   static const struct of_device_id exynos_phy_of_match[] = {
>   	{ .compatible = "samsung,exynos4210-simple-phy",
>   	  .data = exynos4210_offsets},
>   	{ .compatible = "samsung,exynos4412-simple-phy",
>   	  .data = exynos4412_offsets},
> +	{ .compatible = "samsung,exynos5250-simple-phy",
> +	  .data = exynos5250_offsets},
>   	{ },
>   };
>   MODULE_DEVICE_TABLE(of, exynos_phy_of_match);


-- 
Best Regards,
Pankaj Dubey

[PATCH 2/2] phy: samsung: add simple phys for exynos5420 SoC

[Pankaj Dubey]

Hi Rahul,

On 04/20/2014 07:08 PM, Rahul Sharma wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>
> Extend the support for simple phys for exynos5420
> SoC in simple phy driver.
>
> Change-Id: I0ab7b59b1f013db9e924fc868bd8b1b6ed8acbb3
Change-Id should be removed.
> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com>
> ---
>   .../devicetree/bindings/phy/samsung-phy.txt        |    6 ++++++
>   drivers/phy/exynos-simple-phy.c                    |    8 ++++++++
>   2 files changed, 14 insertions(+)
>   mode change 100644 => 100755 drivers/phy/exynos-simple-phy.c
File permission should not be changed.
>
> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> index f469099..f0ae619 100644
> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> @@ -123,6 +123,7 @@ Required properties:
>   	- "samsung,exynos4210-simple-phy"
>   	- "samsung,exynos4412-simple-phy"
>   	- "samsung,exynos5250-simple-phy"
> +	- "samsung,exynos5420-simple-phy"
>   - reg : offset and length of the register set;
>   - #phy-cells : from the generic phy bindings, must be 1;
>   
> @@ -145,6 +146,11 @@ the PHY specifier identifies the PHY and its meaning is as follows:
>     1 - ADC PHY,
>     2 - ADC PHY,
>   
> +For "samsung,exynos5420-simple-phy" compatible PHYs the second cell in
> +the PHY specifier identifies the PHY and its meaning is as follows:
> +  0 - HDMI PHY,
> +  1 - ADC PHY,
> +
>   Example:
>   Simple PHY provider node:
>   
> diff --git a/drivers/phy/exynos-simple-phy.c b/drivers/phy/exynos-simple-phy.c
> old mode 100644
> new mode 100755
> index 187f6b1..9681a43
> --- a/drivers/phy/exynos-simple-phy.c
> +++ b/drivers/phy/exynos-simple-phy.c
> @@ -71,6 +71,12 @@ static const u32 exynos5250_offsets[] = {
>   	~0, /* end mark */
>   };
>   
> +static const u32 exynos5420_offsets[] = {
> +	0x0700, /* HDMI_PHY */
> +	0x0720, /* ADC_PHY */
> +	~0, /* end mark */
> +};
> +
>   static const struct of_device_id exynos_phy_of_match[] = {
>   	{ .compatible = "samsung,exynos4210-simple-phy",
>   	  .data = exynos4210_offsets},
> @@ -78,6 +84,8 @@ static const struct of_device_id exynos_phy_of_match[] = {
>   	  .data = exynos4412_offsets},
>   	{ .compatible = "samsung,exynos5250-simple-phy",
>   	  .data = exynos5250_offsets},
> +	{ .compatible = "samsung,exynos5420-simple-phy",
> +	  .data = exynos5420_offsets},
>   	{ },
>   };
>   MODULE_DEVICE_TABLE(of, exynos_phy_of_match);


-- 
Best Regards,
Pankaj Dubey

[PATCH 1/2] phy: samsung: add simple phys for exynos5250 SoC

[Rahul Sharma]

oops. Sorry, I will change that.

On 21 April 2014 06:20, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> Hi Rahul,
>
>
> On 04/20/2014 07:08 PM, Rahul Sharma wrote:
>>
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Extend the support for simple phys for exynos5250 SoC
>> in simple phy driver.
>>
>> Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130
>
> Change-Id should be removed. Missing Signed-off-by.
>
>> ---
>>   .../devicetree/bindings/phy/samsung-phy.txt        |   22
>> ++++++++++++++++++++
>>   drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
>>   2 files changed, 31 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> b/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> index f97c4c3..f469099 100644
>> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> @@ -122,6 +122,7 @@ Required properties:
>>   - compatible : should be one of the listed compatibles:
>>         - "samsung,exynos4210-simple-phy"
>>         - "samsung,exynos4412-simple-phy"
>> +       - "samsung,exynos5250-simple-phy"
>>   - reg : offset and length of the register set;
>>   - #phy-cells : from the generic phy bindings, must be 1;
>>   @@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its
>> meaning is as follows:
>>     0 - HDMI PHY,
>>     1 - ADC PHY,
>>   +For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in
>> +the PHY specifier identifies the PHY and its meaning is as follows:
>> +  0 - HDMI PHY,
>> +  1 - ADC PHY,
>> +  2 - ADC PHY,
>> +
>> +Example:
>> +Simple PHY provider node:
>> +
>> +       simplephys: simple-phys at 10040000 {
>> +               compatible = "samsung,exynos5250-simple-phy";
>> +               reg = <0x10040000 0x10000>;
>> +               #phy-cells = <1>;
>> +       };
>> +
>> +Other nodes accessing simple PHYs:
>> +
>> +       hdmi {
>> +               phys = <&simplephys 0>;
>> +               phy-names = "hdmiphy";
>> +       };
>> diff --git a/drivers/phy/exynos-simple-phy.c
>> b/drivers/phy/exynos-simple-phy.c
>> index 57ad338..187f6b1 100644
>> --- a/drivers/phy/exynos-simple-phy.c
>> +++ b/drivers/phy/exynos-simple-phy.c
>> @@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
>>         ~0, /* end mark */
>>   };
>>   +static const u32 exynos5250_offsets[] = {
>> +       0x0700, /* HDMI_PHY */
>> +       0x0718, /* ADC_PHY */
>> +       0x0724, /* SATA_PHY */
>> +       ~0, /* end mark */
>> +};
>> +
>>   static const struct of_device_id exynos_phy_of_match[] = {
>>         { .compatible = "samsung,exynos4210-simple-phy",
>>           .data = exynos4210_offsets},
>>         { .compatible = "samsung,exynos4412-simple-phy",
>>           .data = exynos4412_offsets},
>> +       { .compatible = "samsung,exynos5250-simple-phy",
>> +         .data = exynos5250_offsets},
>>         { },
>>   };
>>   MODULE_DEVICE_TABLE(of, exynos_phy_of_match);
>
>
>
> --
> Best Regards,
> Pankaj Dubey
>

[PATCH 1/2] phy: samsung: add simple phys for exynos5250 SoC

[Sachin Kamat]

Hi Rahul,

On 20 April 2014 15:38, Rahul Sharma <rahul.sharma@samsung.com> wrote:
> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>
> Extend the support for simple phys for exynos5250 SoC
> in simple phy driver.
>
> Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130
> ---
>  .../devicetree/bindings/phy/samsung-phy.txt        |   22 ++++++++++++++++++++
>  drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
>  2 files changed, 31 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> index f97c4c3..f469099 100644
> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
> @@ -122,6 +122,7 @@ Required properties:
>  - compatible : should be one of the listed compatibles:
>         - "samsung,exynos4210-simple-phy"
>         - "samsung,exynos4412-simple-phy"
> +       - "samsung,exynos5250-simple-phy"
>  - reg : offset and length of the register set;
>  - #phy-cells : from the generic phy bindings, must be 1;
>
> @@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its meaning is as follows:
>    0 - HDMI PHY,
>    1 - ADC PHY,
>
> +For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in
> +the PHY specifier identifies the PHY and its meaning is as follows:
> +  0 - HDMI PHY,
> +  1 - ADC PHY,
> +  2 - ADC PHY,

What is the difference between 1 and 2? Probably it should be SATA?

> +
> +Example:
> +Simple PHY provider node:
> +
> +       simplephys: simple-phys at 10040000 {
> +               compatible = "samsung,exynos5250-simple-phy";
> +               reg = <0x10040000 0x10000>;
> +               #phy-cells = <1>;
> +       };
> +
> +Other nodes accessing simple PHYs:
> +
> +       hdmi {
> +               phys = <&simplephys 0>;
> +               phy-names = "hdmiphy";
> +       };
> diff --git a/drivers/phy/exynos-simple-phy.c b/drivers/phy/exynos-simple-phy.c
> index 57ad338..187f6b1 100644
> --- a/drivers/phy/exynos-simple-phy.c
> +++ b/drivers/phy/exynos-simple-phy.c
> @@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
>         ~0, /* end mark */
>  };
>
> +static const u32 exynos5250_offsets[] = {
> +       0x0700, /* HDMI_PHY */
> +       0x0718, /* ADC_PHY */
> +       0x0724, /* SATA_PHY */
> +       ~0, /* end mark */
> +};
> +



-- 
With warm regards,
Sachin

[PATCH 1/2] phy: samsung: add simple phys for exynos5250 SoC

[Rahul Sharma]

Thanks Sachin,

On 21 April 2014 11:24, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi Rahul,
>
> On 20 April 2014 15:38, Rahul Sharma <rahul.sharma@samsung.com> wrote:
>> From: Rahul Sharma <Rahul.Sharma@samsung.com>
>>
>> Extend the support for simple phys for exynos5250 SoC
>> in simple phy driver.
>>
>> Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130
>> ---
>>  .../devicetree/bindings/phy/samsung-phy.txt        |   22 ++++++++++++++++++++
>>  drivers/phy/exynos-simple-phy.c                    |    9 ++++++++
>>  2 files changed, 31 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> index f97c4c3..f469099 100644
>> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> @@ -122,6 +122,7 @@ Required properties:
>>  - compatible : should be one of the listed compatibles:
>>         - "samsung,exynos4210-simple-phy"
>>         - "samsung,exynos4412-simple-phy"
>> +       - "samsung,exynos5250-simple-phy"
>>  - reg : offset and length of the register set;
>>  - #phy-cells : from the generic phy bindings, must be 1;
>>
>> @@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its meaning is as follows:
>>    0 - HDMI PHY,
>>    1 - ADC PHY,
>>
>> +For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in
>> +the PHY specifier identifies the PHY and its meaning is as follows:
>> +  0 - HDMI PHY,
>> +  1 - ADC PHY,
>> +  2 - ADC PHY,
>
> What is the difference between 1 and 2? Probably it should be SATA?
>

yea correct. it is Sata.

>> +
>> +Example:
>> +Simple PHY provider node:
>> +
>> +       simplephys: simple-phys at 10040000 {
>> +               compatible = "samsung,exynos5250-simple-phy";
>> +               reg = <0x10040000 0x10000>;
>> +               #phy-cells = <1>;
>> +       };
>> +
>> +Other nodes accessing simple PHYs:
>> +
>> +       hdmi {
>> +               phys = <&simplephys 0>;
>> +               phy-names = "hdmiphy";
>> +       };
>> diff --git a/drivers/phy/exynos-simple-phy.c b/drivers/phy/exynos-simple-phy.c
>> index 57ad338..187f6b1 100644
>> --- a/drivers/phy/exynos-simple-phy.c
>> +++ b/drivers/phy/exynos-simple-phy.c
>> @@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = {
>>         ~0, /* end mark */
>>  };
>>
>> +static const u32 exynos5250_offsets[] = {
>> +       0x0700, /* HDMI_PHY */
>> +       0x0718, /* ADC_PHY */
>> +       0x0724, /* SATA_PHY */
>> +       ~0, /* end mark */
>> +};
>> +
>
>
>
> --
> With warm regards,
> Sachin