linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 3/7] ARM: EXYNOS: Support secondary CPU boot of Exynos3250
Date: Fri, 25 Apr 2014 10:00:30 +0530	[thread overview]
Message-ID: <5359E4E6.90102@linaro.org> (raw)
In-Reply-To: <1398388572-30239-4-git-send-email-cw00.choi@samsung.com>

On 04/25/2014 06:46 AM, Chanwoo Choi wrote:
> This patch fix the offset of CPU boot address and don't need to send smc call
> of SMC_CMD_CPU1BOOT command for secondary CPU boot because Exynos3250 removes
> WFE in secure mode.
> 
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/mach-exynos/firmware.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
> index aa01c42..386d01d 100644
> --- a/arch/arm/mach-exynos/firmware.c
> +++ b/arch/arm/mach-exynos/firmware.c
> @@ -31,11 +31,17 @@ static int exynos_do_idle(void)
>  static int exynos_cpu_boot(int cpu)
>  {
>  	/*
> +	 * Exynos3250 doesn't need to send smc command for secondary CPU boot
> +	 * because Exynos3250 removes WFE in secure mode.
> +	 */
> +	if (soc_is_exynos3250())
> +		return 0;
> +	/*
>  	 * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
>  	 * But, Exynos4212 has only one secondary CPU so second parameter
>  	 * isn't used for informing secure firmware about CPU id.
>  	 */
> -	if (soc_is_exynos4212())
> +	else if (soc_is_exynos4212())

This changes is not required.

>  		cpu = 0;
>  
>  	exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0);
> @@ -46,7 +52,7 @@ static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
>  {
>  	void __iomem *boot_reg = S5P_VA_SYSRAM_NS + 0x1c;
>  
> -	if (!soc_is_exynos4212())
> +	if (!soc_is_exynos4212() && !soc_is_exynos3250())
>  		boot_reg += 4*cpu;
>  
>  	__raw_writel(boot_addr, boot_reg);
> 


-- 
Tushar Behera

  reply	other threads:[~2014-04-25  4:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25  1:16 [PATCHv4 0/7] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-04-25  1:16 ` [PATCHv4 1/7] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-04-26  0:40   ` Tomasz Figa
2014-04-25  1:16 ` [PATCHv4 2/7] ARM: EXYNOS: Support secondary CPU boot of Exynos4212 Chanwoo Choi
2014-04-26  0:42   ` Tomasz Figa
2014-04-26 10:49     ` Kukjin Kim
2014-04-25  1:16 ` [PATCHv4 3/7] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Chanwoo Choi
2014-04-25  4:30   ` Tushar Behera [this message]
2014-04-25  5:43     ` Chanwoo Choi
2014-04-25  5:54       ` Tushar Behera
2014-04-25  5:56         ` Chanwoo Choi
2014-04-25  1:16 ` [PATCHv4 4/7] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 Chanwoo Choi
2014-04-26  0:25   ` Tomasz Figa
2014-04-26  0:30     ` Russell King - ARM Linux
2014-04-30  8:00     ` Chanwoo Choi
2014-04-25  1:16 ` [PATCHv4 5/7] clk: samsung: exynos3250: Add clocks using common clock framework Chanwoo Choi
2014-04-26  0:39   ` Tomasz Figa
2014-05-13 11:49     ` Chanwoo Choi
2014-05-13 16:28       ` Tomasz Figa
2014-05-14  6:57         ` Chanwoo Choi
2014-05-14 13:45           ` Tomasz Figa
2014-04-25  1:16 ` [PATCHv4 6/7] dt-bindings: add documentation for Exynos3250 clock controller Chanwoo Choi
2014-04-25  1:16 ` [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250 Chanwoo Choi
2014-04-25  4:38   ` Tushar Behera
2014-04-25  5:03     ` Chanwoo Choi
2014-04-26  0:51   ` Tomasz Figa
2014-04-26 11:38     ` Tomasz Figa
2014-05-09  6:49       ` Chanwoo Choi
2014-05-09  8:01         ` Tomasz Figa
2014-05-09  8:15           ` Chanwoo Choi
2014-05-09  1:06     ` Chanwoo Choi
2014-05-09  5:02       ` Tomasz Figa
2014-05-09  7:10         ` Chanwoo Choi
2014-05-09  8:01           ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5359E4E6.90102@linaro.org \
    --to=tushar.behera@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).